Project:
| View Issue Details[ Jump to Notes ] | [ Issue History ] [ Print ] | |||||||
| ID | ||||||||
| 0013581 | ||||||||
| Type | Category | Severity | Reproducibility | Date Submitted | Last Update | |||
| defect | [Openbravo ERP] Z. Others | critical | have not tried | 2010-06-08 16:03 | 2010-06-10 00:00 | |||
| Reporter | shuehner | View Status | public | |||||
| Assigned To | dalsasua | |||||||
| Priority | immediate | Resolution | fixed | Fixed in Version | ||||
| Status | closed | Fix in branch | pi | Fixed in SCM revision | 6114b06b7e81 | |||
| Projection | none | ETA | none | Target Version | ||||
| OS | Any | Database | Any | Java version | ||||
| OS Version | Database version | Ant version | ||||||
| Product Version | pi | SCM revision | ||||||
| Review Assigned To | ||||||||
| Web browser | ||||||||
| Modules | Core | |||||||
| Regression level | ||||||||
| Regression date | ||||||||
| Regression introduced in release | ||||||||
| Regression introduced by commit | ||||||||
| Triggers an Emergency Pack | No | |||||||
| Summary | 0013581: pi api-check build 411 fails | |||||||
| Description | This api check build fails: http://builds.openbravo.com/job/erp_devel_pi-module-integrity-test/411/console [^] org.openbravo.erpCommon.ad_forms: Missing method org.openbravo.erpCommon.ad_forms.DocMatchInv.loadLines(org.openbravo.database.ConnectionProvider): missing in /var/www/localhost/htdocs/japi/411 | |||||||
| Tags | No tags attached. | |||||||
| Attached Files | ||||||||
 Relationships [ Relation Graph ]
[ Dependency Graph ]
|
||||||||
|
||||||||
 Relationships |
|
Notes |
|
|
(0028189) dalsasua (reporter) 2010-06-08 16:16 |
In the servlet src/org/openbravo/erpCommon/ad_forms/DocMatchInv.java existed the function public DocLine[] loadLines(ConnectionProvider conn) that just returned null, and was not referenced by nobody (but was public). In the fix for issue 13552 I added logic to that function, and for doing so, I provided it a parameter, so function definition is now: public DocLine[] loadLines(ConnectionProvider conn, String strCInvoiceLineId) We have two options now: 1) Remove old function as has no logic inside (so a low risk API change takes place) 2) Maintain old function although has no logic implemented (no API change happens, but garbage code is there). |
|
(0028198) pjuvara (reporter) 2010-06-08 20:00 |
Accepted as API change. Please send alert as low risk issue. |
|
(0028200) hgbot (developer) 2010-06-09 08:56 |
Repository: erp/devel/api-checks Changeset: 6114b06b7e81a5519a5112b7a2e110b1631e79fb Author: David Alsasua <david.alsasua <at> openbravo.com> Date: Wed Jun 09 08:55:53 2010 +0200 URL: http://code.openbravo.com/erp/devel/api-checks/rev/6114b06b7e81a5519a5112b7a2e110b1631e79fb [^] Fixes issue 13581: pi api-check build 411 fails --- M java/reference/250.japi.gz --- |
|
Notes |
|
Issue History |
|||
| Date Modified | Username | Field | Change |
| 2010-06-08 16:03 | shuehner | New Issue | |
| 2010-06-08 16:03 | shuehner | Assigned To | => dalsasua |
| 2010-06-08 16:06 | shuehner | Relationship added | related to 0013552 |
| 2010-06-08 16:16 | dalsasua | Assigned To | dalsasua => pjuvara |
| 2010-06-08 16:16 | dalsasua | Note Added: 0028189 | |
| 2010-06-08 20:00 | pjuvara | Status | new => scheduled |
| 2010-06-08 20:00 | pjuvara | Note Added: 0028198 | |
| 2010-06-08 20:00 | pjuvara | Assigned To | pjuvara => dalsasua |
| 2010-06-08 20:00 | pjuvara | fix_in_branch | => pi |
| 2010-06-09 08:56 | hgbot | Checkin | |
| 2010-06-09 08:56 | hgbot | Note Added: 0028200 | |
| 2010-06-09 08:56 | hgbot | Status | scheduled => resolved |
| 2010-06-09 08:56 | hgbot | Resolution | open => fixed |
| 2010-06-09 08:56 | hgbot | Fixed in SCM revision | => http://code.openbravo.com/erp/devel/api-checks/rev/6114b06b7e81a5519a5112b7a2e110b1631e79fb [^] |
| 2010-06-09 12:33 | dalsasua | Status | resolved => closed |
| 2010-06-10 00:00 | anonymous | sf_bug_id | 0 => 3014011 |
|
Issue History |
| Copyright © 2000 - 2009 MantisBT Group |
 |