Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0013581Openbravo ERPZ. Otherspublic2010-06-08 16:032010-06-10 00:00
Reportershuehner 
Assigned Todalsasua 
PriorityimmediateSeveritycriticalReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Versionpi 
Target VersionFixed in Version 
Merge Request Status
Review Assigned To
OBNetwork customerNo
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0013581: pi api-check build 411 fails
DescriptionThis api check build fails:

http://builds.openbravo.com/job/erp_devel_pi-module-integrity-test/411/console [^]

org.openbravo.erpCommon.ad_forms:
Missing
method org.openbravo.erpCommon.ad_forms.DocMatchInv.loadLines(org.openbravo.database.ConnectionProvider): missing in /var/www/localhost/htdocs/japi/411
Steps To Reproduce
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
related to defect 00135522.50MP19 closed dalsasua Project dimension is not taken into account when posting matched invoices with accounting dimensions 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2010-06-08 16:03shuehnerNew Issue
2010-06-08 16:03shuehnerAssigned To => dalsasua
2010-06-08 16:03shuehnerOBNetwork customer => No
2010-06-08 16:06shuehnerRelationship addedrelated to 0013552
2010-06-08 16:16dalsasuaAssigned Todalsasua => pjuvara
2010-06-08 16:16dalsasuaNote Added: 0028189
2010-06-08 20:00pjuvaraStatusnew => scheduled
2010-06-08 20:00pjuvaraNote Added: 0028198
2010-06-08 20:00pjuvaraAssigned Topjuvara => dalsasua
2010-06-08 20:00pjuvarafix_in_branch => pi
2010-06-09 08:56hgbotCheckin
2010-06-09 08:56hgbotNote Added: 0028200
2010-06-09 08:56hgbotStatusscheduled => resolved
2010-06-09 08:56hgbotResolutionopen => fixed
2010-06-09 08:56hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/api-checks/rev/6114b06b7e81a5519a5112b7a2e110b1631e79fb [^]
2010-06-09 12:33dalsasuaStatusresolved => closed
2010-06-10 00:00anonymoussf_bug_id0 => 3014011

Notes
(0028189)
dalsasua   
2010-06-08 16:16   
In the servlet src/org/openbravo/erpCommon/ad_forms/DocMatchInv.java existed the function
public DocLine[] loadLines(ConnectionProvider conn)
that just returned null, and was not referenced by nobody (but was public). In the fix for issue 13552 I added logic to that function, and for doing so, I provided it a parameter, so function definition is now:
public DocLine[] loadLines(ConnectionProvider conn, String strCInvoiceLineId)
We have two options now:
1) Remove old function as has no logic inside (so a low risk API change takes place)
2) Maintain old function although has no logic implemented (no API change happens, but garbage code is there).
(0028198)
pjuvara   
2010-06-08 20:00   
Accepted as API change.

Please send alert as low risk issue.
(0028200)
hgbot   
2010-06-09 08:56   
Repository: erp/devel/api-checks
Changeset: 6114b06b7e81a5519a5112b7a2e110b1631e79fb
Author: David Alsasua <david.alsasua <at> openbravo.com>
Date: Wed Jun 09 08:55:53 2010 +0200
URL: http://code.openbravo.com/erp/devel/api-checks/rev/6114b06b7e81a5519a5112b7a2e110b1631e79fb [^]

Fixes issue 13581: pi api-check build 411 fails

---
M java/reference/250.japi.gz
---