Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue Details[ Jump to Notes ] [ Issue History ] [ Print ]
ID
0013325
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[Openbravo ERP] A. Platformmajoralways2010-05-14 11:272010-08-19 14:33
ReporternetworkbView Statuspublic 
Assigned Toharikrishnan 
PriorityurgentResolutionfixedFixed in Version2.50MP21
StatusclosedFix in branchFixed in SCM revisione6fc833ee397
ProjectionnoneETAnoneTarget Version2.50MP18
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product Version2.50MP14SCM revision 
Merge Request Status
Review Assigned To
OBNetwork customerOBPS
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0013325: The application does not work properly depending Format's and PostgreSQL's configuration

DescriptionPostgreSQL's configuration in English.

1.- In the postgresql.conf:

>> lc_messages = 'es_ES.UTF-8' # locale for system error message
>> # strings
>> lc_monetary = 'es_ES.UTF-8' # locale for monetary formatting
>> lc_numeric = 'es_ES.UTF-8' # locale for number formatting
>> lc_time = 'es_ES.UTF-8' # locale for time formatting
>>
>> default_text_search_config = 'pg_catalog.spanish'

2.- Format attached. (Decimal separation ',', Millar separation '.')

With this configuration, PostgreSQL understands the ',' as separation of millar so it eliminates the coma. IE:

with spanish configuration:
select to_number('5,0000') from dual ---> 5.00

with english configuration:
select to_number('5,0000') from dual ---> 50000
Steps To Reproduce- With these configurations and as Openbravo Admin go to Sales Management || Transactions || Sales Invoice
- Create a new record, and go to Lines.
- Select Hammer
- Realize that the Net Unit Price is wrong.
TagsNo tags attached.
Attached Filesxml file icon Format12.xml [^] (3,239 bytes) 2010-05-14 11:27

- Relationships [ Relation Graph ] [ Dependency Graph ]
related to defect 00133202.50MP18 closedadrianromero Different behaviour when changing decimal separator 
has duplicate defect 0014354 closedadrianromero If ',' character is the decimal separator, then invoice line do not populate amounts and tax values when selecting a product 
related to defect 0014531 closedmohankumar Using Comma as decimal separator causes malfunctions on Sales Invoice Lines 

-  Notes
(0027239)
networkb (viewer)
2010-05-14 12:32

 IE:
This bug affects the method getOffersPriceInvoice on SL_Order_Product_data.xsql
(0027242)
iperdomo (viewer)
2010-05-14 12:42
edited on: 2010-05-14 12:42

 The issue is related to fix issue 0012366
(0027744)
vmromanos (viewer)
2010-05-26 12:54

 0013320 fixed this issue, but it's pending the same scenario for Orders
(0027746)
hgbot (developer)
2010-05-26 13:01

 Repository: erp/devel/pi
Changeset: 693e335d4298ea77e3431cff91d3625f2ae5349b
Author: Víctor Martínez Romanos <victor.martinez <at> openbravo.com>
Date: Wed May 26 12:57:16 2010 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/693e335d4298ea77e3431cff91d3625f2ae5349b [^]

Fixed bug 13325: The application does not work properly depending Format and PostgreSQL configuration

---
M src/org/openbravo/erpCommon/ad_callouts/SL_Order_Amt.java
---
(0027931)
hudsonbot (viewer)
2010-06-03 22:49

 A changeset related to this issue has been promoted to main after passing a series of tests and an OBX has been generated:

Changeset: http://code.openbravo.com/erp/devel/main/rev/693e335d4298 [^]
Merge Changeset: http://code.openbravo.com/erp/devel/main/rev/c011484a38d9 [^]
Tests: http://builds.openbravo.com/view/int/ [^]
OBX: http://builds.openbravo.com/erp/core/obx/OpenbravoERP-2.50CI.17407.obx [^]
(0029273)
networkb (viewer)
2010-07-13 20:24

 Still falling in MP19, in Invoice Sales Line the price is multiplied by 100. (6,00 => 600)
(0029523)
adrianromero (viewer)
2010-07-23 12:05

 I have been testing in the latest version with the attached Format.xml and I cannot reproduce it. I did not modified the postgresql configuration because it does not affect the behavior of Openbravo ERP. I mean, Openbravo ERP never executes sentences like "select to_number('5,0000') from dual" because number values are always passed to SQL as parameters.

Jon also tested it and we was not able to reproduce it too.
(0029684)
networkb (viewer)
2010-07-29 19:30

 I tried again in a mp19 virtual appliance for vmware, and still falling in Sales Invoice Line. Maybe the problem is the Product Selector, when uses M_BOM_PriceStd() functions.
(0029685)
networkb (viewer)
2010-07-29 19:31

 I tried again in a mp19 virtual appliance for vmware, and still falling in Sales Invoice Line. Maybe the problem is the Product Selector, when uses M_BOM_PriceStd() functions.
(0029749)
hgbot (developer)
2010-08-02 16:17

 Repository: erp/devel/pi
Changeset: e6fc833ee3976ebb4efba81accb2f92b9286a0b8
Author: Harikrishnan Raja <harikrishnan.raja <at> openbravo.com>
Date: Mon Aug 02 19:46:28 2010 +0530
URL: http://code.openbravo.com/erp/devel/pi/rev/e6fc833ee3976ebb4efba81accb2f92b9286a0b8 [^]

Fixes Issue 13325: Method M_GET_OFFERS_PRICE the standard price will be passed with comma separated (Example : 35,00) standard price.Hence the value is not calculated properly.

---
M src/org/openbravo/erpCommon/ad_callouts/SL_Invoice_Product.java
---
(0029750)
harikrishnan (viewer)
2010-08-02 16:18
edited on: 2010-08-19 11:14

 Steps To Test:

*Copy the Format.xml to the workspace and run compile.development -Dtab="xxx".
*Now go to Sales Invoice line and create a record for any product.Now the Price will be properly calculated.
*Restart tomcat

Root Cause:

*Method M_GET_OFFERS_PRICE the standard price will be passed with comma separated (Example : 35,00) standard price.Hence the value is not calculated properly.

Impact:
*The fix is also tested in Purchase Invoice.
(0029793)
hudsonbot (viewer)
2010-08-05 09:16

 A changeset related to this issue has been promoted to main after passing a series of tests and an OBX has been generated:

Changeset: http://code.openbravo.com/erp/devel/main/rev/e6fc833ee397 [^]
Merge Changeset: http://code.openbravo.com/erp/devel/main/rev/02ad8e3730d2 [^]
Tests: http://builds.openbravo.com/view/int/ [^]
OBX: http://builds.openbravo.com/erp/core/obx/OpenbravoERP-2.50CI.18019.obx [^]
(0030157)
psarobe (viewer)
2010-08-19 14:33

 Tested working fine

- Issue History
Date Modified Username Field Change
2010-05-14 11:27 networkb New Issue
2010-05-14 11:27 networkb Assigned To => alostale
2010-05-14 11:27 networkb File Added: Format12.xml
2010-05-14 11:27 networkb OBNetwork customer => Yes
2010-05-14 12:21 alostale Status new => scheduled
2010-05-14 12:21 alostale Assigned To alostale => iperdomo
2010-05-14 12:21 alostale fix_in_branch => pi
2010-05-14 12:32 networkb Note Added: 0027239
2010-05-14 12:41 iperdomo Assigned To iperdomo => dalsasua
2010-05-14 12:42 iperdomo Note Added: 0027242
2010-05-14 12:42 iperdomo Note Edited: 0027242 View Revisions
2010-05-18 19:11 networkb Target Version 2.50MP17 => 2.50MP18
2010-05-18 19:11 networkb fix_in_branch pi =>
2010-05-26 12:39 vmromanos Relationship added related to 0013320
2010-05-26 12:54 vmromanos Assigned To dalsasua => vmromanos
2010-05-26 12:54 vmromanos Note Added: 0027744
2010-05-26 13:01 hgbot Checkin
2010-05-26 13:01 hgbot Note Added: 0027746
2010-05-26 13:01 hgbot Status scheduled => resolved
2010-05-26 13:01 hgbot Resolution open => fixed
2010-05-26 13:01 hgbot Fixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/693e335d4298ea77e3431cff91d3625f2ae5349b [^]
2010-06-03 22:49 hudsonbot Checkin
2010-06-03 22:49 hudsonbot Note Added: 0027931
2010-06-29 12:52 rafaroda Issue Monitored: rafaroda
2010-07-13 20:24 networkb Note Added: 0029273
2010-07-23 10:48 jonalegriaesarte Status resolved => new
2010-07-23 10:48 jonalegriaesarte Resolution fixed => open
2010-07-23 12:05 adrianromero Note Added: 0029523
2010-07-23 12:05 adrianromero Status new => closed
2010-07-23 12:05 adrianromero Resolution open => unable to reproduce
2010-07-24 00:00 anonymous sf_bug_id 0 => 3033791
2010-07-29 19:30 networkb Note Added: 0029684
2010-07-29 19:31 networkb Note Added: 0029685
2010-07-29 19:31 networkb Status closed => new
2010-07-29 19:31 networkb Resolution unable to reproduce => open
2010-08-02 16:17 harikrishnan Assigned To vmromanos => harikrishnan
2010-08-02 16:17 hgbot Checkin
2010-08-02 16:17 hgbot Note Added: 0029749
2010-08-02 16:17 hgbot Status new => resolved
2010-08-02 16:17 hgbot Resolution open => fixed
2010-08-02 16:17 hgbot Fixed in SCM revision http://code.openbravo.com/erp/devel/pi/rev/693e335d4298ea77e3431cff91d3625f2ae5349b [^] => http://code.openbravo.com/erp/devel/pi/rev/e6fc833ee3976ebb4efba81accb2f92b9286a0b8 [^]
2010-08-02 16:18 harikrishnan Note Added: 0029750
2010-08-05 09:16 hudsonbot Checkin
2010-08-05 09:16 hudsonbot Note Added: 0029793
2010-08-19 11:14 psarobe Note Edited: 0029750 View Revisions
2010-08-19 14:33 psarobe Note Added: 0030157
2010-08-19 14:33 psarobe Status resolved => closed
2010-08-19 14:33 psarobe Fixed in Version => 2.50MP21
2010-08-30 11:17 adrianromero Relationship added has duplicate 0014354
2010-09-14 11:57 adrianromero Relationship added related to 0014531
2010-09-14 12:03 adrianromero Relationship replaced has duplicate 0014531
2010-09-16 11:31 adrianromero Relationship replaced related to 0014531

Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker