Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0013325Openbravo ERPA. Platformpublic2010-05-14 11:272010-08-19 14:33
Reporternetworkb 
Assigned Toharikrishnan 
PriorityurgentSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version2.50MP14 
Target Version2.50MP18Fixed in Version2.50MP21 
Merge Request Status
Review Assigned To
OBNetwork customer
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0013325: The application does not work properly depending Format's and PostgreSQL's configuration
DescriptionPostgreSQL's configuration in English.

1.- In the postgresql.conf:

>> lc_messages = 'es_ES.UTF-8' # locale for system error message
>> # strings
>> lc_monetary = 'es_ES.UTF-8' # locale for monetary formatting
>> lc_numeric = 'es_ES.UTF-8' # locale for number formatting
>> lc_time = 'es_ES.UTF-8' # locale for time formatting
>>
>> default_text_search_config = 'pg_catalog.spanish'

2.- Format attached. (Decimal separation ',', Millar separation '.')

With this configuration, PostgreSQL understands the ',' as separation of millar so it eliminates the coma. IE:

with spanish configuration:
select to_number('5,0000') from dual ---> 5.00

with english configuration:
select to_number('5,0000') from dual ---> 50000
Steps To Reproduce- With these configurations and as Openbravo Admin go to Sales Management || Transactions || Sales Invoice
- Create a new record, and go to Lines.
- Select Hammer
- Realize that the Net Unit Price is wrong.
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
related to defect 00133202.50MP18 closed adrianromero Different behaviour when changing decimal separator 
has duplicate defect 0014354 closed adrianromero If ',' character is the decimal separator, then invoice line do not populate amounts and tax values when selecting a product 
related to defect 0014531 closed mohankumar Using Comma as decimal separator causes malfunctions on Sales Invoice Lines 
Attached Filesxml Format12.xml (3,239) 2010-05-14 11:27
https://issues.openbravo.com/file_download.php?file_id=2558&type=bug
Issue History
Date ModifiedUsernameFieldChange
2010-05-14 11:27networkbNew Issue
2010-05-14 11:27networkbAssigned To => alostale
2010-05-14 11:27networkbFile Added: Format12.xml
2010-05-14 12:21alostaleStatusnew => scheduled
2010-05-14 12:21alostaleAssigned Toalostale => iperdomo
2010-05-14 12:21alostalefix_in_branch => pi
2010-05-14 12:32networkbNote Added: 0027239
2010-05-14 12:41iperdomoAssigned Toiperdomo => dalsasua
2010-05-14 12:42iperdomoNote Added: 0027242
2010-05-14 12:42iperdomoNote Edited: 0027242bug_revision_view_page.php?bugnote_id=0027242#r364
2010-05-18 19:11networkbTarget Version2.50MP17 => 2.50MP18
2010-05-18 19:11networkbfix_in_branchpi =>
2010-05-26 12:39vmromanosRelationship addedrelated to 0013320
2010-05-26 12:54vmromanosAssigned Todalsasua => vmromanos
2010-05-26 12:54vmromanosNote Added: 0027744
2010-05-26 13:01hgbotCheckin
2010-05-26 13:01hgbotNote Added: 0027746
2010-05-26 13:01hgbotStatusscheduled => resolved
2010-05-26 13:01hgbotResolutionopen => fixed
2010-05-26 13:01hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/693e335d4298ea77e3431cff91d3625f2ae5349b [^]
2010-06-03 22:49hudsonbotCheckin
2010-06-03 22:49hudsonbotNote Added: 0027931
2010-06-29 12:52rafarodaIssue Monitored: rafaroda
2010-07-13 20:24networkbNote Added: 0029273
2010-07-23 10:48jonalegriaesarteStatusresolved => new
2010-07-23 10:48jonalegriaesarteResolutionfixed => open
2010-07-23 12:05adrianromeroNote Added: 0029523
2010-07-23 12:05adrianromeroStatusnew => closed
2010-07-23 12:05adrianromeroResolutionopen => unable to reproduce
2010-07-24 00:00anonymoussf_bug_id0 => 3033791
2010-07-29 19:30networkbNote Added: 0029684
2010-07-29 19:31networkbNote Added: 0029685
2010-07-29 19:31networkbStatusclosed => new
2010-07-29 19:31networkbResolutionunable to reproduce => open
2010-08-02 16:17harikrishnanAssigned Tovmromanos => harikrishnan
2010-08-02 16:17hgbotCheckin
2010-08-02 16:17hgbotNote Added: 0029749
2010-08-02 16:17hgbotStatusnew => resolved
2010-08-02 16:17hgbotResolutionopen => fixed
2010-08-02 16:17hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/devel/pi/rev/693e335d4298ea77e3431cff91d3625f2ae5349b [^] => http://code.openbravo.com/erp/devel/pi/rev/e6fc833ee3976ebb4efba81accb2f92b9286a0b8 [^]
2010-08-02 16:18harikrishnanNote Added: 0029750
2010-08-05 09:16hudsonbotCheckin
2010-08-05 09:16hudsonbotNote Added: 0029793
2010-08-19 11:14psarobeNote Edited: 0029750bug_revision_view_page.php?bugnote_id=0029750#r695
2010-08-19 14:33psarobeNote Added: 0030157
2010-08-19 14:33psarobeStatusresolved => closed
2010-08-19 14:33psarobeFixed in Version => 2.50MP21
2010-08-30 11:17adrianromeroRelationship addedhas duplicate 0014354
2010-09-14 11:57adrianromeroRelationship addedrelated to 0014531
2010-09-14 12:03adrianromeroRelationship replacedhas duplicate 0014531
2010-09-16 11:31adrianromeroRelationship replacedrelated to 0014531

Notes
(0027239)
networkb   
2010-05-14 12:32   
IE:
This bug affects the method getOffersPriceInvoice on SL_Order_Product_data.xsql
(0027242)
iperdomo   
2010-05-14 12:42   
The issue is related to fix issue 0012366
(0027744)
vmromanos   
2010-05-26 12:54   
0013320 fixed this issue, but it's pending the same scenario for Orders
(0027746)
hgbot   
2010-05-26 13:01   
Repository: erp/devel/pi
Changeset: 693e335d4298ea77e3431cff91d3625f2ae5349b
Author: Víctor Martínez Romanos <victor.martinez <at> openbravo.com>
Date: Wed May 26 12:57:16 2010 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/693e335d4298ea77e3431cff91d3625f2ae5349b [^]

Fixed bug 13325: The application does not work properly depending Format and PostgreSQL configuration

---
M src/org/openbravo/erpCommon/ad_callouts/SL_Order_Amt.java
---
(0027931)
hudsonbot   
2010-06-03 22:49   
A changeset related to this issue has been promoted to main after passing a series of tests and an OBX has been generated:

Changeset: http://code.openbravo.com/erp/devel/main/rev/693e335d4298 [^]
Merge Changeset: http://code.openbravo.com/erp/devel/main/rev/c011484a38d9 [^]
Tests: http://builds.openbravo.com/view/int/ [^]
OBX: http://builds.openbravo.com/erp/core/obx/OpenbravoERP-2.50CI.17407.obx [^]
(0029273)
networkb   
2010-07-13 20:24   
Still falling in MP19, in Invoice Sales Line the price is multiplied by 100. (6,00 => 600)
(0029523)
adrianromero   
2010-07-23 12:05   
I have been testing in the latest version with the attached Format.xml and I cannot reproduce it. I did not modified the postgresql configuration because it does not affect the behavior of Openbravo ERP. I mean, Openbravo ERP never executes sentences like "select to_number('5,0000') from dual" because number values are always passed to SQL as parameters.

Jon also tested it and we was not able to reproduce it too.
(0029684)
networkb   
2010-07-29 19:30   
I tried again in a mp19 virtual appliance for vmware, and still falling in Sales Invoice Line. Maybe the problem is the Product Selector, when uses M_BOM_PriceStd() functions.
(0029685)
networkb   
2010-07-29 19:31   
I tried again in a mp19 virtual appliance for vmware, and still falling in Sales Invoice Line. Maybe the problem is the Product Selector, when uses M_BOM_PriceStd() functions.
(0029749)
hgbot   
2010-08-02 16:17   
Repository: erp/devel/pi
Changeset: e6fc833ee3976ebb4efba81accb2f92b9286a0b8
Author: Harikrishnan Raja <harikrishnan.raja <at> openbravo.com>
Date: Mon Aug 02 19:46:28 2010 +0530
URL: http://code.openbravo.com/erp/devel/pi/rev/e6fc833ee3976ebb4efba81accb2f92b9286a0b8 [^]

Fixes Issue 13325: Method M_GET_OFFERS_PRICE the standard price will be passed with comma separated (Example : 35,00) standard price.Hence the value is not calculated properly.

---
M src/org/openbravo/erpCommon/ad_callouts/SL_Invoice_Product.java
---
(0029750)
harikrishnan   
2010-08-02 16:18   
(edited on: 2010-08-19 11:14)
Steps To Test:

*Copy the Format.xml to the workspace and run compile.development -Dtab="xxx".
*Now go to Sales Invoice line and create a record for any product.Now the Price will be properly calculated.
*Restart tomcat

Root Cause:

*Method M_GET_OFFERS_PRICE the standard price will be passed with comma separated (Example : 35,00) standard price.Hence the value is not calculated properly.

Impact:
*The fix is also tested in Purchase Invoice.
(0029793)
hudsonbot   
2010-08-05 09:16   
A changeset related to this issue has been promoted to main after passing a series of tests and an OBX has been generated:

Changeset: http://code.openbravo.com/erp/devel/main/rev/e6fc833ee397 [^]
Merge Changeset: http://code.openbravo.com/erp/devel/main/rev/02ad8e3730d2 [^]
Tests: http://builds.openbravo.com/view/int/ [^]
OBX: http://builds.openbravo.com/erp/core/obx/OpenbravoERP-2.50CI.18019.obx [^]
(0030157)
psarobe   
2010-08-19 14:33   
Tested working fine