Project:
| View Issue Details[ Jump to Notes ] | [ Issue History ] [ Print ] | |||||||
| ID | ||||||||
| 0013213 | ||||||||
| Type | Category | Severity | Reproducibility | Date Submitted | Last Update | |||
| backport | [Openbravo ERP] 01. General setup | major | always | 2010-05-04 13:37 | 2010-05-14 18:42 | |||
| Reporter | adrianromero | View Status | public | |||||
| Assigned To | alostale | |||||||
| Priority | immediate | Resolution | fixed | Fixed in Version | ||||
| Status | closed | Fix in branch | Fixed in SCM revision | 8d0a7366f817 | ||||
| Projection | none | ETA | none | Target Version | 2.40MP13 | |||
| OS | Linux 32 bit | Database | PostgreSQL | Java version | 1.6.0_12 | |||
| OS Version | Debian 5.0 | Database version | 8.3.8 | Ant version | 1.7.0 | |||
| Product Version | 2.40MP12 | SCM revision | ||||||
| Review Assigned To | ||||||||
| Web browser | ||||||||
| Modules | Core | |||||||
| Regression level | ||||||||
| Regression date | ||||||||
| Regression introduced in release | ||||||||
| Regression introduced by commit | ||||||||
| Triggers an Emergency Pack | No | |||||||
| Summary | 0013213: trl attribute in language XML files is always set to "Y" | |||||||
| Description | The XML structure of the language files is: <row id="101" trl="Y"> <value column="MsgText" original="zero">cero</value> <value column="MsgTip" original=""/> </row> Where the trl attribute indicates whether the string is translated or not. In previous versions of Openbravo 2.40, this attribute was properly set to the right value, however right now it's always set as "Y". This bug does not allow the translator to properly identify which strings are remaining to be translated and it makes almost impossible to manage translations from a localizer point of view. Note: I have just checked it in Openbravo 2.40 | |||||||
| Steps To Reproduce | 1- First of all you will need to apply the patch available in 0010914 to fix an issue that is blocking this one 2- Import the Spanish language (available at https://dev.openbravo.com/websvn/localization/translations/es_ES/branches/2.40/ [^]) using the normal procedure described at http://wiki.openbravo.com/wiki/Translating_Openbravo [^] 3- Export the language. 4- Run a diff in each of the XML files between the old version and the exported one and you will see that there are lots of trl changed to "Y". Example for the AD_MESSAGE table: < <row id="1000200002" trl="Y"> --- > <row id="1000200002" trl="N"> 21919c21919 < <row id="1000200003" trl="Y"> --- > <row id="1000200003" trl="N"> 5- If you open the new version of the file, and you find one of these rows, you will realize that they're not translated into Spanish and they have the trl="Y". Example: <row id="1000200002" trl="Y"> <value column="MsgText" original="Order line">Order line</value> <value column="MsgTip" original=""/> </row> | |||||||
| Proposed Solution | The trl attribute must work as before | |||||||
| Tags | No tags attached. | |||||||
| Attached Files | ||||||||
 Relationships [ Relation Graph ]
[ Dependency Graph ]
|
||||||||
|
||||||||
 Relationships |
|
Notes |
|
|
(0026927) adrianromero (manager) 2010-05-04 16:58 |
Set to inmediate because it blocks an obnetwork issue near to expire |
|
(0026950) alostale (manager) 2010-05-05 08:56 |
Fixed together with 0010916 |
|
(0027124) vmromanos (manager) 2010-05-11 09:43 |
After applying the fix, there are still some rows in the AD_ELEMENT file that are marked as 'Y' without being translated: diff -r ./AD_ELEMENT_TRL_es_ES.xml /home/openbravo/SVN/es_ES/branches/2.40/AD_ELEMENT_TRL_es_ES.xml 2c2 < <compiereTrl language="es_ES" table="AD_ELEMENT" version="2.40MP12.6"> --- > <compiereTrl language="es_ES" table="AD_ELEMENT" version="2.40"> 16553c16553 < <row id="1000400000" trl="Y"> --- > <row id="1000400000" trl="N"> 16613c16613 < <row id="1000600005" trl="Y"> --- > <row id="1000600005" trl="N"> 16623c16623 < <row id="1000600006" trl="Y"> --- > <row id="1000600006" trl="N"> 16633c16633 < <row id="1001100000" trl="Y"> --- > <row id="1001100000" trl="N"> 17583c17583 < <row id="1005500012" trl="Y"> --- > <row id="1005500012" trl="N"> 17593c17593 < <row id="1005500013" trl="Y"> --- > <row id="1005500013" trl="N"> 17624c17624 < <row id="1007400000" trl="Y"> --- > <row id="1007400000" trl="N"> 17634c17634 < <row id="1007400001" trl="Y"> --- > <row id="1007400001" trl="N"> The rest of the rows/files are OK |
|
(0027126) alostale (manager) 2010-05-11 10:00 |
Which is the data you have in DB for AD_Element.IsTranslated column? This is the value that should be exported to xml files. |
|
(0027127) vmromanos (manager) 2010-05-11 10:34 |
The value is Y, however the file I used for importing the language has these elements marked as N. |
|
(0027189) hgbot (developer) 2010-05-13 11:30 |
Repository: erp/stable/2.40 Changeset: 8d0a7366f817cb21264ad4eb732fd612ad5b6437 Author: Asier Lostalé <asier.lostale <at> openbravo.com> Date: Thu May 13 11:29:11 2010 +0200 URL: http://code.openbravo.com/erp/stable/2.40/rev/8d0a7366f817cb21264ad4eb732fd612ad5b6437 [^] fixed bug 13213: trl attribute in language XML files is always set to Y --- M src/org/openbravo/erpCommon/ad_forms/TranslationHandler.java --- |
|
(0027319) marvintm (developer) 2010-05-14 18:42 |
Verified that without the fix every row was set to trl="Y", and after the fix the rows without translations are set to trl="N". |
|
Notes |
|
Issue History |
|||
| Date Modified | Username | Field | Change |
| 2010-05-04 13:37 | adrianromero | New Issue | |
| 2010-05-04 13:37 | adrianromero | Assigned To | => adrianromero |
| 2010-05-04 13:37 | adrianromero | Issue generated from | 0012944 |
| 2010-05-04 13:37 | adrianromero | Relationship added | blocks 0012944 |
| 2010-05-04 13:37 | adrianromero | Status | new => scheduled |
| 2010-05-04 13:37 | adrianromero | Type | feature request => backport |
| 2010-05-04 16:58 | adrianromero | Note Added: 0026927 | |
| 2010-05-04 16:58 | adrianromero | Assigned To | adrianromero => alostale |
| 2010-05-04 16:58 | adrianromero | Priority | normal => immediate |
| 2010-05-05 08:56 | alostale | Note Added: 0026950 | |
| 2010-05-05 08:56 | alostale | Status | scheduled => resolved |
| 2010-05-05 08:56 | alostale | Fixed in SCM revision | => https://code.openbravo.com/erp/stable/2.40/rev/f86096d2ecdb1e6846641796a5030d4f4185bcad [^] |
| 2010-05-05 08:56 | alostale | Resolution | open => fixed |
| 2010-05-11 09:43 | vmromanos | Note Added: 0027124 | |
| 2010-05-11 09:43 | vmromanos | Status | resolved => new |
| 2010-05-11 09:43 | vmromanos | Resolution | fixed => open |
| 2010-05-11 10:00 | alostale | Note Added: 0027126 | |
| 2010-05-11 10:00 | alostale | Status | new => feedback |
| 2010-05-11 10:03 | alostale | Assigned To | alostale => vmromanos |
| 2010-05-11 10:33 | vmromanos | Assigned To | vmromanos => alostale |
| 2010-05-11 10:34 | vmromanos | Note Added: 0027127 | |
| 2010-05-11 12:22 | vmromanos | Status | feedback => new |
| 2010-05-13 11:30 | hgbot | Checkin | |
| 2010-05-13 11:30 | hgbot | Note Added: 0027189 | |
| 2010-05-13 11:30 | hgbot | Status | new => resolved |
| 2010-05-13 11:30 | hgbot | Resolution | open => fixed |
| 2010-05-13 11:30 | hgbot | Fixed in SCM revision | https://code.openbravo.com/erp/stable/2.40/rev/f86096d2ecdb1e6846641796a5030d4f4185bcad [^] => http://code.openbravo.com/erp/stable/2.40/rev/8d0a7366f817cb21264ad4eb732fd612ad5b6437 [^] |
| 2010-05-14 18:42 | marvintm | Note Added: 0027319 | |
| 2010-05-14 18:42 | marvintm | Status | resolved => closed |
|
Issue History |
| Copyright © 2000 - 2009 MantisBT Group |
 |