Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
0013213Openbravo ERP01. General setuppublic2010-05-04 13:372010-05-14 18:42
adrianromero 
alostale 
immediatemajoralways
closedfixed 
20Debian 5.0
2.40MP12 
2.40MP13 
No
Core
No
0013213: trl attribute in language XML files is always set to "Y"
The XML structure of the language files is:

<row id="101" trl="Y">
    <value column="MsgText" original="zero">cero</value>
    <value column="MsgTip" original=""/>
</row>

Where the trl attribute indicates whether the string is translated or not.

In previous versions of Openbravo 2.40, this attribute was properly set to the right value, however right now it's always set as "Y".

This bug does not allow the translator to properly identify which strings are remaining to be translated and it makes almost impossible to manage translations from a localizer point of view.

Note: I have just checked it in Openbravo 2.40
1- First of all you will need to apply the patch available in 0010914 to fix an issue that is blocking this one
2- Import the Spanish language (available at https://dev.openbravo.com/websvn/localization/translations/es_ES/branches/2.40/ [^]) using the normal procedure described at http://wiki.openbravo.com/wiki/Translating_Openbravo [^]
3- Export the language.
4- Run a diff in each of the XML files between the old version and the exported one and you will see that there are lots of trl changed to "Y". Example for the AD_MESSAGE table:
< <row id="1000200002" trl="Y">
---
> <row id="1000200002" trl="N">
21919c21919
< <row id="1000200003" trl="Y">
---
> <row id="1000200003" trl="N">
5- If you open the new version of the file, and you find one of these rows, you will realize that they're not translated into Spanish and they have the trl="Y". Example:
  <row id="1000200002" trl="Y">
    <value column="MsgText" original="Order line">Order line</value>
    <value column="MsgTip" original=""/>
  </row>
The trl attribute must work as before
No tags attached.
blocks defect 00129442.40MP13 closed alostale trl attribute in language XML files is always set to "Y" 
Issue History
2010-05-04 13:37adrianromeroNew Issue
2010-05-04 13:37adrianromeroAssigned To => adrianromero
2010-05-04 13:37adrianromeroOBNetwork customer => No
2010-05-04 13:37adrianromeroIssue generated from0012944
2010-05-04 13:37adrianromeroRelationship addedblocks 0012944
2010-05-04 13:37adrianromeroStatusnew => scheduled
2010-05-04 13:37adrianromeroTypefeature request => backport
2010-05-04 16:58adrianromeroNote Added: 0026927
2010-05-04 16:58adrianromeroAssigned Toadrianromero => alostale
2010-05-04 16:58adrianromeroPrioritynormal => immediate
2010-05-05 08:56alostaleNote Added: 0026950
2010-05-05 08:56alostaleStatusscheduled => resolved
2010-05-05 08:56alostaleFixed in SCM revision => https://code.openbravo.com/erp/stable/2.40/rev/f86096d2ecdb1e6846641796a5030d4f4185bcad [^]
2010-05-05 08:56alostaleResolutionopen => fixed
2010-05-11 09:43vmromanosNote Added: 0027124
2010-05-11 09:43vmromanosStatusresolved => new
2010-05-11 09:43vmromanosResolutionfixed => open
2010-05-11 10:00alostaleNote Added: 0027126
2010-05-11 10:00alostaleStatusnew => feedback
2010-05-11 10:03alostaleAssigned Toalostale => vmromanos
2010-05-11 10:33vmromanosAssigned Tovmromanos => alostale
2010-05-11 10:34vmromanosNote Added: 0027127
2010-05-11 12:22vmromanosStatusfeedback => new
2010-05-13 11:30hgbotCheckin
2010-05-13 11:30hgbotNote Added: 0027189
2010-05-13 11:30hgbotStatusnew => resolved
2010-05-13 11:30hgbotResolutionopen => fixed
2010-05-13 11:30hgbotFixed in SCM revisionhttps://code.openbravo.com/erp/stable/2.40/rev/f86096d2ecdb1e6846641796a5030d4f4185bcad [^] => http://code.openbravo.com/erp/stable/2.40/rev/8d0a7366f817cb21264ad4eb732fd612ad5b6437 [^]
2010-05-14 18:42marvintmNote Added: 0027319
2010-05-14 18:42marvintmStatusresolved => closed

Notes
(0026927)
adrianromero   
2010-05-04 16:58   
Set to inmediate because it blocks an obnetwork issue near to expire
(0026950)
alostale   
2010-05-05 08:56   
Fixed together with 0010916
(0027124)
vmromanos   
2010-05-11 09:43   
After applying the fix, there are still some rows in the AD_ELEMENT file that are marked as 'Y' without being translated:

diff -r ./AD_ELEMENT_TRL_es_ES.xml /home/openbravo/SVN/es_ES/branches/2.40/AD_ELEMENT_TRL_es_ES.xml
2c2
< <compiereTrl language="es_ES" table="AD_ELEMENT" version="2.40MP12.6">
---
> <compiereTrl language="es_ES" table="AD_ELEMENT" version="2.40">
16553c16553
< <row id="1000400000" trl="Y">
---
> <row id="1000400000" trl="N">
16613c16613
< <row id="1000600005" trl="Y">
---
> <row id="1000600005" trl="N">
16623c16623
< <row id="1000600006" trl="Y">
---
> <row id="1000600006" trl="N">
16633c16633
< <row id="1001100000" trl="Y">
---
> <row id="1001100000" trl="N">
17583c17583
< <row id="1005500012" trl="Y">
---
> <row id="1005500012" trl="N">
17593c17593
< <row id="1005500013" trl="Y">
---
> <row id="1005500013" trl="N">
17624c17624
< <row id="1007400000" trl="Y">
---
> <row id="1007400000" trl="N">
17634c17634
< <row id="1007400001" trl="Y">
---
> <row id="1007400001" trl="N">

The rest of the rows/files are OK
(0027126)
alostale   
2010-05-11 10:00   
Which is the data you have in DB for AD_Element.IsTranslated column?

This is the value that should be exported to xml files.
(0027127)
vmromanos   
2010-05-11 10:34   
The value is Y, however the file I used for importing the language has these elements marked as N.
(0027189)
hgbot   
2010-05-13 11:30   
Repository: erp/stable/2.40
Changeset: 8d0a7366f817cb21264ad4eb732fd612ad5b6437
Author: Asier Lostalé <asier.lostale <at> openbravo.com>
Date: Thu May 13 11:29:11 2010 +0200
URL: http://code.openbravo.com/erp/stable/2.40/rev/8d0a7366f817cb21264ad4eb732fd612ad5b6437 [^]

fixed bug 13213: trl attribute in language XML files is always set to Y

---
M src/org/openbravo/erpCommon/ad_forms/TranslationHandler.java
---
(0027319)
marvintm   
2010-05-14 18:42   
Verified that without the fix every row was set to trl="Y", and after the fix the rows without translations are set to trl="N".