Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue DetailsJump to Notes ] Issue History ] Print ]
ID
0013134
TypeCategorySeverityReproducibilityDate SubmittedLast Update
feature request[Openbravo ERP] A. Platformminoralways2010-04-27 10:342010-05-18 21:44
ReporterjpabloaeView Statuspublic 
Assigned Tomarvintm 
PriorityurgentResolutionfixedFixed in Version
StatusclosedFix in branchFixed in SCM revisionc5d6492aad01
ProjectionnoneETAnoneTarget Version
OSLinux 32 bitDatabasePostgreSQLJava version1.6.0_18
OS VersionCommunity ApplianceDatabase version8.3.9Ant version1.7.1
Product VersionpiSCM revision03d53536fd30 
Review Assigned To
Web browser
ModulesCore
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0013134: Use a common error code to identify errors

DescriptionSometimes the update.database may throw an error that is minor and should not stop the process for a end user. But we want to catch these errors in our build tests. So we are going to parse the build log looking for errors. It would be really helpful if we used some common error code or text string so that these would be easily catched.
TagsNo tags attached.
Attached Files

- Relationships Relation Graph ] Dependency Graph ]
related to defect 0013030 closedmarvintm update.database does not fail even if an error has happened 

-  Notes
(0026716)
shuehner (administrator)
2010-04-27 11:04

Need to recheck with martinvm but afaik dbsourcemanager already outputs a summary line:

X sql statements executes with (y) errors

If that message is coming up always, then one option would be to change the message output for the y==0 case to read: sucessfully.

Then i might be easier to just grep for 'error'
(0026717)
marvintm (developer)
2010-04-27 11:12

Good idea Stefan. This message is currently shown every time we execute SQL statements using the executeBatch() methods in dbsourcemanager. I need to analyze all the process, but if we are sure that every time there is an error, this message has been shown, then we can just tune that message to fit our requirements.
(0026751)
hgbot (developer)
2010-04-28 11:41

Repository: erp/devel/pi
Changeset: 20b5be2ffe26b079c09b1c1439f44ce298fc5cb7
Author: Antonio Moreno <antonio.moreno <at> openbravo.com>
Date: Wed Apr 28 11:41:05 2010 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/20b5be2ffe26b079c09b1c1439f44ce298fc5cb7 [^]

Fixed issue 13030.
Build will be stopped in several cases in which even if there were errors, it didn't stop.
Fixed issue 13134.
Log will now only output the word error when there is indeed an error in the execution.
Fixed issue 11019
Messages similar to 'Executed 0 statements with 0 errors' will no longer be generated.

---
M src-db/database/lib/dbsourcemanager.jar
---
(0027198)
shuehner (administrator)
2010-05-13 13:53

From reviewing diff:
Change is not working properly for force SQL commands, code is assigning to errorNumber instead errorNumber2 in that case.
(0027223)
hgbot (developer)
2010-05-14 10:41

Repository: erp/devel/dbsm-main
Changeset: 980f1050b8b6a80f33bea1c640da793890a4344c
Author: Antonio Moreno <antonio.moreno <at> openbravo.com>
Date: Thu May 13 17:04:31 2010 +0200
URL: http://code.openbravo.com/erp/devel/dbsm-main/rev/980f1050b8b6a80f33bea1c640da793890a4344c [^]

Fixed issue 13134. The 'succesfully' tag will be added to the log message if there weren't errors for the forced SQL commands also.

---
M src/org/apache/ddlutils/platform/PlatformImplBase.java
---
(0027225)
hgbot (developer)
2010-05-14 10:53

Repository: erp/devel/pi
Changeset: c5d6492aad01501818339726d1b02e27b450f02e
Author: Antonio Moreno <antonio.moreno <at> openbravo.com>
Date: Fri May 14 10:42:50 2010 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/c5d6492aad01501818339726d1b02e27b450f02e [^]

Fixed issue 13134 (the 'succesfully' tag will be added correctly in case of forced commands). Fixed issue 13030 (The process will not be stopped, but a log4j error will be raised).

---
M src-db/database/lib/dbsourcemanager.jar
---
(0027365)
shuehner (administrator)
2010-05-17 13:28

Tested in pi/pg, message changes are working fine (showing sucessfully in case of no errors, and showing old message in case of errors), also '0 statements executed...' are supressed.
(0027451)
hudsonbot (developer)
2010-05-18 21:42

A changeset related to this issue has been promoted to main after passing a series of tests and an OBX has been generated:

Changeset: http://code.openbravo.com/erp/devel/main/rev/20b5be2ffe26 [^]
Merge Changeset: http://code.openbravo.com/erp/devel/main/rev/aa11838d5f80 [^]
Tests: http://builds.openbravo.com/view/devel-int/ [^]
OBX: http://builds.openbravo.com/erp/core/obx/OpenbravoERP-2.50CI.17380.obx [^]
(0027525)
hudsonbot (developer)
2010-05-18 21:44

A changeset related to this issue has been promoted to main after passing a series of tests and an OBX has been generated:

Changeset: http://code.openbravo.com/erp/devel/main/rev/c5d6492aad01 [^]
Merge Changeset: http://code.openbravo.com/erp/devel/main/rev/aa11838d5f80 [^]
Tests: http://builds.openbravo.com/view/devel-int/ [^]
OBX: http://builds.openbravo.com/erp/core/obx/OpenbravoERP-2.50CI.17380.obx [^]

- Issue History
Date Modified Username Field Change
2010-04-27 10:34 jpabloae New Issue
2010-04-27 10:34 jpabloae Assigned To => marvintm
2010-04-27 10:34 jpabloae Relationship added related to 0013030
2010-04-27 11:04 shuehner Note Added: 0026716
2010-04-27 11:04 shuehner Issue Monitored: shuehner
2010-04-27 11:12 marvintm Note Added: 0026717
2010-04-28 11:41 hgbot Checkin
2010-04-28 11:41 hgbot Note Added: 0026751
2010-04-28 11:41 hgbot Status new => resolved
2010-04-28 11:41 hgbot Resolution open => fixed
2010-04-28 11:41 hgbot Fixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/20b5be2ffe26b079c09b1c1439f44ce298fc5cb7 [^]
2010-05-13 13:53 shuehner Note Added: 0027198
2010-05-13 13:53 shuehner Status resolved => new
2010-05-13 13:53 shuehner Resolution fixed => open
2010-05-14 10:41 hgbot Checkin
2010-05-14 10:41 hgbot Note Added: 0027223
2010-05-14 10:41 hgbot Status new => resolved
2010-05-14 10:41 hgbot Resolution open => fixed
2010-05-14 10:41 hgbot Fixed in SCM revision http://code.openbravo.com/erp/devel/pi/rev/20b5be2ffe26b079c09b1c1439f44ce298fc5cb7 [^] => http://code.openbravo.com/erp/devel/dbsm-main/rev/980f1050b8b6a80f33bea1c640da793890a4344c [^]
2010-05-14 10:53 hgbot Checkin
2010-05-14 10:53 hgbot Note Added: 0027225
2010-05-14 10:53 hgbot Fixed in SCM revision http://code.openbravo.com/erp/devel/dbsm-main/rev/980f1050b8b6a80f33bea1c640da793890a4344c [^] => http://code.openbravo.com/erp/devel/pi/rev/c5d6492aad01501818339726d1b02e27b450f02e [^]
2010-05-17 13:28 shuehner Note Added: 0027365
2010-05-17 13:28 shuehner Status resolved => closed
2010-05-18 00:01 anonymous sf_bug_id 0 => 3002960
2010-05-18 21:42 hudsonbot Checkin
2010-05-18 21:42 hudsonbot Note Added: 0027451
2010-05-18 21:44 hudsonbot Checkin
2010-05-18 21:44 hudsonbot Note Added: 0027525


Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker