Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue Details[ Jump to Notes ] [ Issue History ] [ Print ]
ID
0013030
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[Openbravo ERP] A. Platformmajorhave not tried2010-04-19 10:452010-05-20 11:15
ReporterjpabloaeView Statuspublic 
Assigned Tomarvintm 
PriorityimmediateResolutionno change requiredFixed in Version
StatusclosedFix in branchpiFixed in SCM revisionc5d6492aad01
ProjectionnoneETAnoneTarget Version
OSLinux 32 bitDatabasePostgreSQLJava version1.6.0_18
OS VersionProfessional ApplianceDatabase version8.3.9Ant version1.7.1
Product VersionpiSCM revision61774dffb279 
Review Assigned To
Web browser
ModulesCore
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0013030: update.database does not fail even if an error has happened

DescriptionI have updated core from 2.50MP14 to an OBX created from 61774dffb279. The update.database process shows an error but at the END it shows BUILD SUCCESSFUL. The error is attached.
Steps To Reproduce1. Install a clean 2.50MP14.
2. Create an OBX of Core out of the 61774dffb279 revision.
3. Upgrade using the "Install from filesystem" MMC feature.
TagsNo tags attached.
Attached Fileslog file icon update-db.log [^] (3,890 bytes) 2010-04-19 10:45

- Relationships [ Relation Graph ] [ Dependency Graph ]
related to defect 0013191 closedmarvintm Cannot update MP14+SPLP to MP15 candidate 
related to feature request 0013134 closedmarvintm Use a common error code to identify errors 

-  Notes
(0026750)
hgbot (developer)
2010-04-28 11:41

 Repository: erp/devel/pi
Changeset: 20b5be2ffe26b079c09b1c1439f44ce298fc5cb7
Author: Antonio Moreno <antonio.moreno <at> openbravo.com>
Date: Wed Apr 28 11:41:05 2010 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/20b5be2ffe26b079c09b1c1439f44ce298fc5cb7 [^]

Fixed issue 13030.
Build will be stopped in several cases in which even if there were errors, it didn't stop.
Fixed issue 13134.
Log will now only output the word error when there is indeed an error in the execution.
Fixed issue 11019
Messages similar to 'Executed 0 statements with 0 errors' will no longer be generated.

---
M src-db/database/lib/dbsourcemanager.jar
---
(0027203)
shuehner (administrator)
2010-05-13 14:08

 From reading dbsm-main commit history. The changes done to fix this issue have all been reverted to fix the regression tracked in 13191.

Please confirm and reschedule this issue as needed.
(0027224)
hgbot (developer)
2010-05-14 10:41

 Repository: erp/devel/dbsm-main
Changeset: 84b97399a1015055814ce16f8ce895b9b90e9a45
Author: Antonio Moreno <antonio.moreno <at> openbravo.com>
Date: Fri May 14 10:41:40 2010 +0200
URL: http://code.openbravo.com/erp/devel/dbsm-main/rev/84b97399a1015055814ce16f8ce895b9b90e9a45 [^]

Fixed issue 13030. The process will continue, but now an error (a log4j error) will be raised, thus, if the process was launched from the rebuild popup, the rebuild will end in error. The process will not be stopped, because even if an error happened, it's better for the user that the update.database process finishes.

---
M src/org/apache/ddlutils/platform/PlatformImplBase.java
---
(0027226)
hgbot (developer)
2010-05-14 10:53

 Repository: erp/devel/pi
Changeset: c5d6492aad01501818339726d1b02e27b450f02e
Author: Antonio Moreno <antonio.moreno <at> openbravo.com>
Date: Fri May 14 10:42:50 2010 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/c5d6492aad01501818339726d1b02e27b450f02e [^]

Fixed issue 13134 (the 'succesfully' tag will be added correctly in case of forced commands). Fixed issue 13030 (The process will not be stopped, but a log4j error will be raised).

---
M src-db/database/lib/dbsourcemanager.jar
---
(0027372)
hgbot (developer)
2010-05-17 16:35

 Repository: erp/devel/dbsm-main
Changeset: 1d8bea44fef6447839755fb5aeec6fdb7e42e518
Author: Antonio Moreno <antonio.moreno <at> openbravo.com>
Date: Mon May 17 16:34:57 2010 +0200
URL: http://code.openbravo.com/erp/devel/dbsm-main/rev/1d8bea44fef6447839755fb5aeec6fdb7e42e518 [^]

Reverted fix for issue 13030. To avoid any kind of raising false positive errors in the build, we will fix this in a different manner. A separate issue for this has been created with id=13340

---
M src/org/apache/ddlutils/platform/PlatformImplBase.java
---
(0027373)
hgbot (developer)
2010-05-17 16:36

 Repository: erp/devel/pi
Changeset: d0bd5c606ec9695bc2fd42fd119ce1b3df48698b
Author: Antonio Moreno <antonio.moreno <at> openbravo.com>
Date: Mon May 17 16:35:30 2010 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/d0bd5c606ec9695bc2fd42fd119ce1b3df48698b [^]

Reverted fix for issue 13030. To avoid any kind of raising false positive errors in the build, we will fix this in a different manner. A separate issue for this has been created with id=13340

---
M src-db/database/lib/dbsourcemanager.jar
---
(0027374)
marvintm (developer)
2010-05-17 16:36

 It has been decided that update.database will not be stopped even if errors happen in the process, because this would leave the database in a worse state than if we instead choose to continue until it ends.

Two fixes related to this issue have/will be made:

* The log of the update.database process has been improved so that it can be parsed easily, to figure out if there were indeed any kind of errors in the build:
https://issues.openbravo.com/view.php?id=13134 [^]

* The process itself needs to log errors which happened in critical parts of update.database as log4j errors, so that the build indeed fails from the user point of view:

https://issues.openbravo.com/view.php?id=13340 [^]
(0027450)
hudsonbot (developer)
2010-05-18 21:42

 A changeset related to this issue has been promoted to main after passing a series of tests and an OBX has been generated:

Changeset: http://code.openbravo.com/erp/devel/main/rev/20b5be2ffe26 [^]
Merge Changeset: http://code.openbravo.com/erp/devel/main/rev/aa11838d5f80 [^]
Tests: http://builds.openbravo.com/view/devel-int/ [^]
OBX: http://builds.openbravo.com/erp/core/obx/OpenbravoERP-2.50CI.17380.obx [^]
(0027526)
hudsonbot (developer)
2010-05-18 21:44

 A changeset related to this issue has been promoted to main after passing a series of tests and an OBX has been generated:

Changeset: http://code.openbravo.com/erp/devel/main/rev/c5d6492aad01 [^]
Merge Changeset: http://code.openbravo.com/erp/devel/main/rev/aa11838d5f80 [^]
Tests: http://builds.openbravo.com/view/devel-int/ [^]
OBX: http://builds.openbravo.com/erp/core/obx/OpenbravoERP-2.50CI.17380.obx [^]
(0027585)
hudsonbot (developer)
2010-05-20 11:15

 A changeset related to this issue has been promoted to main after passing a series of tests and an OBX has been generated:

Changeset: http://code.openbravo.com/erp/devel/main/rev/d0bd5c606ec9 [^]
Merge Changeset: http://code.openbravo.com/erp/devel/main/rev/a7901e097e1a [^]
Tests: http://builds.openbravo.com/view/devel-int/ [^]
OBX: http://builds.openbravo.com/erp/core/obx/OpenbravoERP-2.50CI.17407.obx [^]

- Issue History
Date Modified Username Field Change
2010-04-19 10:45 jpabloae New Issue
2010-04-19 10:45 jpabloae Assigned To => marvintm
2010-04-19 10:45 jpabloae File Added: update-db.log
2010-04-19 10:45 jpabloae Issue Monitored: iciordia
2010-04-19 22:36 iciordia Priority urgent => immediate
2010-04-26 08:31 alostale Status new => scheduled
2010-04-26 08:31 alostale fix_in_branch => pi
2010-04-27 10:34 jpabloae Relationship added related to 0013134
2010-04-28 11:41 hgbot Checkin
2010-04-28 11:41 hgbot Note Added: 0026750
2010-04-28 11:41 hgbot Status scheduled => resolved
2010-04-28 11:41 hgbot Resolution open => fixed
2010-04-28 11:41 hgbot Fixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/20b5be2ffe26b079c09b1c1439f44ce298fc5cb7 [^]
2010-05-13 14:08 shuehner Note Added: 0027203
2010-05-13 14:08 shuehner Status resolved => new
2010-05-13 14:08 shuehner Resolution fixed => open
2010-05-13 14:08 shuehner Relationship added related to 0013191
2010-05-14 10:41 hgbot Checkin
2010-05-14 10:41 hgbot Note Added: 0027224
2010-05-14 10:41 hgbot Status new => resolved
2010-05-14 10:41 hgbot Resolution open => fixed
2010-05-14 10:41 hgbot Fixed in SCM revision http://code.openbravo.com/erp/devel/pi/rev/20b5be2ffe26b079c09b1c1439f44ce298fc5cb7 [^] => http://code.openbravo.com/erp/devel/dbsm-main/rev/84b97399a1015055814ce16f8ce895b9b90e9a45 [^]
2010-05-14 10:53 hgbot Checkin
2010-05-14 10:53 hgbot Note Added: 0027226
2010-05-14 10:53 hgbot Fixed in SCM revision http://code.openbravo.com/erp/devel/dbsm-main/rev/84b97399a1015055814ce16f8ce895b9b90e9a45 [^] => http://code.openbravo.com/erp/devel/pi/rev/c5d6492aad01501818339726d1b02e27b450f02e [^]
2010-05-17 16:29 marvintm Status resolved => new
2010-05-17 16:29 marvintm Resolution fixed => open
2010-05-17 16:35 hgbot Checkin
2010-05-17 16:35 hgbot Note Added: 0027372
2010-05-17 16:36 hgbot Checkin
2010-05-17 16:36 hgbot Note Added: 0027373
2010-05-17 16:36 marvintm Note Added: 0027374
2010-05-17 16:36 marvintm Status new => closed
2010-05-17 16:36 marvintm Resolution open => no change required
2010-05-18 00:00 anonymous sf_bug_id 0 => 3002956
2010-05-18 21:42 hudsonbot Checkin
2010-05-18 21:42 hudsonbot Note Added: 0027450
2010-05-18 21:44 hudsonbot Checkin
2010-05-18 21:44 hudsonbot Note Added: 0027526
2010-05-20 11:15 hudsonbot Checkin
2010-05-20 11:15 hudsonbot Note Added: 0027585

Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker