Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue Details[ Jump to Notes ] [ Issue History ] [ Print ]
ID
0012599
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[Openbravo ERP] Z. Othersminorhave not tried2010-03-08 18:092012-05-25 12:09
ReportershuehnerView Statuspublic 
Assigned Tonaiaramartinez 
PrioritynormalResolutionfixedFixed in Version3.0MP12
StatusclosedFix in branchpiFixed in SCM revision588bdc741142
ProjectionnoneETAnoneTarget Version
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionpiSCM revision 
Review Assigned To
Web browser
ModulesCore
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0012599: Find and fix all RAISE_APPLICATION_ERROR with first parameter not being -20000

DescriptionAs those don't work correctly on postgres.

All Raise_application_errors which lookup ad_message should look like the following:

RAISE_APPLICATION_ERROR(-20000, '@<ad_message.value>@');

Proposed SolutionThe old ones could be fixed by translating:

RAISE_APPLICATION_ERROR(-20123, 'Fallback text');

into
RAISE_APPLICATION_ERROR(-20000, '@20123@');

Note: this needs testing that it works corrctly on both databases.
TagsNo tags attached.
Attached Files

- Relationships [ Relation Graph ] [ Dependency Graph ]
blocks defect 0008915 closedvmromanos Organization's error message when using Spanish is still in English 
causes defect 0030112 closedNaroaIriarte When trying to save a data package with wrong java package the trigger shows a wrong ad_message 

-  Notes
(0047319)
naiaramartinez (developer)
2012-04-02 16:59

 Test Plan:
   Go to the code in openbravo.
   Find all the calls to RAISE_APPLICATION_ERROR.
   You can see that all of them are fixed: the first parameter is -20000 and the second one is @<ad_message.value>@.
(0048330)
hgbot (developer)
2012-05-03 13:26

 Repository: erp/devel/pi
Changeset: 588bdc7411427aa642d75ec18d0abdb641143a6e
Author: Naiara Martinez <naiara.martinez <at> openbravo.com>
Date: Mon Apr 02 16:48:45 2012 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/588bdc7411427aa642d75ec18d0abdb641143a6e [^]

Fixed bug 12599, Fixed bug 8915 RAISE_APPLICATION_ERROR set first parameter -20000

---
M modules/org.openbravo.advpaymentmngt/src-db/database/model/triggers/APRM_C_BANKSTATEMENT_TRG.xml
M modules/org.openbravo.client.application/src-db/database/model/triggers/OBUIAPP_VIEW_IMPL_TRG.xml
M modules/org.openbravo.service.datasource/src-db/database/model/triggers/OBSERDS_DATASOURCE_FIELD_TRG.xml
M modules/org.openbravo.service.datasource/src-db/database/model/triggers/OBSERDS_DATASOURCE_TRG.xml
M modules/org.openbravo.userinterface.selector/src-db/database/model/triggers/OBUISEL_SELECTOR_FIELD_TRG.xml
M modules/org.openbravo.userinterface.selector/src-db/database/model/triggers/OBUISEL_SELECTOR_TRG.xml
M src-db/database/model/functions/AD_ORG_READY.xml
M src-db/database/model/functions/AD_TAB_IMPORT.xml
M src-db/database/model/functions/C_DP_MANAGEMENT_POST.xml
M src-db/database/model/functions/C_INVOICELINETAX_INSERT.xml
M src-db/database/model/functions/C_INVOICE_POST.xml
M src-db/database/model/functions/C_ORDERLINETAX_INSERT.xml
M src-db/database/model/functions/C_ORDER_POST1.xml
M src-db/database/model/functions/C_REMITTANCE_POST.xml
M src-db/database/model/functions/C_SETTLEMENT_POST.xml
M src-db/database/model/functions/C_TAXPAYMENT_POST.xml
M src-db/database/model/functions/M_PRICELIST_CREATE.xml
M src-db/database/model/triggers/AD_ACCOUNTINGRPT_ELEMENT_TRG.xml
M src-db/database/model/triggers/AD_ALERTRECIPIENT_TRG.xml
M src-db/database/model/triggers/AD_AUXILIARINPUT_MOD_TRG.xml
M src-db/database/model/triggers/AD_AUXILIARINPUT_TRG.xml
M src-db/database/model/triggers/AD_CALLOUT_MOD_TRG.xml
M src-db/database/model/triggers/AD_COLUMN_MOD_TRG.xml
M src-db/database/model/triggers/AD_DATASET_COLUMN_MOD_TRG.xml
M src-db/database/model/triggers/AD_DATASET_MOD_TRG.xml
M src-db/database/model/triggers/AD_DATASET_TABLE_MOD_TRG.xml
M src-db/database/model/triggers/AD_ELEMENT_MOD_TRG.xml
M src-db/database/model/triggers/AD_FIELDGROUP_MOD_TRG.xml
M src-db/database/model/triggers/AD_FIELD_MOD_TRG.xml
M src-db/database/model/triggers/AD_FORM_MOD_TRG.xml
M src-db/database/model/triggers/AD_MENU_MOD_TRG.xml
M src-db/database/model/triggers/AD_MENU_TRG.xml
M src-db/database/model/triggers/AD_MESSAGE_MOD_TRG.xml
M src-db/database/model/triggers/AD_MESSAGE_TRG.xml
M src-db/database/model/triggers/AD_MODULE_DBPREFIX_MOD_TRG.xml
M src-db/database/model/triggers/AD_MODULE_DBPREFIX_TRG.xml
M src-db/database/model/triggers/AD_MODULE_DENPENDENCY_TRG.xml
M src-db/database/model/triggers/AD_MODULE_TRG.xml
M src-db/database/model/triggers/AD_MODULE_VERSION_TRG.xml
M src-db/database/model/triggers/AD_ORGTYPE_TRG.xml
M src-db/database/model/triggers/AD_ORG_ACCTSCHEMA_TRG.xml
M src-db/database/model/triggers/AD_ORG_TRG.xml
M src-db/database/model/triggers/AD_PACKAGE_JP_TRG.xml
M src-db/database/model/triggers/AD_PACKAGE_MOD_TRG.xml
M src-db/database/model/triggers/AD_PROCESS_MOD_TRG.xml
M src-db/database/model/triggers/AD_PROCESS_PARA_MOD_TRG.xml
M src-db/database/model/triggers/AD_REFERENCE_MOD_TRG.xml
M src-db/database/model/triggers/AD_REF_LIST_MOD_TRG.xml
M src-db/database/model/triggers/AD_REF_SEARCH_COLUMN_MOD_TRG.xml
M src-db/database/model/triggers/AD_REF_SEARCH_MOD_TRG.xml
M src-db/database/model/triggers/AD_REF_TABLE_MOD_TRG.xml
M src-db/database/model/triggers/AD_REGISTRATION_INFO_TRG.xml
M src-db/database/model/triggers/AD_SYSTEM_INFO_TRG.xml
M src-db/database/model/triggers/AD_SYSTEM_INFO_TRG2.xml
M src-db/database/model/triggers/AD_TABLE_MOD_TRG.xml
M src-db/database/model/triggers/AD_TABLE_TRG.xml
M src-db/database/model/triggers/AD_TAB_MOD_TRG.xml
M src-db/database/model/triggers/AD_TEXTINTERFACES_MOD_TRG.xml
M src-db/database/model/triggers/AD_TREENODE_MOD_TRG.xml
M src-db/database/model/triggers/AD_TREENODE_TRG.xml
M src-db/database/model/triggers/AD_VAL_RULE_MOD_TRG.xml
M src-db/database/model/triggers/AD_WINDOW_MOD_TRG.xml
M src-db/database/model/triggers/A_AMORTIZATIONLINE_TRG.xml
M src-db/database/model/triggers/A_AMORTIZATION_TRG.xml
M src-db/database/model/triggers/A_ASSET_TRG.xml
M src-db/database/model/triggers/C_BANKACCOUNTIBAN_TRG.xml
M src-db/database/model/triggers/C_BANKCOUNTRY_TRG.xml
M src-db/database/model/triggers/C_BANKSTATEMENTLINE_TRG.xml
M src-db/database/model/triggers/C_BANKSTATEMENT_TRG.xml
M src-db/database/model/triggers/C_BPARTNER_TRG.xml
M src-db/database/model/triggers/C_BP_BANKACCOUNTIBAN_TRG.xml
M src-db/database/model/triggers/C_BP_SALCATEGORY_TRG.xml
M src-db/database/model/triggers/C_BSTMTLINE_CHK_RESTRICT_TRG.xml
M src-db/database/model/triggers/C_BSTMT_CHK_RESTRICTIONS_TRG.xml
M src-db/database/model/triggers/C_BUDGETLINE_TRG.xml
M src-db/database/model/triggers/C_CASHLINE_CHK_RESTRICT_TRG.xml
M src-db/database/model/triggers/C_CASHLINE_TRG.xml
M src-db/database/model/triggers/C_CASH_CHK_RESTRICTIONS_TRG.xml
M src-db/database/model/triggers/C_CONVERSION_RATE_DOCUMENT_TRG.xml
M src-db/database/model/triggers/C_CONVERSION_RATE_TRG.xml
M src-db/database/model/triggers/C_CONVERSION_RATE_TRG2.xml
M src-db/database/model/triggers/C_DEBT_PAYMENT_BAL_TRG.xml
M src-db/database/model/triggers/C_DEBT_PAYMENT_TRG.xml
M src-db/database/model/triggers/C_DPMLINE_CHK_RESTRICTIONS_TRG.xml
M src-db/database/model/triggers/C_DP_MANAGEMENT_CHK_RESTR_TRG.xml
M src-db/database/model/triggers/C_ELEMENTVALUE_TRG.xml
M src-db/database/model/triggers/C_INVLINE_CHK_RESTRICTIONS_TRG.xml
M src-db/database/model/triggers/C_INVOICEDISCOUNT_TRG.xml
M src-db/database/model/triggers/C_INVOICELINE_TRG.xml
M src-db/database/model/triggers/C_INVOICETAX_TRG.xml
M src-db/database/model/triggers/C_INVOICE_TRG.xml
M src-db/database/model/triggers/C_INVTAX_CHK_RESTRICTIONS_TRG.xml
M src-db/database/model/triggers/C_LOCATION_TRG.xml
M src-db/database/model/triggers/C_ORDERDISCOUNT_TRG.xml
M src-db/database/model/triggers/C_ORDERLINE_TRG.xml
M src-db/database/model/triggers/C_ORDERTAX_TRG.xml
M src-db/database/model/triggers/C_ORDER_CHK_RESTRINCTIONS_TRG.xml
M src-db/database/model/triggers/C_ORDER_TRG.xml
M src-db/database/model/triggers/C_ORDLINE_CHK_RESTRICTIONS_TRG.xml
M src-db/database/model/triggers/C_PROJECT_TRG.xml
M src-db/database/model/triggers/C_REMITTANCELINE_TRG.xml
M src-db/database/model/triggers/C_REMITTANCE_TRG.xml
M src-db/database/model/triggers/C_SALESREGION_TRG.xml
M src-db/database/model/triggers/C_SETTLEMENT_TRG.xml
M src-db/database/model/triggers/C_TAXPAYMENT_TRG.xml
M src-db/database/model/triggers/C_TAXREGISTERLINE_TRG.xml
M src-db/database/model/triggers/C_TAXREGISTER_TRG.xml
M src-db/database/model/triggers/C_TAX_REPORT_TRG.xml
M src-db/database/model/triggers/C_VALIDCOMBINATION_TRG.xml
M src-db/database/model/triggers/GL_JL_CHK_RESTRICTIONS_TRG.xml
M src-db/database/model/triggers/GL_JOURNALLINE_TRG.xml
M src-db/database/model/triggers/GL_JOURNAL_CHK_RESTRICT_TRG.xml
M src-db/database/model/triggers/M_INOUTLINE_TRG.xml
M src-db/database/model/triggers/M_INOUT_CHK_RESTRICTIONS_TRG.xml
M src-db/database/model/triggers/M_INTERNAL_CONSUMPTIONLINE_TRG.xml
M src-db/database/model/triggers/M_INVENTORYLINE_TRG.xml
M src-db/database/model/triggers/M_INVENTORY_TRG.xml
M src-db/database/model/triggers/M_IOLINE_CHK_RESTRICTIONS_TRG.xml
M src-db/database/model/triggers/M_MOVEMENTLINE_TRG.xml
M src-db/database/model/triggers/M_MOVEMENT_TRG.xml
M src-db/database/model/triggers/M_PRODUCTIONLINE_TRG.xml
M src-db/database/model/triggers/M_PRODUCTIONPLAN_TRG.xml
M src-db/database/model/triggers/M_PRODUCTION_TRG.xml
M src-db/database/model/triggers/M_PRODUCT_TRG.xml
M src-db/database/model/triggers/M_REQUISITIONLINE_TRG.xml
M src-db/database/model/triggers/M_REQUISITIONORDER_TRG.xml
M src-db/database/model/triggers/M_REQUISITION_TRG.xml
M src-db/database/model/triggers/M_TRANSACTION_TRG.xml
M src-db/database/model/triggers/S_RESOURCEUNAVAILABLE_TRG.xml
M src-db/database/model/triggers/S_TIMEEXPENSELINE_TRG.xml
M src-db/database/model/triggers/S_TIMEEXPENSE_TRG.xml
M src-db/database/sourcedata/AD_MESSAGE.xml
---
(0048795)
mirurita (developer)
2012-05-21 10:24

 code review + testing OK

Testing plan:
- Check all the RAISE_APPLICATION_ERROR are properly defined:
RAISE_APPLICATION_ERROR(-20000, '@<ad_message.value>@');
- Check @<ad_message.value>@ matches with existing message search key in the database.
- Test one scenario affected by the change:
     Modify the version number of any module to: a.b.c
     The error with value (10102) is displayed: "The version has to be formatted like x.y.z where x, y and z are integers." in oracle and postgresql.

QA team is aware about this risky change and they will treat it accordingly.
(0049006)
hudsonbot (developer)
2012-05-25 12:09

 A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/5401e185a8b0 [^]

Maturity status: Test

- Issue History
Date Modified Username Field Change
2010-03-08 18:09 shuehner New Issue
2010-03-08 18:09 shuehner Assigned To => adrianromero
2011-06-03 11:00 dalsasua Assigned To adrianromero => dalsasua
2011-07-20 18:11 dalsasua Assigned To dalsasua => jonalegriaesarte
2012-02-15 19:05 iciordia Assigned To jonalegriaesarte => vmromanos
2012-02-17 09:29 vmromanos Relationship added related to 0008915
2012-02-17 09:30 vmromanos Relationship deleted related to 0008915
2012-02-17 09:30 vmromanos Relationship added blocks 0008915
2012-04-02 16:56 naiaramartinez Assigned To vmromanos => naiaramartinez
2012-04-02 16:56 naiaramartinez Status new => scheduled
2012-04-02 16:56 naiaramartinez fix_in_branch => pi
2012-04-02 16:59 naiaramartinez Note Added: 0047319
2012-05-03 13:26 hgbot Checkin
2012-05-03 13:26 hgbot Note Added: 0048330
2012-05-03 13:26 hgbot Status scheduled => resolved
2012-05-03 13:26 hgbot Resolution open => fixed
2012-05-03 13:26 hgbot Fixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/588bdc7411427aa642d75ec18d0abdb641143a6e [^]
2012-05-21 10:24 mirurita Note Added: 0048795
2012-05-21 10:24 mirurita Status resolved => closed
2012-05-21 10:24 mirurita Fixed in Version => 3.0MP12
2012-05-25 12:09 hudsonbot Checkin
2012-05-25 12:09 hudsonbot Note Added: 0049006
2015-06-05 10:45 airaceburu Relationship added causes 0030112

Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker