Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue DetailsJump to Notes ] Issue History ] Print ]
ID
0011716
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[Openbravo ERP] A. Platformmajoralways2009-12-09 23:532009-12-18 10:10
ReporteriperdomoView Statuspublic 
Assigned Toiperdomo 
PriorityimmediateResolutionfixedFixed in Version
StatusclosedFix in branchpiFixed in SCM revision3b3e2ecea84f
ProjectionnoneETAnoneTarget Version
OSLinux 32 bitDatabasePostgreSQLJava version1.6.0_15
OS Version2.6.30-gentoo-r5Database version8.3.8Ant version1.7.1
Product VersionpiSCM revision 
Merge Request Status
Review Assigned To
OBNetwork customerNo
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0011716: pi module integrity test failed

Description
http://builds.openbravo.com/job/erp_devel_pi-module-integrity-test/230/console [^]
----
org.openbravo.model.ad.module:
Bad
method org.openbravo.model.ad.module.ModuleLog.getModule(): type org.openbravo.model.ad.module.Module in api-checks/java/reference/250, but type java.lang.String in /var/www/localhost/htdocs/japi/230
Missing
field org.openbravo.model.ad.module.Module.PROPERTY_MODULELOGLIST: missing in /var/www/localhost/htdocs/japi/230
method org.openbravo.model.ad.module.Module.getModuleLogList(): missing in /var/www/localhost/htdocs/japi/230
method org.openbravo.model.ad.module.Module.setModuleLogList(java.util.List<org.openbravo.model.ad.module.ModuleLog>): missing in /var/www/localhost/htdocs/japi/230
method org.openbravo.model.ad.module.ModuleLog.setModule(org.openbravo.model.ad.module.Module): missing in /var/www/localhost/htdocs/japi/230
TagsNo tags attached.
Attached Files

- Relationships Relation Graph ] Dependency Graph ]
related to defect 00117052.50MP12 closedmarvintm AD_Module_Log table shouldn't have a reference to AD_Module table 

-  Notes
(0022608)
iperdomo (viewer)
2009-12-10 09:43
edited on: 2009-12-10 09:45

* Type: Changed reference of column

* Description: The AD_Module_Log.AD_Module_ID column had a reference TableDir and was changed to String

* Risk: Low

* Comments: The AD_Module_Log table contains a installation log of modules, it holds all the operations made through the module management console. When this table was created it has a reference TableDir in the AD_Module_ID column, that is fine in other tables but not here. The TableDir reference builds a link to to the 'parent' entity (ADModule in this case). The uninstall operation is also logged in this table, so if you uninstall a module you have record if this operation with a link to non existent module. The integrity of this column is not enforced in database with a foreign key because is a log table, so it makes no sense to enforce the integrity a Data Access Layer level.
Changing the reference to String and removing the 'isParent' flag triggered a change in the generated entity.

(0022620)
pjuvara (viewer)
2009-12-10 11:59

Accepted as an exception. Please go ahead with the change.

A side note: this defect should have stayed in status New until my approval.
(0022626)
hgbot (developer)
2009-12-10 12:29

Repository: erp/devel/api-checks
Changeset: 722892bc041da782f0735147f18a02dae8d0e8b7
Author: Iván Perdomo <ivan.perdomo <at> openbravo.com>
Date: Thu Dec 10 12:29:22 2009 +0100
URL: http://code.openbravo.com/erp/devel/api-checks/rev/722892bc041da782f0735147f18a02dae8d0e8b7 [^]

Fixes issue 11716: Updated reference java reference file

---
M java/reference/250.japi.gz
---
(0022637)
hgbot (developer)
2009-12-10 13:31

Repository: erp/devel/api-checks
Changeset: 3b3e2ecea84fac6f7a813bb3878cc8c168723e70
Author: Iván Perdomo <ivan.perdomo <at> openbravo.com>
Date: Thu Dec 10 13:30:55 2009 +0100
URL: http://code.openbravo.com/erp/devel/api-checks/rev/3b3e2ecea84fac6f7a813bb3878cc8c168723e70 [^]

Fixes issue 11716: Updated java reference file

---
M java/reference/250.japi.gz
---
(0022931)
iperdomo (viewer)
2009-12-18 10:10

The change was reverted in revision [1] because it breaks the upgrade to 2.50MP10.


[1] http://code.openbravo.com/erp/devel/pi/rev/01eeefac3d18a76f5eae05d48937e528edfeff27 [^]

- Issue History
Date Modified Username Field Change
2009-12-09 23:53 iperdomo New Issue
2009-12-09 23:53 iperdomo Assigned To => iperdomo
2009-12-09 23:53 iperdomo OBNetwork customer => No
2009-12-10 09:35 iperdomo Relationship added related to 0011705
2009-12-10 09:43 iperdomo Note Added: 0022608
2009-12-10 09:43 iperdomo Assigned To iperdomo =>
2009-12-10 09:43 iperdomo Status new => scheduled
2009-12-10 09:43 iperdomo Assigned To => pjuvara
2009-12-10 09:43 iperdomo fix_in_branch => pi
2009-12-10 09:45 iperdomo Note Edited: 0022608
2009-12-10 11:59 pjuvara Note Added: 0022620
2009-12-10 12:00 pjuvara Assigned To pjuvara => iperdomo
2009-12-10 12:29 hgbot Checkin
2009-12-10 12:29 hgbot Note Added: 0022626
2009-12-10 12:29 hgbot Status scheduled => resolved
2009-12-10 12:29 hgbot Resolution open => fixed
2009-12-10 12:29 hgbot Fixed in SCM revision => http://code.openbravo.com/erp/devel/api-checks/rev/722892bc041da782f0735147f18a02dae8d0e8b7 [^]
2009-12-10 12:42 shuehner Status resolved => closed
2009-12-10 13:31 hgbot Checkin
2009-12-10 13:31 hgbot Note Added: 0022637
2009-12-10 13:31 hgbot Status closed => resolved
2009-12-10 13:31 hgbot Fixed in SCM revision http://code.openbravo.com/erp/devel/api-checks/rev/722892bc041da782f0735147f18a02dae8d0e8b7 [^] => http://code.openbravo.com/erp/devel/api-checks/rev/3b3e2ecea84fac6f7a813bb3878cc8c168723e70 [^]
2009-12-10 13:51 iperdomo Status resolved => closed
2009-12-11 00:00 anonymous sf_bug_id 0 => 2912329
2009-12-18 10:10 iperdomo Note Added: 0022931


Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker