Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0011716Openbravo ERPA. Platformpublic2009-12-09 23:532009-12-18 10:10
Reporteriperdomo 
Assigned Toiperdomo 
PriorityimmediateSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS20OS Version2.6.30-gentoo-r5
Product Versionpi 
Target VersionFixed in Version 
Merge Request Status
Review Assigned To
OBNetwork customerNo
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0011716: pi module integrity test failed
Description
http://builds.openbravo.com/job/erp_devel_pi-module-integrity-test/230/console [^]
----
org.openbravo.model.ad.module:
Bad
method org.openbravo.model.ad.module.ModuleLog.getModule(): type org.openbravo.model.ad.module.Module in api-checks/java/reference/250, but type java.lang.String in /var/www/localhost/htdocs/japi/230
Missing
field org.openbravo.model.ad.module.Module.PROPERTY_MODULELOGLIST: missing in /var/www/localhost/htdocs/japi/230
method org.openbravo.model.ad.module.Module.getModuleLogList(): missing in /var/www/localhost/htdocs/japi/230
method org.openbravo.model.ad.module.Module.setModuleLogList(java.util.List<org.openbravo.model.ad.module.ModuleLog>): missing in /var/www/localhost/htdocs/japi/230
method org.openbravo.model.ad.module.ModuleLog.setModule(org.openbravo.model.ad.module.Module): missing in /var/www/localhost/htdocs/japi/230
Steps To Reproduce
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
related to defect 00117052.50MP12 closed marvintm AD_Module_Log table shouldn't have a reference to AD_Module table 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2009-12-09 23:53iperdomoNew Issue
2009-12-09 23:53iperdomoAssigned To => iperdomo
2009-12-09 23:53iperdomoOBNetwork customer => No
2009-12-10 09:35iperdomoRelationship addedrelated to 0011705
2009-12-10 09:43iperdomoNote Added: 0022608
2009-12-10 09:43iperdomoAssigned Toiperdomo =>
2009-12-10 09:43iperdomoStatusnew => scheduled
2009-12-10 09:43iperdomoAssigned To => pjuvara
2009-12-10 09:43iperdomofix_in_branch => pi
2009-12-10 09:45iperdomoNote Edited: 0022608
2009-12-10 11:59pjuvaraNote Added: 0022620
2009-12-10 12:00pjuvaraAssigned Topjuvara => iperdomo
2009-12-10 12:29hgbotCheckin
2009-12-10 12:29hgbotNote Added: 0022626
2009-12-10 12:29hgbotStatusscheduled => resolved
2009-12-10 12:29hgbotResolutionopen => fixed
2009-12-10 12:29hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/api-checks/rev/722892bc041da782f0735147f18a02dae8d0e8b7 [^]
2009-12-10 12:42shuehnerStatusresolved => closed
2009-12-10 13:31hgbotCheckin
2009-12-10 13:31hgbotNote Added: 0022637
2009-12-10 13:31hgbotStatusclosed => resolved
2009-12-10 13:31hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/devel/api-checks/rev/722892bc041da782f0735147f18a02dae8d0e8b7 [^] => http://code.openbravo.com/erp/devel/api-checks/rev/3b3e2ecea84fac6f7a813bb3878cc8c168723e70 [^]
2009-12-10 13:51iperdomoStatusresolved => closed
2009-12-11 00:00anonymoussf_bug_id0 => 2912329
2009-12-18 10:10iperdomoNote Added: 0022931

Notes
(0022608)
iperdomo   
2009-12-10 09:43   
(edited on: 2009-12-10 09:45)
* Type: Changed reference of column

* Description: The AD_Module_Log.AD_Module_ID column had a reference TableDir and was changed to String

* Risk: Low

* Comments: The AD_Module_Log table contains a installation log of modules, it holds all the operations made through the module management console. When this table was created it has a reference TableDir in the AD_Module_ID column, that is fine in other tables but not here. The TableDir reference builds a link to to the 'parent' entity (ADModule in this case). The uninstall operation is also logged in this table, so if you uninstall a module you have record if this operation with a link to non existent module. The integrity of this column is not enforced in database with a foreign key because is a log table, so it makes no sense to enforce the integrity a Data Access Layer level.
Changing the reference to String and removing the 'isParent' flag triggered a change in the generated entity.
(0022620)
pjuvara   
2009-12-10 11:59   
Accepted as an exception. Please go ahead with the change.

A side note: this defect should have stayed in status New until my approval.
(0022626)
hgbot   
2009-12-10 12:29   
Repository: erp/devel/api-checks
Changeset: 722892bc041da782f0735147f18a02dae8d0e8b7
Author: Iván Perdomo <ivan.perdomo <at> openbravo.com>
Date: Thu Dec 10 12:29:22 2009 +0100
URL: http://code.openbravo.com/erp/devel/api-checks/rev/722892bc041da782f0735147f18a02dae8d0e8b7 [^]

Fixes issue 11716: Updated reference java reference file

---
M java/reference/250.japi.gz
---
(0022637)
hgbot   
2009-12-10 13:31   
Repository: erp/devel/api-checks
Changeset: 3b3e2ecea84fac6f7a813bb3878cc8c168723e70
Author: Iván Perdomo <ivan.perdomo <at> openbravo.com>
Date: Thu Dec 10 13:30:55 2009 +0100
URL: http://code.openbravo.com/erp/devel/api-checks/rev/3b3e2ecea84fac6f7a813bb3878cc8c168723e70 [^]

Fixes issue 11716: Updated java reference file

---
M java/reference/250.japi.gz
---
(0022931)
iperdomo   
2009-12-18 10:10   
The change was reverted in revision [1] because it breaks the upgrade to 2.50MP10.


[1] http://code.openbravo.com/erp/devel/pi/rev/01eeefac3d18a76f5eae05d48937e528edfeff27 [^]