Project:
| View Issue Details[ Jump to Notes ] | [ Issue History ] [ Print ] | |||||||
| ID | ||||||||
| 0011612 | ||||||||
| Type | Category | Severity | Reproducibility | Date Submitted | Last Update | |||
| defect | [Openbravo ERP] 09. Financial management | minor | have not tried | 2009-12-02 14:37 | 2009-12-11 00:00 | |||
| Reporter | shuehner | View Status | public | |||||
| Assigned To | shuehner | |||||||
| Priority | normal | Resolution | fixed | Fixed in Version | ||||
| Status | closed | Fix in branch | Fixed in SCM revision | e774060cb37f | ||||
| Projection | none | ETA | none | Target Version | ||||
| OS | Any | Database | Any | Java version | ||||
| OS Version | Database version | Ant version | ||||||
| Product Version | pi | SCM revision | ||||||
| Merge Request Status | ||||||||
| Review Assigned To | ||||||||
| OBNetwork customer | No | |||||||
| Web browser | ||||||||
| Modules | Core | |||||||
| Support ticket | ||||||||
| Regression level | ||||||||
| Regression date | ||||||||
| Regression introduced in release | ||||||||
| Regression introduced by commit | ||||||||
| Triggers an Emergency Pack | No | |||||||
| Summary | 0011612: Some code-cleanup and simpler/safer HQL to the new payment monitor | |||||||
| Description | some one cleanup should be done to make the code simpler more readable and some hql queries should be written to properly escape user parameters. | |||||||
| Tags | No tags attached. | |||||||
| Attached Files | ||||||||
 Relationships [ Relation Graph ]
[ Dependency Graph ]
|
||||||||
|
||||||||
 Relationships |
|
Notes |
|
|
(0022365) hgbot (developer) 2009-12-02 14:40 |
Repository: erp/devel/pi Changeset: e774060cb37fac4c1bf2a56ca6fc221c05ae108f Author: Stefan Hühner <stefan.huehner <at> openbravo.com> Date: Wed Dec 02 14:40:07 2009 +0100 URL: http://code.openbravo.com/erp/devel/pi/rev/e774060cb37fac4c1bf2a56ca6fc221c05ae108f [^] Fixed 11612: Code-cleanup for PaymentMonitor - no isDebugEnabled needed in non-critical code-path - use OBDal.get for reading record by pl - printStackTrace -> log4j.error(String, Throwable) - no new String("string-constant") - StringBuilder -> String where possible - use HQL namedParameters for user input --- M src/org/openbravo/erpCommon/ad_actionButton/InvoicePaymentMonitor.java M src/org/openbravo/erpCommon/ad_process/PaymentMonitor.java M src/org/openbravo/erpCommon/ad_process/PaymentMonitorProcess.java --- |
|
(0022445) hudsonbot (viewer) 2009-12-04 09:15 |
--- A changeset related to this issue has passed a series of tests and has been promoted to main: Changeset: http://code.openbravo.com/erp/devel/main/rev/f6bc559b1872 [^] Tests: http://builds.openbravo.com/view/devel-int/ [^] --- |
|
Notes |
|
Issue History |
|||
| Date Modified | Username | Field | Change |
| 2009-12-02 14:37 | shuehner | New Issue | |
| 2009-12-02 14:37 | shuehner | Assigned To | => shuehner |
| 2009-12-02 14:37 | shuehner | OBNetwork customer | => No |
| 2009-12-02 14:37 | shuehner | Relationship added | related to 0011611 |
| 2009-12-02 14:40 | hgbot | Checkin | |
| 2009-12-02 14:40 | hgbot | Note Added: 0022365 | |
| 2009-12-02 14:40 | hgbot | Status | new => resolved |
| 2009-12-02 14:40 | hgbot | Resolution | open => fixed |
| 2009-12-02 14:40 | hgbot | Fixed in SCM revision | => http://code.openbravo.com/erp/devel/pi/rev/e774060cb37fac4c1bf2a56ca6fc221c05ae108f [^] |
| 2009-12-04 09:15 | hudsonbot | Checkin | |
| 2009-12-04 09:15 | hudsonbot | Note Added: 0022445 | |
| 2009-12-10 17:51 | marvintm | Status | resolved => closed |
| 2009-12-11 00:00 | anonymous | sf_bug_id | 0 => 2912323 |
|
Issue History |
| Copyright © 2000 - 2009 MantisBT Group |
 |