Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0011612Openbravo ERP09. Financial managementpublic2009-12-02 14:372009-12-11 00:00
Reportershuehner 
Assigned Toshuehner 
PrioritynormalSeverityminorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Versionpi 
Target VersionFixed in Version 
Merge Request Status
Review Assigned To
OBNetwork customerNo
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0011612: Some code-cleanup and simpler/safer HQL to the new payment monitor
Descriptionsome one cleanup should be done to make the code simpler more readable and some hql queries should be written to properly escape user parameters.
Steps To Reproduce
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
related to defect 0011611 closed shuehner Add convenience method to OBQuery to more easily set a single named parameter 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2009-12-02 14:37shuehnerNew Issue
2009-12-02 14:37shuehnerAssigned To => shuehner
2009-12-02 14:37shuehnerOBNetwork customer => No
2009-12-02 14:37shuehnerRelationship addedrelated to 0011611
2009-12-02 14:40hgbotCheckin
2009-12-02 14:40hgbotNote Added: 0022365
2009-12-02 14:40hgbotStatusnew => resolved
2009-12-02 14:40hgbotResolutionopen => fixed
2009-12-02 14:40hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/e774060cb37fac4c1bf2a56ca6fc221c05ae108f [^]
2009-12-04 09:15hudsonbotCheckin
2009-12-04 09:15hudsonbotNote Added: 0022445
2009-12-10 17:51marvintmStatusresolved => closed
2009-12-11 00:00anonymoussf_bug_id0 => 2912323

Notes
(0022365)
hgbot   
2009-12-02 14:40   
Repository: erp/devel/pi
Changeset: e774060cb37fac4c1bf2a56ca6fc221c05ae108f
Author: Stefan Hühner <stefan.huehner <at> openbravo.com>
Date: Wed Dec 02 14:40:07 2009 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/e774060cb37fac4c1bf2a56ca6fc221c05ae108f [^]

Fixed 11612: Code-cleanup for PaymentMonitor
- no isDebugEnabled needed in non-critical code-path
- use OBDal.get for reading record by pl
- printStackTrace -> log4j.error(String, Throwable)
- no new String("string-constant")
- StringBuilder -> String where possible
- use HQL namedParameters for user input

---
M src/org/openbravo/erpCommon/ad_actionButton/InvoicePaymentMonitor.java
M src/org/openbravo/erpCommon/ad_process/PaymentMonitor.java
M src/org/openbravo/erpCommon/ad_process/PaymentMonitorProcess.java
---
(0022445)
hudsonbot   
2009-12-04 09:15   
---
A changeset related to this issue has passed a series of tests and has been promoted to main:

Changeset: http://code.openbravo.com/erp/devel/main/rev/f6bc559b1872 [^]
Tests: http://builds.openbravo.com/view/devel-int/ [^]
---