Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue DetailsJump to Notes ] Issue History ] Print ]
ID
0011143
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[Openbravo ERP] Z. Othersmajorhave not tried2009-10-26 19:422009-11-19 00:00
ReportershuehnerView Statuspublic 
Assigned Toshuehner 
PriorityurgentResolutionfixedFixed in Version
StatusclosedFix in branchFixed in SCM revision9e660d4a5c4a
ProjectionnoneETAnoneTarget Version
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionpiSCM revision 
Review Assigned To
Web browser
ModulesCore
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0011143: Some columns are defined as reference type NUMBER but should be INTEGER

DescriptionSome columns are defined as a reference type of number but from a logical perspective only contain integral numbers.

The list of columns of type NUMBER should be checked and the reference should be switched to INTEGER were needed.
TagsNo tags attached.
Attached Files

- Relationships Relation Graph ] Dependency Graph ]
related to defect 0011134 closedmarvintm API check build 184 fails 

-  Notes
(0021383)
shuehner (administrator)
2009-10-26 19:44

Note changing this reference changes the public API as the DAL type mapping for NUMBER is now BigDecimal.class (>MP8) and was float (<=MP8) and the type mapping for INTEGER is Long.class

However as the API change for NUMERIC references from Float -> BigDecimal will be done and acknowledged this change here can ride along the 11134 API change, as it does not increase its size but exactly affects a subset of the fields which change its type.
(0021386)
shuehner (administrator)
2009-10-26 19:49

List of fields where the reference will be change from NUMBER -> INTEGER:

- ModelImplementationParameter.LineNo
  this fields describe the order of several parameters attached to one ad_model_object record.

- ModuleInstall.SequenceNo (ad_module_install.seqno)
  the table ad_module_install is a copy of the ad_module table. Change seqno from ad_module_install to the reference of ad_module.seqno

- System.{TADRecordrange,TADRecordrangeinfo,TADTransactionalrange}
  These values describe number of records shown and number of days in a range to be shown

- Country.IbanLength
  Number of digits in a number for validation

- Tax.LineNo (I_TAX.LineNo)
  Line No

- {AccptRptGroup,AcctRptNode}.LineNo
  Line No

- PriceAdjustment.Priority
  value to select preference of several price adjustments. -> integral
(0021388)
hgbot (developer)
2009-10-26 20:02

Repository: erp/devel/pi
Changeset: d452c4faba682b89ed134a01cd2dd09e7d554e6e
Author: Stefan Hühner <stefan.huehner <at> openbravo.com>
Date: Mon Oct 26 20:02:02 2009 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/d452c4faba682b89ed134a01cd2dd09e7d554e6e [^]

Fixed 11143: Change reference of some column from number -> integer...
where the value in the column is always integral (i.e. number of records).

---
M src-db/database/sourcedata/AD_COLUMN.xml
---
(0021393)
hgbot (developer)
2009-10-26 20:57

Repository: erp/devel/pi
Changeset: 6d0085326e92f89b8f5dac8e8ee3cf820c151378
Author: Stefan Huehner <stefan.huehner <at> openbravo.com>
Date: Mon Oct 26 20:56:50 2009 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/6d0085326e92f89b8f5dac8e8ee3cf820c151378 [^]

Issue 11143: Backout changeset: 5326:d452c4faba68 as...
its need updated Masterdata..

---
M src-db/database/sourcedata/AD_COLUMN.xml
---
(0021406)
shuehner (administrator)
2009-10-27 10:31

Reopened as commit was reverted.
(0021445)
hgbot (developer)
2009-10-28 14:26

Repository: erp/devel/pi
Changeset: 9e660d4a5c4a463159660e3379d854822ba99401
Author: Stefan Hühner <stefan.huehner <at> openbravo.com>
Date: Wed Oct 28 14:25:41 2009 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/9e660d4a5c4a463159660e3379d854822ba99401 [^]

Fixed 11143: Change some column references from Number -> Integer ...
as they only contain integral values.
Update Masterdata & Sampledata as the serialized numberforamt is slightly
different (28 now instead of 28.0)

---
M referencedata/sampledata/Accounting_Test.xml
M referencedata/sampledata/SmallBazaar.xml
M referencedata/standard/Masterdata.xml
M src-db/database/sourcedata/AD_COLUMN.xml
---
(0021974)
marvintm (developer)
2009-11-18 16:13

All the changed columns were revised to check that the changes were correct. Both install.source and update.database work with the changed .xml files.

- Issue History
Date Modified Username Field Change
2009-10-26 19:42 shuehner New Issue
2009-10-26 19:42 shuehner Assigned To => shuehner
2009-10-26 19:42 shuehner Relationship added related to 0011134
2009-10-26 19:44 shuehner Note Added: 0021383
2009-10-26 19:49 shuehner Note Added: 0021386
2009-10-26 20:02 hgbot Checkin
2009-10-26 20:02 hgbot Note Added: 0021388
2009-10-26 20:02 hgbot Status new => resolved
2009-10-26 20:02 hgbot Resolution open => fixed
2009-10-26 20:02 hgbot Fixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/d452c4faba682b89ed134a01cd2dd09e7d554e6e [^]
2009-10-26 20:57 hgbot Checkin
2009-10-26 20:57 hgbot Note Added: 0021393
2009-10-26 20:57 hgbot Fixed in SCM revision http://code.openbravo.com/erp/devel/pi/rev/d452c4faba682b89ed134a01cd2dd09e7d554e6e [^] => http://code.openbravo.com/erp/devel/pi/rev/6d0085326e92f89b8f5dac8e8ee3cf820c151378 [^]
2009-10-27 10:31 shuehner Status resolved => new
2009-10-27 10:31 shuehner Resolution fixed => open
2009-10-27 10:31 shuehner Note Added: 0021406
2009-10-28 14:26 hgbot Checkin
2009-10-28 14:26 hgbot Note Added: 0021445
2009-10-28 14:26 hgbot Status new => resolved
2009-10-28 14:26 hgbot Resolution open => fixed
2009-10-28 14:26 hgbot Fixed in SCM revision http://code.openbravo.com/erp/devel/pi/rev/6d0085326e92f89b8f5dac8e8ee3cf820c151378 [^] => http://code.openbravo.com/erp/devel/pi/rev/9e660d4a5c4a463159660e3379d854822ba99401 [^]
2009-11-18 16:13 marvintm Note Added: 0021974
2009-11-18 16:13 marvintm Status resolved => closed
2009-11-19 00:00 anonymous sf_bug_id 0 => 2900152


Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker