Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0011143Openbravo ERPZ. Otherspublic2009-10-26 19:422009-11-19 00:00
Reportershuehner 
Assigned Toshuehner 
PriorityurgentSeveritymajorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Versionpi 
Target VersionFixed in Version 
Merge Request Status
Review Assigned To
OBNetwork customer
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0011143: Some columns are defined as reference type NUMBER but should be INTEGER
DescriptionSome columns are defined as a reference type of number but from a logical perspective only contain integral numbers.

The list of columns of type NUMBER should be checked and the reference should be switched to INTEGER were needed.
Steps To Reproduce
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
related to defect 0011134 closed marvintm API check build 184 fails 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2009-10-26 19:42shuehnerNew Issue
2009-10-26 19:42shuehnerAssigned To => shuehner
2009-10-26 19:42shuehnerRelationship addedrelated to 0011134
2009-10-26 19:44shuehnerNote Added: 0021383
2009-10-26 19:49shuehnerNote Added: 0021386
2009-10-26 20:02hgbotCheckin
2009-10-26 20:02hgbotNote Added: 0021388
2009-10-26 20:02hgbotStatusnew => resolved
2009-10-26 20:02hgbotResolutionopen => fixed
2009-10-26 20:02hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/d452c4faba682b89ed134a01cd2dd09e7d554e6e [^]
2009-10-26 20:57hgbotCheckin
2009-10-26 20:57hgbotNote Added: 0021393
2009-10-26 20:57hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/devel/pi/rev/d452c4faba682b89ed134a01cd2dd09e7d554e6e [^] => http://code.openbravo.com/erp/devel/pi/rev/6d0085326e92f89b8f5dac8e8ee3cf820c151378 [^]
2009-10-27 10:31shuehnerStatusresolved => new
2009-10-27 10:31shuehnerResolutionfixed => open
2009-10-27 10:31shuehnerNote Added: 0021406
2009-10-28 14:26hgbotCheckin
2009-10-28 14:26hgbotNote Added: 0021445
2009-10-28 14:26hgbotStatusnew => resolved
2009-10-28 14:26hgbotResolutionopen => fixed
2009-10-28 14:26hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/devel/pi/rev/6d0085326e92f89b8f5dac8e8ee3cf820c151378 [^] => http://code.openbravo.com/erp/devel/pi/rev/9e660d4a5c4a463159660e3379d854822ba99401 [^]
2009-11-18 16:13marvintmNote Added: 0021974
2009-11-18 16:13marvintmStatusresolved => closed
2009-11-19 00:00anonymoussf_bug_id0 => 2900152

Notes
(0021383)
shuehner   
2009-10-26 19:44   
Note changing this reference changes the public API as the DAL type mapping for NUMBER is now BigDecimal.class (>MP8) and was float (<=MP8) and the type mapping for INTEGER is Long.class

However as the API change for NUMERIC references from Float -> BigDecimal will be done and acknowledged this change here can ride along the 11134 API change, as it does not increase its size but exactly affects a subset of the fields which change its type.
(0021386)
shuehner   
2009-10-26 19:49   
List of fields where the reference will be change from NUMBER -> INTEGER:

- ModelImplementationParameter.LineNo
  this fields describe the order of several parameters attached to one ad_model_object record.

- ModuleInstall.SequenceNo (ad_module_install.seqno)
  the table ad_module_install is a copy of the ad_module table. Change seqno from ad_module_install to the reference of ad_module.seqno

- System.{TADRecordrange,TADRecordrangeinfo,TADTransactionalrange}
  These values describe number of records shown and number of days in a range to be shown

- Country.IbanLength
  Number of digits in a number for validation

- Tax.LineNo (I_TAX.LineNo)
  Line No

- {AccptRptGroup,AcctRptNode}.LineNo
  Line No

- PriceAdjustment.Priority
  value to select preference of several price adjustments. -> integral
(0021388)
hgbot   
2009-10-26 20:02   
Repository: erp/devel/pi
Changeset: d452c4faba682b89ed134a01cd2dd09e7d554e6e
Author: Stefan Hühner <stefan.huehner <at> openbravo.com>
Date: Mon Oct 26 20:02:02 2009 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/d452c4faba682b89ed134a01cd2dd09e7d554e6e [^]

Fixed 11143: Change reference of some column from number -> integer...
where the value in the column is always integral (i.e. number of records).

---
M src-db/database/sourcedata/AD_COLUMN.xml
---
(0021393)
hgbot   
2009-10-26 20:57   
Repository: erp/devel/pi
Changeset: 6d0085326e92f89b8f5dac8e8ee3cf820c151378
Author: Stefan Huehner <stefan.huehner <at> openbravo.com>
Date: Mon Oct 26 20:56:50 2009 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/6d0085326e92f89b8f5dac8e8ee3cf820c151378 [^]

Issue 11143: Backout changeset: 5326:d452c4faba68 as...
its need updated Masterdata..

---
M src-db/database/sourcedata/AD_COLUMN.xml
---
(0021406)
shuehner   
2009-10-27 10:31   
Reopened as commit was reverted.
(0021445)
hgbot   
2009-10-28 14:26   
Repository: erp/devel/pi
Changeset: 9e660d4a5c4a463159660e3379d854822ba99401
Author: Stefan Hühner <stefan.huehner <at> openbravo.com>
Date: Wed Oct 28 14:25:41 2009 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/9e660d4a5c4a463159660e3379d854822ba99401 [^]

Fixed 11143: Change some column references from Number -> Integer ...
as they only contain integral values.
Update Masterdata & Sampledata as the serialized numberforamt is slightly
different (28 now instead of 28.0)

---
M referencedata/sampledata/Accounting_Test.xml
M referencedata/sampledata/SmallBazaar.xml
M referencedata/standard/Masterdata.xml
M src-db/database/sourcedata/AD_COLUMN.xml
---
(0021974)
marvintm   
2009-11-18 16:13   
All the changed columns were revised to check that the changes were correct. Both install.source and update.database work with the changed .xml files.