Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue DetailsJump to Notes ] Issue History ] Print ]
ID
0011084
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[Openbravo ERP] Z. Otherscriticalhave not tried2009-10-22 09:262009-10-23 00:01
ReportershuehnerView Statuspublic 
Assigned Toalostale 
PriorityimmediateResolutionfixedFixed in Version
StatusclosedFix in branchFixed in SCM revision5aca2e8fb63b
ProjectionnoneETAnoneTarget Version
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionpiSCM revision 
Review Assigned To
Web browser
ModulesCore
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0011084: API check build 179 fails

DescriptionThis api check build fails:

http://builds.openbravo.com/job/erp_devel_pi-module-integrity-test/179/console [^]

This issue track the following problem:

org.openbravo.erpCommon.ad_callouts:
Missing
class org.openbravo.erpCommon.ad_callouts.ComboReloads475: missing in /var/www/localhost/htdocs/japi/179
TagsNo tags attached.
Attached Files

- Relationships Relation Graph ] Dependency Graph ]
related to design defect 0011093 acknowledgedTriage Platform Base java API check should ignore generated ComboReload* classes 

-  Notes
(0021310)
shuehner (administrator)
2009-10-22 09:28

This class is generated based on the AD_data. The fact that its missing is not necessarily an error but a special case.

Purpose of the class is changing of a ComboBoxes values in the tab 'Session', based on other values.

proposal:
We should check if the change was intended, if yes ignore as false positive, as tall the generated ComboReload-classes are only used by the generated code and are not intended to be used manually.
(0021311)
shuehner (administrator)
2009-10-22 09:29

Most likely introduced by this commit:

Revision: 5287
Branch: default
Author: Asier Lostalé <asier.lostale@openbravo.com> 2009-10-21 12:21:55
Committer: Asier Lostalé <asier.lostale@openbravo.com> 2009-10-21 12:21:55
Parent: 5286:31477777ca43 (Fixed issue 11059. Added identifier to AD_EP_Instance_Para table.)
Child: 5288:43aebd51aff4 (issue 11047)

    fixed issue 11047: Create a session management window

Change of the ui pattern to SingleRecord for the ad_tab wuith id 475.
(0021314)
shuehner (administrator)
2009-10-22 10:13

@pjuvara: please also comment on disabling the check for all ComboReloads are they are generated and should not be used manually, so technically shouldn't be part of the stable part
(0021322)
alostale (manager)
2009-10-22 12:42

This is a change in a ComboReload generated callout. These callouts are intended to be used just by WAD windows, therefore their API should be checked (as it is not checked WAD windows API).

I would reject this issue, and if possible remove check for ComboReloads API.
(0021339)
dmitry_mezentsev (developer)
2009-10-22 15:32

Stefan,

Thanks for the comments.
I agree that
1. This one is false-positive.
2. We should disable the check for all ComboReloads.
(0021340)
hgbot (developer)
2009-10-22 15:41

Repository: erp/devel/api-checks
Changeset: 5aca2e8fb63bb421c682762321cdc0592c9e664a
Author: Asier Lostalé <asier.lostale <at> openbravo.com>
Date: Thu Oct 22 15:40:26 2009 +0200
URL: http://code.openbravo.com/erp/devel/api-checks/rev/5aca2e8fb63bb421c682762321cdc0592c9e664a [^]

fixed issue 11084: API check build 179 fails - false positive

---
M java/reference/250.japi.gz
---

- Issue History
Date Modified Username Field Change
2009-10-22 09:26 shuehner New Issue
2009-10-22 09:26 shuehner Assigned To => alostale
2009-10-22 09:28 shuehner Note Added: 0021310
2009-10-22 09:29 shuehner Note Added: 0021311
2009-10-22 10:13 shuehner Note Added: 0021314
2009-10-22 12:42 alostale Note Added: 0021322
2009-10-22 12:42 alostale Assigned To alostale => pjuvara
2009-10-22 14:57 shuehner Assigned To pjuvara => dmitry_mezentsev
2009-10-22 15:32 dmitry_mezentsev Note Added: 0021339
2009-10-22 15:32 dmitry_mezentsev Assigned To dmitry_mezentsev => alostale
2009-10-22 15:41 hgbot Checkin
2009-10-22 15:41 hgbot Note Added: 0021340
2009-10-22 15:41 hgbot Status new => resolved
2009-10-22 15:41 hgbot Resolution open => fixed
2009-10-22 15:41 hgbot Fixed in SCM revision => http://code.openbravo.com/erp/devel/api-checks/rev/5aca2e8fb63bb421c682762321cdc0592c9e664a [^]
2009-10-22 15:48 shuehner Relationship added related to 0011093
2009-10-22 15:49 alostale Status resolved => closed
2009-10-23 00:01 anonymous sf_bug_id 0 => 2884271


Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker