Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0011084Openbravo ERPZ. Otherspublic2009-10-22 09:262009-10-23 00:01
Reportershuehner 
Assigned Toalostale 
PriorityimmediateSeveritycriticalReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Versionpi 
Target VersionFixed in Version 
Merge Request Status
Review Assigned To
OBNetwork customerNo
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0011084: API check build 179 fails
DescriptionThis api check build fails:

http://builds.openbravo.com/job/erp_devel_pi-module-integrity-test/179/console [^]

This issue track the following problem:

org.openbravo.erpCommon.ad_callouts:
Missing
class org.openbravo.erpCommon.ad_callouts.ComboReloads475: missing in /var/www/localhost/htdocs/japi/179
Steps To Reproduce
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
related to design defect 0011093 acknowledged Triage Platform Base java API check should ignore generated ComboReload* classes 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2009-10-22 09:26shuehnerNew Issue
2009-10-22 09:26shuehnerAssigned To => alostale
2009-10-22 09:26shuehnerOBNetwork customer => No
2009-10-22 09:28shuehnerNote Added: 0021310
2009-10-22 09:29shuehnerNote Added: 0021311
2009-10-22 10:13shuehnerNote Added: 0021314
2009-10-22 12:42alostaleNote Added: 0021322
2009-10-22 12:42alostaleAssigned Toalostale => pjuvara
2009-10-22 14:57shuehnerAssigned Topjuvara => dmitry_mezentsev
2009-10-22 15:32dmitry_mezentsevNote Added: 0021339
2009-10-22 15:32dmitry_mezentsevAssigned Todmitry_mezentsev => alostale
2009-10-22 15:41hgbotCheckin
2009-10-22 15:41hgbotNote Added: 0021340
2009-10-22 15:41hgbotStatusnew => resolved
2009-10-22 15:41hgbotResolutionopen => fixed
2009-10-22 15:41hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/api-checks/rev/5aca2e8fb63bb421c682762321cdc0592c9e664a [^]
2009-10-22 15:48shuehnerRelationship addedrelated to 0011093
2009-10-22 15:49alostaleStatusresolved => closed
2009-10-23 00:01anonymoussf_bug_id0 => 2884271

Notes
(0021310)
shuehner   
2009-10-22 09:28   
This class is generated based on the AD_data. The fact that its missing is not necessarily an error but a special case.

Purpose of the class is changing of a ComboBoxes values in the tab 'Session', based on other values.

proposal:
We should check if the change was intended, if yes ignore as false positive, as tall the generated ComboReload-classes are only used by the generated code and are not intended to be used manually.
(0021311)
shuehner   
2009-10-22 09:29   
Most likely introduced by this commit:

Revision: 5287
Branch: default
Author: Asier Lostalé <asier.lostale@openbravo.com> 2009-10-21 12:21:55
Committer: Asier Lostalé <asier.lostale@openbravo.com> 2009-10-21 12:21:55
Parent: 5286:31477777ca43 (Fixed issue 11059. Added identifier to AD_EP_Instance_Para table.)
Child: 5288:43aebd51aff4 (issue 11047)

    fixed issue 11047: Create a session management window

Change of the ui pattern to SingleRecord for the ad_tab wuith id 475.
(0021314)
shuehner   
2009-10-22 10:13   
@pjuvara: please also comment on disabling the check for all ComboReloads are they are generated and should not be used manually, so technically shouldn't be part of the stable part
(0021322)
alostale   
2009-10-22 12:42   
This is a change in a ComboReload generated callout. These callouts are intended to be used just by WAD windows, therefore their API should be checked (as it is not checked WAD windows API).

I would reject this issue, and if possible remove check for ComboReloads API.
(0021339)
dmitry_mezentsev   
2009-10-22 15:32   
Stefan,

Thanks for the comments.
I agree that
1. This one is false-positive.
2. We should disable the check for all ComboReloads.
(0021340)
hgbot   
2009-10-22 15:41   
Repository: erp/devel/api-checks
Changeset: 5aca2e8fb63bb421c682762321cdc0592c9e664a
Author: Asier Lostalé <asier.lostale <at> openbravo.com>
Date: Thu Oct 22 15:40:26 2009 +0200
URL: http://code.openbravo.com/erp/devel/api-checks/rev/5aca2e8fb63bb421c682762321cdc0592c9e664a [^]

fixed issue 11084: API check build 179 fails - false positive

---
M java/reference/250.japi.gz
---