Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue DetailsJump to Notes ] Issue History ] Print ]
ID
0010245
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[Openbravo ERP] A. Platformminorhave not tried2009-08-12 10:242010-04-17 00:00
ReporterAinhoaPagolaView Statuspublic 
Assigned Toiperdomo 
PriorityurgentResolutionfixedFixed in Version
StatusclosedFix in branchFixed in SCM revision21e4581bac73
ProjectionnoneETAnoneTarget Version2.50MP14
OSLinux 32 bitDatabaseAnyJava version1.5
OS VersionUbuntu 8.4Database versionAnt version1.7
Product VersionpiSCM revision 
Review Assigned To
Web browser
ModulesCore
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0010245: Process Scheduling: Start Time in Process Request is not taken into account if daily option is not null

DescriptionIf a process request is filled out with frequency field set to daily, the fields daily option and start time are incompatible.

If frequency is set to daily and:

- start time is set and daily option field is null -> process scheduled to start time.
- daily option is NOT null -> start time is ignored and the process is scheduled to 'now' time.
Steps To ReproduceGo to General Setup || Process Scheduling || Process Request
Create a new record:
* Timing: Schedule
* Frequency: Daily
* Start time: 00:00
* daily option: Every N days.
* daily interval: 1
Click on schedule process

Check that in ad_process_request table the field next_fire is created for 'now' hour and no for '00:00' hour. If daily_option field was null, the hour would be 00:00.
Proposed SolutionI have several proposals:

1.- Take into account the start time although daily option is selected.
2.- Show a message to advise the user that the start time will not be considered if daily option has a value.
3.- If daily option is not null hide the start time. Be careful because it will be hidden by default and it's not intuitive how to make it visible.

If possible, I would go for 1.

If case of 2 or 3 I would suggest to remove the 'on default = N' set in the application dictionary for daily_option column. Notice that in the database there is no default set. If for some reason this default value is kept, I would set a default value (1) for daily_interval.
TagsNo tags attached.
Attached Files

- Relationships Relation Graph ] Dependency Graph ]
related to defect 00126922.50MP14 closediperdomo erp_devel_int-module-integrity-test - Build # 141 - Failure 

-  Notes
(0019312)
rafaroda (developer)
2009-08-31 09:58

Iván,

Can you comment on the proposed solutions and schedule this issue?

Thanks.
(0022163)
pjuvara (reporter)
2009-11-25 10:45

The problem is more generic than stated above. It is in general possible to save a process request with a schedule that is not well formed.
(0022654)
rafaroda (developer)
2009-12-10 17:45

Reminder sent to: pjuvara

Hi Paolo,

Please confirm that this is an OBPS defect and inform about a target version.

Thanks.
(0024724)
iperdomo (reporter)
2010-02-23 09:49

@adrianromero:

There is no need to rise the priority. It is scheduled for 2.50MP13 and must be fixed for that release no matter what priority the issue has.

Cheers,

Iván
(0025489)
hgbot (developer)
2010-03-15 18:30

Repository: erp/devel/pi
Changeset: 1d4395cec278881d8adbf8072676303ea8b8c439
Author: Iván Perdomo <ivan.perdomo <at> openbravo.com>
Date: Mon Mar 15 18:34:57 2010 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/1d4395cec278881d8adbf8072676303ea8b8c439 [^]

Added mandatory flags and default values. Related to issue 10245

---
M src-db/database/sourcedata/AD_COLUMN.xml
---
(0025498)
hgbot (developer)
2010-03-15 20:30

Repository: erp/devel/pi
Changeset: 1232be2520b1301be34c28b7ce48ef757196a23c
Author: Iván Perdomo <ivan.perdomo <at> openbravo.com>
Date: Mon Mar 15 20:36:52 2010 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/1232be2520b1301be34c28b7ce48ef757196a23c [^]

Fixes issue 10245: Added trigger to validate process request info

---
M src-db/database/model/triggers/AD_PROCESS_REQUEST_TRG.xml
M src-db/database/sourcedata/AD_MESSAGE.xml
M src/org/openbravo/base/secureApp/HttpSecureAppServlet.java
---
(0025535)
hgbot (developer)
2010-03-16 11:38

Repository: erp/devel/pi
Changeset: 21e4581bac7323adf3740f25afb1e296d9d026c6
Author: Iván Perdomo <ivan.perdomo <at> openbravo.com>
Date: Tue Mar 16 11:21:49 2010 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/21e4581bac7323adf3740f25afb1e296d9d026c6 [^]

Fixes issue 10245: Added default values to start date and start time

---
M src-db/database/sourcedata/AD_COLUMN.xml
---
(0025552)
hudsonbot (developer)
2010-03-17 09:01

A changeset related to this issue has been promoted to main after passing a series of tests and an OBX has been generated:

Changeset: http://code.openbravo.com/erp/devel/main/rev/1d4395cec278 [^]
Merge Changeset: http://code.openbravo.com/erp/devel/main/rev/859b8a1e96e9 [^]
Tests: http://builds.openbravo.com/view/devel-int/ [^]
OBX: http://builds.openbravo.com/erp/core/obx/OpenbravoERP-2.50CI.16735.obx [^]
(0025553)
hudsonbot (developer)
2010-03-17 09:01

A changeset related to this issue has been promoted to main after passing a series of tests and an OBX has been generated:

Changeset: http://code.openbravo.com/erp/devel/main/rev/1232be2520b1 [^]
Merge Changeset: http://code.openbravo.com/erp/devel/main/rev/859b8a1e96e9 [^]
Tests: http://builds.openbravo.com/view/devel-int/ [^]
OBX: http://builds.openbravo.com/erp/core/obx/OpenbravoERP-2.50CI.16735.obx [^]
(0025559)
hudsonbot (developer)
2010-03-17 09:01

A changeset related to this issue has been promoted to main after passing a series of tests and an OBX has been generated:

Changeset: http://code.openbravo.com/erp/devel/main/rev/1d4395cec278 [^]
Merge Changeset: http://code.openbravo.com/erp/devel/main/rev/859b8a1e96e9 [^]
Tests: http://builds.openbravo.com/view/devel-int/ [^]
OBX: http://builds.openbravo.com/erp/core/obx/OpenbravoERP-2.50CI.16735.obx [^]
(0025560)
hudsonbot (developer)
2010-03-17 09:01

A changeset related to this issue has been promoted to main after passing a series of tests and an OBX has been generated:

Changeset: http://code.openbravo.com/erp/devel/main/rev/21e4581bac73 [^]
Merge Changeset: http://code.openbravo.com/erp/devel/main/rev/859b8a1e96e9 [^]
Tests: http://builds.openbravo.com/view/devel-int/ [^]
OBX: http://builds.openbravo.com/erp/core/obx/OpenbravoERP-2.50CI.16735.obx [^]
(0026072)
shuehner (administrator)
2010-04-12 17:42

Reviewing code with developer, all tested code-path seem fine. Testing in pi/ora for normal popup operation (sucessfull/error-case) of scheduling popup and normal complete order process.
(0026311)
shuehner (administrator)
2010-04-16 12:19

Tested, working fine.

- Issue History
Date Modified Username Field Change
2009-08-12 10:24 AinhoaPagola New Issue
2009-08-12 10:24 AinhoaPagola Assigned To => iperdomo
2009-08-31 09:58 rafaroda Note Added: 0019312
2009-08-31 09:58 rafaroda Priority normal => high
2009-08-31 09:58 rafaroda Status new => acknowledged
2009-08-31 09:58 rafaroda Proposed Solution updated
2009-08-31 09:58 rafaroda Steps to Reproduce Updated
2009-11-25 10:45 pjuvara Note Added: 0022163
2009-12-07 20:16 psarobe Status acknowledged => scheduled
2009-12-10 17:45 rafaroda Issue Monitored: pjuvara
2009-12-10 17:45 rafaroda Note Added: 0022654
2010-01-26 17:44 pjuvara Target Version => 2.50MP13
2010-02-23 09:44 adrianromero Priority high => urgent
2010-02-23 09:49 iperdomo Note Added: 0024724
2010-03-08 16:06 jpabloae Target Version 2.50MP13 => 2.50MP14
2010-03-15 18:30 hgbot Checkin
2010-03-15 18:30 hgbot Note Added: 0025489
2010-03-15 20:30 hgbot Checkin
2010-03-15 20:30 hgbot Note Added: 0025498
2010-03-15 20:30 hgbot Status scheduled => resolved
2010-03-15 20:30 hgbot Resolution open => fixed
2010-03-15 20:30 hgbot Fixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/1232be2520b1301be34c28b7ce48ef757196a23c [^]
2010-03-16 07:51 iperdomo Relationship added blocks 0012692
2010-03-16 07:52 iperdomo Relationship replaced related to 0012692
2010-03-16 11:38 hgbot Checkin
2010-03-16 11:38 hgbot Note Added: 0025535
2010-03-16 11:38 hgbot Fixed in SCM revision http://code.openbravo.com/erp/devel/pi/rev/1232be2520b1301be34c28b7ce48ef757196a23c [^] => http://code.openbravo.com/erp/devel/pi/rev/21e4581bac7323adf3740f25afb1e296d9d026c6 [^]
2010-03-17 09:01 hudsonbot Checkin
2010-03-17 09:01 hudsonbot Note Added: 0025552
2010-03-17 09:01 hudsonbot Checkin
2010-03-17 09:01 hudsonbot Note Added: 0025553
2010-03-17 09:01 hudsonbot Checkin
2010-03-17 09:01 hudsonbot Note Added: 0025559
2010-03-17 09:01 hudsonbot Checkin
2010-03-17 09:01 hudsonbot Note Added: 0025560
2010-04-12 17:42 shuehner Note Added: 0026072
2010-04-16 12:19 shuehner Note Added: 0026311
2010-04-16 12:19 shuehner Status resolved => closed
2010-04-17 00:00 anonymous sf_bug_id 0 => 2988594


Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker