Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
0010245Openbravo ERPA. Platformpublic2009-08-12 10:242010-04-17 00:00
AinhoaPagola 
iperdomo 
urgentminorhave not tried
closedfixed 
20Ubuntu 8.4
pi 
2.50MP14 
Core
No
0010245: Process Scheduling: Start Time in Process Request is not taken into account if daily option is not null
If a process request is filled out with frequency field set to daily, the fields daily option and start time are incompatible.

If frequency is set to daily and:

- start time is set and daily option field is null -> process scheduled to start time.
- daily option is NOT null -> start time is ignored and the process is scheduled to 'now' time.
Go to General Setup || Process Scheduling || Process Request
Create a new record:
* Timing: Schedule
* Frequency: Daily
* Start time: 00:00
* daily option: Every N days.
* daily interval: 1
Click on schedule process

Check that in ad_process_request table the field next_fire is created for 'now' hour and no for '00:00' hour. If daily_option field was null, the hour would be 00:00.
I have several proposals:

1.- Take into account the start time although daily option is selected.
2.- Show a message to advise the user that the start time will not be considered if daily option has a value.
3.- If daily option is not null hide the start time. Be careful because it will be hidden by default and it's not intuitive how to make it visible.

If possible, I would go for 1.

If case of 2 or 3 I would suggest to remove the 'on default = N' set in the application dictionary for daily_option column. Notice that in the database there is no default set. If for some reason this default value is kept, I would set a default value (1) for daily_interval.
No tags attached.
related to defect 00126922.50MP14 closed iperdomo erp_devel_int-module-integrity-test - Build # 141 - Failure 
Issue History
2009-08-12 10:24AinhoaPagolaNew Issue
2009-08-12 10:24AinhoaPagolaAssigned To => iperdomo
2009-08-31 09:58rafarodaNote Added: 0019312
2009-08-31 09:58rafarodaPrioritynormal => high
2009-08-31 09:58rafarodaStatusnew => acknowledged
2009-08-31 09:58rafarodaProposed Solution updated
2009-08-31 09:58rafarodaSteps to Reproduce Updated
2009-11-25 10:45pjuvaraNote Added: 0022163
2009-12-07 20:16psarobeStatusacknowledged => scheduled
2009-12-10 17:45rafarodaIssue Monitored: pjuvara
2009-12-10 17:45rafarodaNote Added: 0022654
2010-01-26 17:44pjuvaraTarget Version => 2.50MP13
2010-02-23 09:44adrianromeroPriorityhigh => urgent
2010-02-23 09:49iperdomoNote Added: 0024724
2010-03-08 16:06jpabloaeTarget Version2.50MP13 => 2.50MP14
2010-03-15 18:30hgbotCheckin
2010-03-15 18:30hgbotNote Added: 0025489
2010-03-15 20:30hgbotCheckin
2010-03-15 20:30hgbotNote Added: 0025498
2010-03-15 20:30hgbotStatusscheduled => resolved
2010-03-15 20:30hgbotResolutionopen => fixed
2010-03-15 20:30hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/1232be2520b1301be34c28b7ce48ef757196a23c [^]
2010-03-16 07:51iperdomoRelationship addedblocks 0012692
2010-03-16 07:52iperdomoRelationship replacedrelated to 0012692
2010-03-16 11:38hgbotCheckin
2010-03-16 11:38hgbotNote Added: 0025535
2010-03-16 11:38hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/devel/pi/rev/1232be2520b1301be34c28b7ce48ef757196a23c [^] => http://code.openbravo.com/erp/devel/pi/rev/21e4581bac7323adf3740f25afb1e296d9d026c6 [^]
2010-03-17 09:01hudsonbotCheckin
2010-03-17 09:01hudsonbotNote Added: 0025552
2010-03-17 09:01hudsonbotCheckin
2010-03-17 09:01hudsonbotNote Added: 0025553
2010-03-17 09:01hudsonbotCheckin
2010-03-17 09:01hudsonbotNote Added: 0025559
2010-03-17 09:01hudsonbotCheckin
2010-03-17 09:01hudsonbotNote Added: 0025560
2010-04-12 17:42shuehnerNote Added: 0026072
2010-04-16 12:19shuehnerNote Added: 0026311
2010-04-16 12:19shuehnerStatusresolved => closed
2010-04-17 00:00anonymoussf_bug_id0 => 2988594

Notes
(0019312)
rafaroda   
2009-08-31 09:58   
Iván,

Can you comment on the proposed solutions and schedule this issue?

Thanks.
(0022163)
pjuvara   
2009-11-25 10:45   
The problem is more generic than stated above. It is in general possible to save a process request with a schedule that is not well formed.
(0022654)
rafaroda   
2009-12-10 17:45   
Reminder sent to: pjuvara

Hi Paolo,

Please confirm that this is an OBPS defect and inform about a target version.

Thanks.
(0024724)
iperdomo   
2010-02-23 09:49   
@adrianromero:

There is no need to rise the priority. It is scheduled for 2.50MP13 and must be fixed for that release no matter what priority the issue has.

Cheers,

Iván
(0025489)
hgbot   
2010-03-15 18:30   
Repository: erp/devel/pi
Changeset: 1d4395cec278881d8adbf8072676303ea8b8c439
Author: Iván Perdomo <ivan.perdomo <at> openbravo.com>
Date: Mon Mar 15 18:34:57 2010 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/1d4395cec278881d8adbf8072676303ea8b8c439 [^]

Added mandatory flags and default values. Related to issue 10245

---
M src-db/database/sourcedata/AD_COLUMN.xml
---
(0025498)
hgbot   
2010-03-15 20:30   
Repository: erp/devel/pi
Changeset: 1232be2520b1301be34c28b7ce48ef757196a23c
Author: Iván Perdomo <ivan.perdomo <at> openbravo.com>
Date: Mon Mar 15 20:36:52 2010 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/1232be2520b1301be34c28b7ce48ef757196a23c [^]

Fixes issue 10245: Added trigger to validate process request info

---
M src-db/database/model/triggers/AD_PROCESS_REQUEST_TRG.xml
M src-db/database/sourcedata/AD_MESSAGE.xml
M src/org/openbravo/base/secureApp/HttpSecureAppServlet.java
---
(0025535)
hgbot   
2010-03-16 11:38   
Repository: erp/devel/pi
Changeset: 21e4581bac7323adf3740f25afb1e296d9d026c6
Author: Iván Perdomo <ivan.perdomo <at> openbravo.com>
Date: Tue Mar 16 11:21:49 2010 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/21e4581bac7323adf3740f25afb1e296d9d026c6 [^]

Fixes issue 10245: Added default values to start date and start time

---
M src-db/database/sourcedata/AD_COLUMN.xml
---
(0025552)
hudsonbot   
2010-03-17 09:01   
A changeset related to this issue has been promoted to main after passing a series of tests and an OBX has been generated:

Changeset: http://code.openbravo.com/erp/devel/main/rev/1d4395cec278 [^]
Merge Changeset: http://code.openbravo.com/erp/devel/main/rev/859b8a1e96e9 [^]
Tests: http://builds.openbravo.com/view/devel-int/ [^]
OBX: http://builds.openbravo.com/erp/core/obx/OpenbravoERP-2.50CI.16735.obx [^]
(0025553)
hudsonbot   
2010-03-17 09:01   
A changeset related to this issue has been promoted to main after passing a series of tests and an OBX has been generated:

Changeset: http://code.openbravo.com/erp/devel/main/rev/1232be2520b1 [^]
Merge Changeset: http://code.openbravo.com/erp/devel/main/rev/859b8a1e96e9 [^]
Tests: http://builds.openbravo.com/view/devel-int/ [^]
OBX: http://builds.openbravo.com/erp/core/obx/OpenbravoERP-2.50CI.16735.obx [^]
(0025559)
hudsonbot   
2010-03-17 09:01   
A changeset related to this issue has been promoted to main after passing a series of tests and an OBX has been generated:

Changeset: http://code.openbravo.com/erp/devel/main/rev/1d4395cec278 [^]
Merge Changeset: http://code.openbravo.com/erp/devel/main/rev/859b8a1e96e9 [^]
Tests: http://builds.openbravo.com/view/devel-int/ [^]
OBX: http://builds.openbravo.com/erp/core/obx/OpenbravoERP-2.50CI.16735.obx [^]
(0025560)
hudsonbot   
2010-03-17 09:01   
A changeset related to this issue has been promoted to main after passing a series of tests and an OBX has been generated:

Changeset: http://code.openbravo.com/erp/devel/main/rev/21e4581bac73 [^]
Merge Changeset: http://code.openbravo.com/erp/devel/main/rev/859b8a1e96e9 [^]
Tests: http://builds.openbravo.com/view/devel-int/ [^]
OBX: http://builds.openbravo.com/erp/core/obx/OpenbravoERP-2.50CI.16735.obx [^]
(0026072)
shuehner   
2010-04-12 17:42   
Reviewing code with developer, all tested code-path seem fine. Testing in pi/ora for normal popup operation (sucessfull/error-case) of scheduling popup and normal complete order process.
(0026311)
shuehner   
2010-04-16 12:19   
Tested, working fine.