Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue DetailsJump to Notes ] Issue History ] Print ]
ID
0010133
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[Openbravo ERP] A. Platformminorhave not tried2009-07-30 15:392009-08-19 00:00
ReportershuehnerView Statuspublic 
Assigned Toshuehner 
PrioritynormalResolutionfixedFixed in Versionpi
StatusclosedFix in branchpiFixed in SCM revisioneb8040ff6595
ProjectionnoneETAnoneTarget Version
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product Version2.40SCM revision 
Review Assigned To
Web browser
ModulesCore
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0010133: Generated windows still execute code for old keyboard shortcut system which is then later not used.

DescriptionThe generated servlets for edit- & grid-view still run code code (including a database query) for some old keyboard shortcut system (class KeyMap.java). However the result of this code is then discarded when building the html with xmlEngine.

To improve performance the code should be removed to not execute this unused database query.
TagsNo tags attached.
Attached Files

- Relationships Relation Graph ] Dependency Graph ]
depends on backport 0010134 closedshuehner Generated windows still execute code for old keyboard shortcut system which is then later not used. 

-  Notes
(0018726)
hgbot (developer)
2009-07-30 16:39

Repository: erp/devel/pi
Changeset: eb8040ff6595d122b4beaf7e9fc80dcd9f34a0a6
Author: Stefan Hühner <stefan.huehner <at> openbravo.com>
Date: Thu Jul 30 16:39:29 2009 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/eb8040ff6595d122b4beaf7e9fc80dcd9f34a0a6 [^]

Fixed 10133: Remove unused code for old KeyMap keyboard shortcut system
- Removes one unneeded database query from each generated window

---
M src-wad/src/org/openbravo/wad/Configuration_Edition.xmlxml
M src-wad/src/org/openbravo/wad/Configuration_Relation.xmlxml
M src-wad/src/org/openbravo/wad/Template_Edition.html
M src-wad/src/org/openbravo/wad/Template_Relation.html
M src-wad/src/org/openbravo/wad/javasource.javaxml
---
(0018730)
shuehner (administrator)
2009-07-30 18:20

@qa: This should introduce not user visible change in behavior.

All keyboard shortcuts which did work before should still work:

List of shortcuts can be found at [1]:

[1] http://wiki.openbravo.com/wiki/Projects/KeyboardOperation/FunctionalSpecifications [^]
(0018997)
sureshbabu (reporter)
2009-08-18 10:57

Checked the hot keys listed under http://wiki.openbravo.com/wiki/Projects/KeyboardOperation/FunctionalSpecifications [^] [^]

- Issue History
Date Modified Username Field Change
2009-07-30 15:39 shuehner New Issue
2009-07-30 15:39 shuehner Assigned To => shuehner
2009-07-30 15:39 shuehner Status new => scheduled
2009-07-30 15:39 shuehner fix_in_branch => pi
2009-07-30 16:39 hgbot Checkin
2009-07-30 16:39 hgbot Note Added: 0018726
2009-07-30 16:39 hgbot Status scheduled => resolved
2009-07-30 16:39 hgbot Resolution open => fixed
2009-07-30 16:39 hgbot Fixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/eb8040ff6595d122b4beaf7e9fc80dcd9f34a0a6 [^]
2009-07-30 18:20 shuehner Note Added: 0018730
2009-08-18 10:57 sureshbabu Status resolved => closed
2009-08-18 10:57 sureshbabu Note Added: 0018997
2009-08-18 10:57 sureshbabu Fixed in Version => pi
2009-08-19 00:00 anonymous sf_bug_id 0 => 2839893


Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker