Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue Details[ Jump to Notes ] [ Issue History ] [ Print ]
ID
0010134
TypeCategorySeverityReproducibilityDate SubmittedLast Update
backport[Openbravo ERP] A. Platformminorhave not tried2009-07-30 15:392009-08-07 15:43
ReportershuehnerView Statuspublic 
Assigned Toshuehner 
PrioritynormalResolutionfixedFixed in Version2.40MP8
StatusclosedFix in branch2.40Fixed in SCM revision80d503f37e75
ProjectionnoneETAnoneTarget Version
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product Version2.40SCM revision 
Review Assigned To
Web browser
ModulesCore
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0010134: Generated windows still execute code for old keyboard shortcut system which is then later not used.

DescriptionThe generated servlets for edit- & grid-view still run code code (including a database query) for some old keyboard shortcut system (class KeyMap.java). However the result of this code is then discarded when building the html with xmlEngine.

To improve performance the code should be removed to not execute this unused database query.
TagsNo tags attached.
Attached Files

- Relationships [ Relation Graph ] [ Dependency Graph ]
blocks defect 0010133 closedshuehner Generated windows still execute code for old keyboard shortcut system which is then later not used. 

-  Notes
(0018725)
hgbot (developer)
2009-07-30 16:38

 Repository: erp/stable/2.40
Changeset: 80d503f37e75a060577324b2421544282f397565
Author: Stefan Hühner <stefan.huehner <at> openbravo.com>
Date: Thu Jul 30 16:37:40 2009 +0200
URL: http://code.openbravo.com/erp/stable/2.40/rev/80d503f37e75a060577324b2421544282f397565 [^]

Fixed 10134: Remove unused code for old KeyMap keyboard shortcut system
- Removes one unneeded database query from each generated window

---
M src-wad/src/org/openbravo/wad/Configuration_Edition.xmlxml
M src-wad/src/org/openbravo/wad/Configuration_Relation.xmlxml
M src-wad/src/org/openbravo/wad/Template_Edition.html
M src-wad/src/org/openbravo/wad/Template_Relation.html
M src-wad/src/org/openbravo/wad/javasource.javaxml
---
(0018731)
shuehner (administrator)
2009-07-30 18:20

 @qa: This should introduce not user visible change in behavior.

All keyboard shortcuts which did work before should still work:

List of shortcuts can be found at [1]:

[1] http://wiki.openbravo.com/wiki/Projects/KeyboardOperation/FunctionalSpecifications [^]
(0018880)
sureshbabu (reporter)
2009-08-07 15:43

 Tested the list of Keyboard keys given in the page

http://wiki.openbravo.com/wiki/Projects/KeyboardOperation/FunctionalSpecifications [^]

working fine

- Issue History
Date Modified Username Field Change
2009-07-30 15:39 shuehner Type defect => backport
2009-07-30 15:39 shuehner fix_in_branch => 2.40
2009-07-30 16:38 hgbot Checkin
2009-07-30 16:38 hgbot Note Added: 0018725
2009-07-30 16:38 hgbot Status scheduled => resolved
2009-07-30 16:38 hgbot Resolution open => fixed
2009-07-30 16:38 hgbot Fixed in SCM revision => http://code.openbravo.com/erp/stable/2.40/rev/80d503f37e75a060577324b2421544282f397565 [^]
2009-07-30 18:20 shuehner Note Added: 0018731
2009-08-07 15:43 sureshbabu Status resolved => closed
2009-08-07 15:43 sureshbabu Note Added: 0018880
2009-08-07 15:43 sureshbabu Fixed in Version => 2.40MP8

Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker