Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue DetailsJump to Notes ] Issue History ] Print ]
ID
0010068
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[Openbravo ERP] A. Platformmajoralways2009-07-27 12:252010-05-18 12:12
ReportergforcadaView Statuspublic 
Assigned Toalostale 
PriorityurgentResolutionfixedFixed in Version
StatusclosedFix in branchpiFixed in SCM revisiond0c5a186a054
ProjectionnoneETAnoneTarget Version2.50MP17
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product Version2.50MP3SCM revision 
Review Assigned To
Web browser
ModulesCore
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0010068: URL links doesn't handle correctly when there URL doesn't start with http://www [^] [http://www [^]]

DescriptionHi,

If you are viewing a module description like for example the "Taxes: configuration for Spain (Impuestos para España)" the URL in the page details goes to http://www.openbravo.com [^] as it shows in the description.

But if you are viewing a module description like for example the "Tax Report Launcher" the URL in the page shows "http://forge.openbravo.com/projects/taxreportlauncher" [^] but when you click on it it redirects to "http://www.http.com//forge.openbravo.com/projects/taxreportlauncher". [^]

Note that it has added a "http://www.http.com//" [^] before the forge.openbravo...

If you look at the generated HTML it shows:

onclick="openLink('http://http://forge.openbravo.com/projects/taxreportlauncher', [^] '_blank');

Which obviously it's wrong and that's why I end being redirected to http://www.http.com//forge.... [^]
Steps To Reproduce- Go to the General Setup -> Application -> Module Management
- See the module details of some modules and click their URL
- Note that the ones that doesn't start with http://www [^] aren't handled correctly
Proposed SolutionMake sure that the URL specified is the one stored at the module preferences. And also make sure that this is a global behaviour, I mean, all fields on the application that have a clickable URL to behave as expected.
TagsModularity
Attached Files

- Relationships Relation Graph ] Dependency Graph ]
has duplicate defect 0010696 closedrafaroda Visit Site links in Add Modules broken 

-  Notes
(0020296)
rafaroda (developer)
2009-09-23 07:59

Upgraded Severity to Major and Priority to High since this seems to be affecting very badly the experience of many users now that many modules are available.
(0022932)
dmitry_mezentsev (developer)
2009-12-18 12:05

While fixing please make sure that both ways of URLs (with http and without) works course now as a workaround lots of modules just start their URLs without http.

Thanks.
(0025761)
iciordia (manager)
2010-03-28 12:14

Asier, let' commit to fix it by next MP since this is a simple fix and it is an annoying bug.

Thanks,

Ismael
(0025980)
hgbot (developer)
2010-04-08 15:30

Repository: erp/devel/pi
Changeset: 6c6935b5ba06f068e738a7b458072eb5173a8086
Author: Asier Lostalé <asier.lostale <at> openbravo.com>
Date: Thu Apr 08 15:41:50 2010 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/6c6935b5ba06f068e738a7b458072eb5173a8086 [^]

fixed issue 10068: URL links doesn't work if they contain protocol

---
M src/org/openbravo/erpCommon/modules/ModuleTree.java
M src/org/openbravo/erpCommon/modules/ModuleTreeDescription.srpt
M src/org/openbravo/erpCommon/modules/ModuleTree_data.xsql
---
(0026227)
iperdomo (reporter)
2010-04-15 10:17
edited on: 2010-04-15 10:18

Tested on PI @ rev 7076c219cdd9

Checking the description of the "Tax Report Launcher" the generated code is:

openLink('http://http://forge.openbravo.com/projects/taxreportlauncher', [^] '_blank');

(0026259)
alostale (manager)
2010-04-15 14:00
edited on: 2010-04-15 14:02

It is fixed in details of "Installed Modules" tab, pending to do it in "Module Details" popup opened from "Add Modules" tab and in "Visit Site" link.

(0026261)
alostale (manager)
2010-04-15 14:15

https://code.openbravo.com/erp/devel/pi/rev/d0c5a186a054 [^]
(0026272)
iperdomo (reporter)
2010-04-15 16:18

Tested on PI @ rev d0c5a186a054
(0026436)
hudsonbot (developer)
2010-04-19 21:12

A changeset related to this issue has been promoted to main after passing a series of tests and an OBX has been generated:

Changeset: http://code.openbravo.com/erp/devel/main/rev/6c6935b5ba06 [^]
Merge Changeset: http://code.openbravo.com/erp/devel/main/rev/91d98bda46c1 [^]
Tests: http://builds.openbravo.com/view/devel-int/ [^]
OBX: http://builds.openbravo.com/erp/core/obx/OpenbravoERP-2.50CI.17088.obx [^]

- Issue History
Date Modified Username Field Change
2009-07-27 12:25 gforcada New Issue
2009-07-27 12:25 gforcada Assigned To => rafaroda
2009-08-12 14:09 pnuding version => 2.50MP3
2009-08-31 09:31 rafaroda Assigned To rafaroda => alostale
2009-08-31 09:31 rafaroda Priority normal => low
2009-08-31 09:31 rafaroda Status new => scheduled
2009-08-31 09:31 rafaroda Category B. User interface => A. Platform
2009-08-31 09:31 rafaroda Tag Attached: Modularity
2009-09-23 07:51 rafaroda Relationship added has duplicate 0010696
2009-09-23 07:59 rafaroda Note Added: 0020296
2009-09-23 07:59 rafaroda Priority low => high
2009-09-23 07:59 rafaroda Severity minor => major
2009-12-01 10:02 rafaroda Relationship added has duplicate 0011399
2009-12-18 12:05 dmitry_mezentsev Note Added: 0022932
2010-03-09 19:56 pjuvara Priority high => urgent
2010-03-28 12:14 iciordia Note Added: 0025761
2010-03-28 12:14 iciordia Fixed in Version => 2.50MP15
2010-04-07 17:18 alostale Fixed in Version 2.50MP15 =>
2010-04-07 17:18 alostale Target Version => 2.50MP15
2010-04-08 15:30 hgbot Checkin
2010-04-08 15:30 hgbot Note Added: 0025980
2010-04-08 15:30 hgbot Status scheduled => resolved
2010-04-08 15:30 hgbot Resolution open => fixed
2010-04-08 15:30 hgbot Fixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/6c6935b5ba06f068e738a7b458072eb5173a8086 [^]
2010-04-15 10:17 iperdomo Note Added: 0026227
2010-04-15 10:17 iperdomo Status resolved => new
2010-04-15 10:17 iperdomo Resolution fixed => open
2010-04-15 10:18 iperdomo Note Edited: 0026227 View Revisions
2010-04-15 14:00 alostale Note Added: 0026259
2010-04-15 14:02 alostale Note Edited: 0026259 View Revisions
2010-04-15 14:15 alostale Status new => scheduled
2010-04-15 14:15 alostale fix_in_branch => pi
2010-04-15 14:15 alostale Note Added: 0026261
2010-04-15 14:15 alostale Status scheduled => resolved
2010-04-15 14:15 alostale Fixed in SCM revision http://code.openbravo.com/erp/devel/pi/rev/6c6935b5ba06f068e738a7b458072eb5173a8086 [^] => https://code.openbravo.com/erp/devel/pi/rev/d0c5a186a054 [^]
2010-04-15 14:15 alostale Resolution open => fixed
2010-04-15 16:18 iperdomo Note Added: 0026272
2010-04-15 16:18 iperdomo Status resolved => closed
2010-04-16 00:00 anonymous sf_bug_id 0 => 2987945
2010-04-19 21:12 hudsonbot Checkin
2010-04-19 21:12 hudsonbot Note Added: 0026436
2010-05-18 12:12 gorka_gil Target Version 2.50MP15 => 2.50MP17


Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker