Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
0010068Openbravo ERPA. Platformpublic2009-07-27 12:252010-05-18 12:12
gforcada 
alostale 
urgentmajoralways
closedfixed 
5
2.50MP3 
2.50MP17 
Core
No
0010068: URL links doesn't handle correctly when there URL doesn't start with http://www [^] [http://www [^]]
Hi,

If you are viewing a module description like for example the "Taxes: configuration for Spain (Impuestos para España)" the URL in the page details goes to http://www.openbravo.com [^] as it shows in the description.

But if you are viewing a module description like for example the "Tax Report Launcher" the URL in the page shows "http://forge.openbravo.com/projects/taxreportlauncher" [^] but when you click on it it redirects to "http://www.http.com//forge.openbravo.com/projects/taxreportlauncher". [^]

Note that it has added a "http://www.http.com//" [^] before the forge.openbravo...

If you look at the generated HTML it shows:

onclick="openLink('http://http://forge.openbravo.com/projects/taxreportlauncher', [^] '_blank');

Which obviously it's wrong and that's why I end being redirected to http://www.http.com//forge.... [^]
- Go to the General Setup -> Application -> Module Management
- See the module details of some modules and click their URL
- Note that the ones that doesn't start with http://www [^] aren't handled correctly
Make sure that the URL specified is the one stored at the module preferences. And also make sure that this is a global behaviour, I mean, all fields on the application that have a clickable URL to behave as expected.
Modularity
has duplicate defect 0010696 closed rafaroda Visit Site links in Add Modules broken 
Issue History
2009-07-27 12:25gforcadaNew Issue
2009-07-27 12:25gforcadaAssigned To => rafaroda
2009-08-12 14:09pnudingversion => 2.50MP3
2009-08-31 09:31rafarodaAssigned Torafaroda => alostale
2009-08-31 09:31rafarodaPrioritynormal => low
2009-08-31 09:31rafarodaStatusnew => scheduled
2009-08-31 09:31rafarodaCategoryB. User interface => A. Platform
2009-08-31 09:31rafarodaTag Attached: Modularity
2009-09-23 07:51rafarodaRelationship addedhas duplicate 0010696
2009-09-23 07:59rafarodaNote Added: 0020296
2009-09-23 07:59rafarodaPrioritylow => high
2009-09-23 07:59rafarodaSeverityminor => major
2009-12-01 10:02rafarodaRelationship addedhas duplicate 0011399
2009-12-18 12:05dmitry_mezentsevNote Added: 0022932
2010-03-09 19:56pjuvaraPriorityhigh => urgent
2010-03-28 12:14iciordiaNote Added: 0025761
2010-03-28 12:14iciordiaFixed in Version => 2.50MP15
2010-04-07 17:18alostaleFixed in Version2.50MP15 =>
2010-04-07 17:18alostaleTarget Version => 2.50MP15
2010-04-08 15:30hgbotCheckin
2010-04-08 15:30hgbotNote Added: 0025980
2010-04-08 15:30hgbotStatusscheduled => resolved
2010-04-08 15:30hgbotResolutionopen => fixed
2010-04-08 15:30hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/6c6935b5ba06f068e738a7b458072eb5173a8086 [^]
2010-04-15 10:17iperdomoNote Added: 0026227
2010-04-15 10:17iperdomoStatusresolved => new
2010-04-15 10:17iperdomoResolutionfixed => open
2010-04-15 10:18iperdomoNote Edited: 0026227bug_revision_view_page.php?bugnote_id=0026227#r244
2010-04-15 14:00alostaleNote Added: 0026259
2010-04-15 14:02alostaleNote Edited: 0026259bug_revision_view_page.php?bugnote_id=0026259#r246
2010-04-15 14:15alostaleStatusnew => scheduled
2010-04-15 14:15alostalefix_in_branch => pi
2010-04-15 14:15alostaleNote Added: 0026261
2010-04-15 14:15alostaleStatusscheduled => resolved
2010-04-15 14:15alostaleFixed in SCM revisionhttp://code.openbravo.com/erp/devel/pi/rev/6c6935b5ba06f068e738a7b458072eb5173a8086 [^] => https://code.openbravo.com/erp/devel/pi/rev/d0c5a186a054 [^]
2010-04-15 14:15alostaleResolutionopen => fixed
2010-04-15 16:18iperdomoNote Added: 0026272
2010-04-15 16:18iperdomoStatusresolved => closed
2010-04-16 00:00anonymoussf_bug_id0 => 2987945
2010-04-19 21:12hudsonbotCheckin
2010-04-19 21:12hudsonbotNote Added: 0026436
2010-05-18 12:12gorka_gilTarget Version2.50MP15 => 2.50MP17

Notes
(0020296)
rafaroda   
2009-09-23 07:59   
Upgraded Severity to Major and Priority to High since this seems to be affecting very badly the experience of many users now that many modules are available.
(0022932)
dmitry_mezentsev   
2009-12-18 12:05   
While fixing please make sure that both ways of URLs (with http and without) works course now as a workaround lots of modules just start their URLs without http.

Thanks.
(0025761)
iciordia   
2010-03-28 12:14   
Asier, let' commit to fix it by next MP since this is a simple fix and it is an annoying bug.

Thanks,

Ismael
(0025980)
hgbot   
2010-04-08 15:30   
Repository: erp/devel/pi
Changeset: 6c6935b5ba06f068e738a7b458072eb5173a8086
Author: Asier Lostalé <asier.lostale <at> openbravo.com>
Date: Thu Apr 08 15:41:50 2010 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/6c6935b5ba06f068e738a7b458072eb5173a8086 [^]

fixed issue 10068: URL links doesn't work if they contain protocol

---
M src/org/openbravo/erpCommon/modules/ModuleTree.java
M src/org/openbravo/erpCommon/modules/ModuleTreeDescription.srpt
M src/org/openbravo/erpCommon/modules/ModuleTree_data.xsql
---
(0026227)
iperdomo   
2010-04-15 10:17   
(edited on: 2010-04-15 10:18)
Tested on PI @ rev 7076c219cdd9

Checking the description of the "Tax Report Launcher" the generated code is:

openLink('http://http://forge.openbravo.com/projects/taxreportlauncher', [^] '_blank');

(0026259)
alostale   
2010-04-15 14:00   
(edited on: 2010-04-15 14:02)
It is fixed in details of "Installed Modules" tab, pending to do it in "Module Details" popup opened from "Add Modules" tab and in "Visit Site" link.

(0026261)
alostale   
2010-04-15 14:15   
https://code.openbravo.com/erp/devel/pi/rev/d0c5a186a054 [^]
(0026272)
iperdomo   
2010-04-15 16:18   
Tested on PI @ rev d0c5a186a054
(0026436)
hudsonbot   
2010-04-19 21:12   
A changeset related to this issue has been promoted to main after passing a series of tests and an OBX has been generated:

Changeset: http://code.openbravo.com/erp/devel/main/rev/6c6935b5ba06 [^]
Merge Changeset: http://code.openbravo.com/erp/devel/main/rev/91d98bda46c1 [^]
Tests: http://builds.openbravo.com/view/devel-int/ [^]
OBX: http://builds.openbravo.com/erp/core/obx/OpenbravoERP-2.50CI.17088.obx [^]