Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue Details[ Jump to Notes ] [ Issue History ] [ Print ]
ID
0057424
TypeCategorySeverityReproducibilityDate SubmittedLast Update
backport[POS2] POScriticalalways2024-12-09 11:182024-12-12 09:18
ReporterwicherrView Statuspublic 
Assigned Toaferraz 
PriorityurgentResolutionfixedFixed in Version
StatusclosedFix in branchFixed in SCM revision
ProjectionnoneETAnoneTarget Version24Q4.1
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Review Assigned To
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0057424: French fiscal : Cancel & replace makes EWI

DescriptionWhen you do a cancel & replace of a ticket made from another till, an EWI is created :
org.openbravo.base.util.CheckException: Triggers were not disabled in this session, call disable before calling this method
    at org.openbravo.base.util.Check.isNotNull(Check.java:72)
    at org.openbravo.dal.core.TriggerHandler.enable(TriggerHandler.java:89)
    at org.openbravo.retail.posterminal.OrderLoader.saveRecord(OrderLoader.java:626)
    at org.openbravo.mobile.core.process.DataSynchronizationProcess.saveRecord(DataSynchronizationProcess.java:214)
    at org.openbravo.mobile.core.process.DataSynchronizationProcess.exec(DataSynchronizationProcess.java:165)
    at org.openbravo.mobile.core.process.DataSynchronizationProcess.exec(DataSynchronizationProcess.java:97)
    at org.openbravo.mobile.core.process.MobileImportEntryProcessorRunnable.processEntry(MobileImportEntryProcessorRunnable.java:55)
    at org.openbravo.retail.posterminal.importprocess.OrderImportEntryProcessor$OrderLoaderRunnable.processEntry(OrderImportEntryProcessor.java:64)
    at org.openbravo.service.importprocess.ImportEntryProcessor$ImportEntryProcessRunnable.doRunCycle(ImportEntryProcessor.java:447)
    at org.openbravo.service.importprocess.ImportEntryProcessor$ImportEntryProcessRunnable.run(ImportEntryProcessor.java:370)
    at java.base/java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:515)
    at java.base/java.util.concurrent.FutureTask.run(FutureTask.java:264)
    at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1128)
    at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:628)
    at java.base/java.lang.Thread.run(Thread.java:829)


This is due to the fact that the terminal uses 2 seq number at a time. In the JSON, we can see that :
The tickets are declared from the first terminal with one of the last seqno of the terminal 2
Steps To ReproducePrerequisite : having 2 terminals from the same organisation using the french fiscal (with the hashcode and so on... full configuration done)

- Open terminal 1
- Make a sale, pay it and finalize it

- Open terminal 2
- Open the sale from the terminal 1
- Make a cancel & replace
- Validate it

Proposed SolutionFix the seqno and maybe the "posTerminal$_identifier"
TagsNo tags attached.
Attached Files

- Relationships [ Relation Graph ] [ Dependency Graph ]
blocks defect 0057385 closedaferraz French fiscal : Cancel & replace makes EWI 

-  Notes
(0173177)
hgbot (developer)
2024-12-11 13:15

 Merge Request created: https://gitlab.com/openbravo/product/openbravo/-/merge_requests/1471 [^]
(0173178)
hgbot (developer)
2024-12-11 13:44

 Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.certification.france/-/merge_requests/21 [^]
(0173216)
hgbot (developer)
2024-12-12 09:14

 Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/openbravo [^]
Changeset: 725b567d79f1651ddb9011d7e73252e32177f274
Author: Álvaro Ferraz <alvaro.ferraz@openbravo.com>
Date: 11-12-2024 13:14:19
URL: https://gitlab.com/openbravo/product/openbravo/-/commit/725b567d79f1651ddb9011d7e73252e32177f274 [^]

Fixes ISSUE-57424: Be able to define priority in CancelAndReplaceOrder hooks

---
M src/org/openbravo/erpCommon/businessUtility/CancelAndReplaceOrderHook.java
M src/org/openbravo/erpCommon/businessUtility/CancelAndReplaceOrderHookCaller.java
---
(0173217)
hgbot (developer)
2024-12-12 09:14

 Merge request merged: https://gitlab.com/openbravo/product/openbravo/-/merge_requests/1471 [^]
(0173222)
hgbot (developer)
2024-12-12 09:18

 Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.certification.france [^]
Changeset: d5ad597a1de87474a7086be7fc755a86e878712d
Author: Álvaro Ferraz <a.ferraz@orisha.com>
Date: 12-12-2024 08:18:53
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.certification.france/-/commit/d5ad597a1de87474a7086be7fc755a86e878712d [^]

Fixes ISSUE-57424: TicketCancelReplaceHook should run after CancelAndReplaceHook

---
M src/org/openbravo/certification/france/ticket/TicketCancelReplaceHook.java
---
(0173223)
hgbot (developer)
2024-12-12 09:18

 Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.certification.france/-/merge_requests/21 [^]

- Issue History
Date Modified Username Field Change
2024-12-11 12:00 aferraz Type defect => backport
2024-12-11 12:00 aferraz Target Version => 24Q4.1
2024-12-11 13:15 hgbot Note Added: 0173177
2024-12-11 13:44 hgbot Note Added: 0173178
2024-12-12 09:14 hgbot Resolution open => fixed
2024-12-12 09:14 hgbot Status scheduled => closed
2024-12-12 09:14 hgbot Fixed in Version => PR24Q4.1
2024-12-12 09:14 hgbot Note Added: 0173216
2024-12-12 09:14 hgbot Note Added: 0173217
2024-12-12 09:18 hgbot Note Added: 0173222
2024-12-12 09:18 hgbot Note Added: 0173223

Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker