Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue Details[ Jump to Notes ] [ Issue History ] [ Print ]
ID
0057385
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[POS2] POScriticalalways2024-12-09 11:182024-12-12 09:16
ReporterwicherrView Statuspublic 
Assigned Toaferraz 
PriorityurgentResolutionfixedFixed in Version
StatusclosedFix in branchFixed in SCM revision
ProjectionnoneETAnoneTarget Version
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Review Assigned To
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0057385: French fiscal : Cancel & replace makes EWI

DescriptionWhen you do a cancel & replace of a ticket made from another till, an EWI is created :
org.openbravo.base.util.CheckException: Triggers were not disabled in this session, call disable before calling this method
    at org.openbravo.base.util.Check.isNotNull(Check.java:72)
    at org.openbravo.dal.core.TriggerHandler.enable(TriggerHandler.java:89)
    at org.openbravo.retail.posterminal.OrderLoader.saveRecord(OrderLoader.java:626)
    at org.openbravo.mobile.core.process.DataSynchronizationProcess.saveRecord(DataSynchronizationProcess.java:214)
    at org.openbravo.mobile.core.process.DataSynchronizationProcess.exec(DataSynchronizationProcess.java:165)
    at org.openbravo.mobile.core.process.DataSynchronizationProcess.exec(DataSynchronizationProcess.java:97)
    at org.openbravo.mobile.core.process.MobileImportEntryProcessorRunnable.processEntry(MobileImportEntryProcessorRunnable.java:55)
    at org.openbravo.retail.posterminal.importprocess.OrderImportEntryProcessor$OrderLoaderRunnable.processEntry(OrderImportEntryProcessor.java:64)
    at org.openbravo.service.importprocess.ImportEntryProcessor$ImportEntryProcessRunnable.doRunCycle(ImportEntryProcessor.java:447)
    at org.openbravo.service.importprocess.ImportEntryProcessor$ImportEntryProcessRunnable.run(ImportEntryProcessor.java:370)
    at java.base/java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:515)
    at java.base/java.util.concurrent.FutureTask.run(FutureTask.java:264)
    at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1128)
    at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:628)
    at java.base/java.lang.Thread.run(Thread.java:829)


This is due to the fact that the terminal uses 2 seq number at a time. In the JSON, we can see that :
The tickets are declared from the first terminal with one of the last seqno of the terminal 2
Steps To ReproducePrerequisite : having 2 terminals from the same organisation using the french fiscal (with the hashcode and so on... full configuration done)

- Open terminal 1
- Make a sale, pay it and finalize it

- Open terminal 2
- Open the sale from the terminal 1
- Make a cancel & replace
- Validate it

Proposed SolutionFix the seqno and maybe the "posTerminal$_identifier"
TagsNOZ
Attached Files

- Relationships [ Relation Graph ] [ Dependency Graph ]
depends on backport 005742424Q4.1 closedaferraz French fiscal : Cancel & replace makes EWI 

-  Notes
(0173170)
hgbot (developer)
2024-12-11 11:14

 Merge Request created: https://gitlab.com/openbravo/product/openbravo/-/merge_requests/1470 [^]
(0173173)
hgbot (developer)
2024-12-11 11:20

 Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.certification.france/-/merge_requests/20 [^]
(0173218)
hgbot (developer)
2024-12-12 09:14

 Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/openbravo [^]
Changeset: 043ca8f4632a1c450612c5c241bb99e02eb18014
Author: Álvaro Ferraz <alvaro.ferraz@openbravo.com>
Date: 11-12-2024 11:52:56
URL: https://gitlab.com/openbravo/product/openbravo/-/commit/043ca8f4632a1c450612c5c241bb99e02eb18014 [^]

Fixes ISSUE-57385: Be able to define priority in CancelAndReplaceOrder hooks

---
M src/org/openbravo/erpCommon/businessUtility/CancelAndReplaceOrderHook.java
M src/org/openbravo/erpCommon/businessUtility/CancelAndReplaceOrderHookCaller.java
---
(0173219)
hgbot (developer)
2024-12-12 09:14

 Merge request merged: https://gitlab.com/openbravo/product/openbravo/-/merge_requests/1470 [^]
(0173220)
hgbot (developer)
2024-12-12 09:16

 Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.certification.france/-/merge_requests/20 [^]
(0173221)
hgbot (developer)
2024-12-12 09:16

 Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.certification.france [^]
Changeset: 672efe5a4a0425a41e13e3b2dfe22218ea24f0f8
Author: Álvaro Ferraz <a.ferraz@orisha.com>
Date: 12-12-2024 08:16:19
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.certification.france/-/commit/672efe5a4a0425a41e13e3b2dfe22218ea24f0f8 [^]

Fixes ISSUE-57385: TicketCancelReplaceHook should run after CancelAndReplaceHook

---
M src/org/openbravo/certification/france/ticket/TicketCancelReplaceHook.java
---

- Issue History
Date Modified Username Field Change
2024-12-09 11:18 wicherr New Issue
2024-12-09 11:18 wicherr Tag Attached: NOZ
2024-12-09 12:00 javietxe Issue Monitored: javietxe
2024-12-09 12:44 aferraz Assigned To => aferraz
2024-12-11 11:14 hgbot Note Added: 0173170
2024-12-11 11:20 hgbot Note Added: 0173173
2024-12-11 11:59 aferraz Project Openbravo Localizations => POS2
2024-12-11 11:59 aferraz Triggers an Emergency Pack => No
2024-12-11 11:59 aferraz Category Localization France => POS
2024-12-11 12:00 aferraz Status new => scheduled
2024-12-12 09:14 hgbot Resolution open => fixed
2024-12-12 09:14 hgbot Status scheduled => closed
2024-12-12 09:14 hgbot Fixed in Version => PR25Q1
2024-12-12 09:14 hgbot Note Added: 0173218
2024-12-12 09:14 hgbot Note Added: 0173219
2024-12-12 09:16 hgbot Note Added: 0173220
2024-12-12 09:16 hgbot Note Added: 0173221

Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker