0057424: French fiscal : Cancel & replace makes EWI

Openbravo Issue Tracking System - POS2

View Issue Details

Project

Category

View Status

Date Submitted

Last Update

0057424

POS2

POS

public

2024-12-09 11:18

2024-12-12 09:18

Reporter

wicherr

Assigned To

aferraz

Priority

urgent

Severity

critical

Reproducibility

always

Status

closed

Resolution

fixed

Platform

OS Version

Product Version

Target Version

24Q4.1

Fixed in Version

Merge Request Status

Review Assigned To

OBNetwork customer

Support ticket

Regression level

Regression date

Regression introduced in release

Regression introduced by commit

Triggers an Emergency Pack

Summary

0057424: French fiscal : Cancel & replace makes EWI

Description

When you do a cancel & replace of a ticket made from another till, an EWI is created :
org.openbravo.base.util.CheckException: Triggers were not disabled in this session, call disable before calling this method
    at org.openbravo.base.util.Check.isNotNull(Check.java:72)
    at org.openbravo.dal.core.TriggerHandler.enable(TriggerHandler.java:89)
    at org.openbravo.retail.posterminal.OrderLoader.saveRecord(OrderLoader.java:626)
    at org.openbravo.mobile.core.process.DataSynchronizationProcess.saveRecord(DataSynchronizationProcess.java:214)
    at org.openbravo.mobile.core.process.DataSynchronizationProcess.exec(DataSynchronizationProcess.java:165)
    at org.openbravo.mobile.core.process.DataSynchronizationProcess.exec(DataSynchronizationProcess.java:97)
    at org.openbravo.mobile.core.process.MobileImportEntryProcessorRunnable.processEntry(MobileImportEntryProcessorRunnable.java:55)
    at org.openbravo.retail.posterminal.importprocess.OrderImportEntryProcessor$OrderLoaderRunnable.processEntry(OrderImportEntryProcessor.java:64)
    at org.openbravo.service.importprocess.ImportEntryProcessor$ImportEntryProcessRunnable.doRunCycle(ImportEntryProcessor.java:447)
    at org.openbravo.service.importprocess.ImportEntryProcessor$ImportEntryProcessRunnable.run(ImportEntryProcessor.java:370)
    at java.base/java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:515)
    at java.base/java.util.concurrent.FutureTask.run(FutureTask.java:264)
    at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1128)
    at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:628)
    at java.base/java.lang.Thread.run(Thread.java:829)

This is due to the fact that the terminal uses 2 seq number at a time. In the JSON, we can see that :
The tickets are declared from the first terminal with one of the last seqno of the terminal 2

Steps To Reproduce

Prerequisite : having 2 terminals from the same organisation using the french fiscal (with the hashcode and so on... full configuration done)

- Open terminal 1
- Make a sale, pay it and finalize it

- Open terminal 2
- Open the sale from the terminal 1
- Make a cancel & replace
- Validate it

Proposed Solution

Fix the seqno and maybe the "posTerminal$_identifier"

Additional Information