Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue Details[ Jump to Notes ] [ Issue History ] [ Print ]
ID
0056380
TypeCategorySeverityReproducibilityDate SubmittedLast Update
backport[POS2] POSminoralways2024-09-03 08:102024-09-16 10:19
ReportermigueldejuanaView Statuspublic 
Assigned Tosreehari 
PrioritynormalResolutionfixedFixed in Version
StatusclosedFix in branchFixed in SCM revision
ProjectionnoneETAnoneTarget Version24Q3.1
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Review Assigned To
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0056380: External Orders API

DescriptionWhen building the request for External Orders we do not define a proper request data in some tipe of actions.

SEARCH and LOAD actions send a request with a wrong structure having data inside data:

data: {
  data: {
    ...
  }
}

We should only have one data instead of 2 nested datas.
We can take COMMIT action as example.
Steps To Reproduce- In Organization check "Enable External Orders"
- In External System window, create a new onw with Protocol "Javascript - Frontend" and set JS Class Name to "OB.EXOTEST.ExternalOrdersSimulator"
- Create an Event Subscription of type "External Event Order" and select created External System
- Login in POS2 and got to option menu External Orders
- In the filter write "00"
- SEARCH action is launched and we can see in the console the request sent with data nested
- Click on one row and - LOAD action is launched and we can see in the console the request sent with data nested
- Complete the ticket and - COMMIT action is launched and we can see in the console the request sent WITHOUT data nested
Proposed SolutionWe have to send the request without nested data and change External Simulator to adapt it to the new structure
TagsNo tags attached.
Attached Files

- Relationships [ Relation Graph ] [ Dependency Graph ]
blocks defect 0056345 scheduledsreehari External Orders API 

-  Notes
(0168881)
hgbot (developer)
2024-09-06 17:33

 Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.events.orders/-/merge_requests/8 [^]
(0169225)
hgbot (developer)
2024-09-16 10:19

 Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.events.orders [^]
Changeset: 18788c04edb2f85d7f6e221f0c1c611a7153744b
Author: Sreehari Venkataraman <s.venkataraman@external.orisha.com>
Date: 16-09-2024 08:19:39
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.events.orders/-/commit/18788c04edb2f85d7f6e221f0c1c611a7153744b [^]

Fixes ISSUE-56380: Removed nested data object request

---
M web-jspack/org.openbravo.events.orders/src/components/ExternalOrders/ExternalOrdersGrid/GetExternalOrdersList.js
M web-jspack/org.openbravo.events.orders/src/components/ExternalOrders/ExternalOrdersGrid/GetExternalOrdersTicket.js
M web/org.openbravo.events.orders/app/model/business-object/simulator/ExternalOrdersSimulator.js
---
(0169226)
hgbot (developer)
2024-09-16 10:19

 Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.events.orders/-/merge_requests/8 [^]

- Issue History
Date Modified Username Field Change
2024-09-05 15:39 sreehari Type defect => backport
2024-09-05 15:39 sreehari Target Version => 24Q3.1
2024-09-06 17:33 hgbot Note Added: 0168881
2024-09-16 10:19 hgbot Resolution open => fixed
2024-09-16 10:19 hgbot Status scheduled => closed
2024-09-16 10:19 hgbot Note Added: 0169225
2024-09-16 10:19 hgbot Note Added: 0169226

Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker