Openbravo Issue Tracking System - POS2
View Issue Details
0056380POS2POSpublic2024-09-03 08:102024-09-16 10:19
migueldejuana 
sreehari 
normalminoralways
closedfixed 
5
 
24Q3.1 
No
0056380: External Orders API
When building the request for External Orders we do not define a proper request data in some tipe of actions.

SEARCH and LOAD actions send a request with a wrong structure having data inside data:

data: {
  data: {
    ...
  }
}

We should only have one data instead of 2 nested datas.
We can take COMMIT action as example.
- In Organization check "Enable External Orders"
- In External System window, create a new onw with Protocol "Javascript - Frontend" and set JS Class Name to "OB.EXOTEST.ExternalOrdersSimulator"
- Create an Event Subscription of type "External Event Order" and select created External System
- Login in POS2 and got to option menu External Orders
- In the filter write "00"
- SEARCH action is launched and we can see in the console the request sent with data nested
- Click on one row and - LOAD action is launched and we can see in the console the request sent with data nested
- Complete the ticket and - COMMIT action is launched and we can see in the console the request sent WITHOUT data nested
We have to send the request without nested data and change External Simulator to adapt it to the new structure
No tags attached.
blocks defect 0056345 scheduled sreehari External Orders API 
Issue History
2024-09-05 15:39sreehariTypedefect => backport
2024-09-05 15:39sreehariTarget Version => 24Q3.1
2024-09-06 17:33hgbotNote Added: 0168881
2024-09-16 10:19hgbotResolutionopen => fixed
2024-09-16 10:19hgbotStatusscheduled => closed
2024-09-16 10:19hgbotNote Added: 0169225
2024-09-16 10:19hgbotNote Added: 0169226

Notes
(0168881)
hgbot   
2024-09-06 17:33   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.events.orders/-/merge_requests/8 [^]
(0169225)
hgbot   
2024-09-16 10:19   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.events.orders [^]
Changeset: 18788c04edb2f85d7f6e221f0c1c611a7153744b
Author: Sreehari Venkataraman <s.venkataraman@external.orisha.com>
Date: 16-09-2024 08:19:39
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.events.orders/-/commit/18788c04edb2f85d7f6e221f0c1c611a7153744b [^]

Fixes ISSUE-56380: Removed nested data object request

---
M web-jspack/org.openbravo.events.orders/src/components/ExternalOrders/ExternalOrdersGrid/GetExternalOrdersList.js
M web-jspack/org.openbravo.events.orders/src/components/ExternalOrders/ExternalOrdersGrid/GetExternalOrdersTicket.js
M web/org.openbravo.events.orders/app/model/business-object/simulator/ExternalOrdersSimulator.js
---
(0169226)
hgbot   
2024-09-16 10:19   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.events.orders/-/merge_requests/8 [^]