0055669: Spread payment for all tills is not working

Description

Spread Payment Method does not work between Touchpoint Types when they are created at * Organization.
When creating a Touchpoint Type Payment Method cloning from one created with org*, it fails with a NPE.

[http-nio-127.0.0.1-8080-exec-6] ERROR org.openbravo.copyprocess.process.CopyEntityProcess - null
java.lang.NullPointerException: null
    at org.openbravo.retail.copystore.process.DefaultPropertiesHandler$TerminalPaymentTypeProperties$TerminalPaymentTypeCurrencyProperty.handleProperty(DefaultPropertiesHandler.java:1057) ~[classes/:?]
    at org.openbravo.copyprocess.process.CopyEntityProcess.processProperty(CopyEntityProcess.java:626) [classes/:?]
    at org.openbravo.copyprocess.process.CopyEntityProcess.cloneObject(CopyEntityProcess.java:220) [classes/:?]
    at org.openbravo.retail.copystore.process.CopyPaymentMethodProcess.createNewTerminalTypePaymentMethod(CopyPaymentMethodProcess.java:262) ~[classes/:?]

Steps To Reproduce

Ensure you have a touchpoint associated with a touchpoint type created at * level.

- Create a new payment method in that touchpoint
- Click "Spread payment for selected tills"
- Select a different touchpoint type

It fails without an error message

Proposed Solution

When trying to copy the payment method to a new Touchpoint Type, a new Touchpoint Type Payment Method needs to be created. As the original one is created at * org, that org does not have a currency, and a currency validation fails.

The process needs to be updated, considering touchpoint types can be created at *.

https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.copystore/-/blob/master/src/org/openbravo/retail/copystore/process/DefaultPropertiesHandler.java?ref_type=heads#L1057 [^]

Tags

No tags attached.

Attached Files

Relationships [ Relation Graph ] [ Dependency Graph ]

blocks

defect

0055625

closed

sreehari

Spread payment for all tills is not working

Notes
(0165534) hgbot (developer) 2024-06-04 14:02	Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.copystore/-/merge_requests/74 [^]

(0165575) hgbot (developer) 2024-06-05 07:20	Directly closing issue as related merge request is already approved. Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.copystore [^] Changeset: 326b3a5c8b2bcde115b1cf02331912f2471a931d Author: Sreehari Venkataraman <sreehari.venkataraman.ext@openbravo.com> Date: 04-06-2024 17:30:47 URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.copystore/-/commit/326b3a5c8b2bcde115b1cf02331912f2471a931d [^] Fixes ISSUE-55669: Added null validation, now payment currency is set --- M src/org/openbravo/retail/copystore/process/DefaultPropertiesHandler.java ---

(0165576) hgbot (developer) 2024-06-05 07:20	Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.copystore/-/merge_requests/74 [^]

Issue History
Date Modified	Username	Field	Change
2024-06-04 12:54	sreehari	Type	defect => backport
2024-06-04 12:54	sreehari	Target Version	=> RR24Q2
2024-06-04 14:02	hgbot	Note Added: 0165534
2024-06-05 07:20	hgbot	Resolution	open => fixed
2024-06-05 07:20	hgbot	Status	scheduled => closed
2024-06-05 07:20	hgbot	Note Added: 0165575
2024-06-05 07:20	hgbot	Note Added: 0165576