0055669: Spread payment for all tills is not working

Openbravo Issue Tracking System - Retail Modules

View Issue Details

Project

Category

View Status

Date Submitted

Last Update

0055669

Retail Modules

Copy Retail Store

public

2024-05-30 12:39

2024-06-05 07:20

Reporter

martinsdan

Assigned To

sreehari

Priority

normal

Severity

minor

Reproducibility

always

Status

closed

Resolution

fixed

Platform

OS Version

Ubuntu 18.04.1 LTS

Product Version

Target Version

RR24Q2

Fixed in Version

Merge Request Status

approved

Review Assigned To

OBNetwork customer

OBPS

Support ticket

Regression level

Packaging and release

Regression date

2024-03-20

Regression introduced in release

Regression introduced by commit

https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.copystore/-/commit/049be8553b7975a7cf5486a4987feceaf914225f [^]

Triggers an Emergency Pack

Summary

0055669: Spread payment for all tills is not working

Description

Spread Payment Method does not work between Touchpoint Types when they are created at * Organization.
When creating a Touchpoint Type Payment Method cloning from one created with org*, it fails with a NPE.

[http-nio-127.0.0.1-8080-exec-6] ERROR org.openbravo.copyprocess.process.CopyEntityProcess - null
java.lang.NullPointerException: null
    at org.openbravo.retail.copystore.process.DefaultPropertiesHandler$TerminalPaymentTypeProperties$TerminalPaymentTypeCurrencyProperty.handleProperty(DefaultPropertiesHandler.java:1057) ~[classes/:?]
    at org.openbravo.copyprocess.process.CopyEntityProcess.processProperty(CopyEntityProcess.java:626) [classes/:?]
    at org.openbravo.copyprocess.process.CopyEntityProcess.cloneObject(CopyEntityProcess.java:220) [classes/:?]
    at org.openbravo.retail.copystore.process.CopyPaymentMethodProcess.createNewTerminalTypePaymentMethod(CopyPaymentMethodProcess.java:262) ~[classes/:?]

Steps To Reproduce

Ensure you have a touchpoint associated with a touchpoint type created at * level.

- Create a new payment method in that touchpoint
- Click "Spread payment for selected tills"
- Select a different touchpoint type

It fails without an error message

Proposed Solution

When trying to copy the payment method to a new Touchpoint Type, a new Touchpoint Type Payment Method needs to be created. As the original one is created at * org, that org does not have a currency, and a currency validation fails.

The process needs to be updated, considering touchpoint types can be created at *.

https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.copystore/-/blob/master/src/org/openbravo/retail/copystore/process/DefaultPropertiesHandler.java?ref_type=heads#L1057 [^]

Additional Information