0052385: RM-6259: Pager on order level gives javascript error when moving to payment step

Description

When doing pager on order level and paying a js error is thrown.

https://openbravo.atlassian.net/browse/RM-6259 [^]

Steps To Reproduce

1) Setup a pager delivery control method and enforce order consolidation.
2) Add a product to the ticket with pager control method
3) Click pay --> it should ask for pager information but instead gives this [1] js error.

[1]
caught (in promise) TypeError: Cannot read properties of undefined (reading 'some')
    at hasMenuItems (DCMConfigurationExtensions.js:37:1)
    at selector (DCMConfigurationExtensions.js:20:1)
    at getFinishStepUserAction (DeliveryControlMethodConfiguration.js:193:1)
    at buildDCMConfiguration (DeliveryControlMethodConfiguration.js:153:1)
    at buildConfiguration (DeliveryControlMethodConfigurationPanel.jsx:23:1)
    at DeliveryControlMethodConfigurationPanel.jsx:30:1
    at invokePassiveEffectCreate (react-dom.development.js:23487:1)
    at HTMLUnknownElement.callCallback (react-dom.development.js:3945:1)
    at Object.invokeGuardedCallbackDev (react-dom.development.js:3994:1)
    at invokeGuardedCallback (react-dom.development.js:4056:1)
    at flushPassiveEffectsImpl (react-dom.development.js:23574:1)
    at unstable_runWithPriority (scheduler.development.js:468:1)
    at runWithPriority$1 (react-dom.development.js:11276:1)
    at flushPassiveEffects (react-dom.development.js:23447:1)
    at performSyncWorkOnRoot (react-dom.development.js:22269:1)
    at react-dom.development.js:11327:1
    at unstable_runWithPriority (scheduler.development.js:468:1)
    at runWithPriority$1 (react-dom.development.js:11276:1)
    at flushSyncCallbackQueueImpl (react-dom.development.js:11322:1)
    at flushSyncCallbackQueue (react-dom.development.js:11309:1)
    at batchedUpdates$1 (react-dom.development.js:22387:1)
    at Object.notify (Subscription.js:19:1)
    at Subscription.notifyNestedSubs (Subscription.js:90:1)
    at Subscription.handleChangeWrapper (Subscription.js:95:1)
    at Object.dispatch (redux.js:222:1)
    at StatePersistence.dispatch (POS2.js:6062:1)

Proposed Solution

Ask for pager information when paying, without encurring an error

Tags

No tags attached.

Attached Files

Relationships [ Relation Graph ] [ Dependency Graph ]

depends on	backport	0052386	23Q2	closed	mtaal	Pager on order level gives javascript error when moving to payment step
depends on	backport	0052387	23Q1.3	closed	mtaal	Pager on order level gives javascript error when moving to payment step

Notes
(0149445) hgbot (developer) 2023-05-08 17:26	Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/merge_requests/1768 [^]

(0149451) hgbot (developer) 2023-05-08 23:57	Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/merge_requests/1768 [^]

(0149452) hgbot (developer) 2023-05-08 23:57	Directly closing issue as related merge request is already approved. Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2 [^] Changeset: 1268360973a11961f1fe1cdce8c9e13f11605e3f Author: Martin Taal <martin.taal@openbravo.com> Date: 08-05-2023 21:57:03 URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/commit/1268360973a11961f1fe1cdce8c9e13f11605e3f [^] Fixes ISSUE-52385: pass ticket lines in payload to be used in pager configuration step --- M web-jspack/org.openbravo.pos2/src/core/pickupPoint/deliveryControl/pager/PagerDeliveryControlMethod.js ---

Issue History
Date Modified	Username	Field	Change
2023-05-08 17:20	mtaal	New Issue
2023-05-08 17:20	mtaal	Assigned To	=> mtaal
2023-05-08 17:20	mtaal	OBNetwork customer	=> No
2023-05-08 17:20	mtaal	Triggers an Emergency Pack	=> No
2023-05-08 17:22	mtaal	Steps to Reproduce Updated	View Revisions
2023-05-08 17:26	hgbot	Merge Request Status	=> open
2023-05-08 17:26	hgbot	Note Added: 0149445
2023-05-08 17:29	nicola_uva	Status	new => scheduled
2023-05-08 17:43	mtaal	Summary	Pager on order level gives javascript error when moving to payment step => RM-6259: Pager on order level gives javascript error when moving to payment step
2023-05-08 17:43	mtaal	Description Updated	View Revisions
2023-05-08 18:26	hgbot	Merge Request Status	open => approved
2023-05-08 23:57	hgbot	Resolution	open => fixed
2023-05-08 23:57	hgbot	Status	scheduled => closed
2023-05-08 23:57	hgbot	Note Added: 0149451
2023-05-08 23:57	hgbot	Fixed in Version	=> 23Q3
2023-05-08 23:57	hgbot	Note Added: 0149452