Openbravo Issue Tracking System - POS2
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0052385POS2POSpublic2023-05-08 17:202023-05-08 23:57
Reportermtaal 
Assigned Tomtaal 
PrioritynormalSeveritymajorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version23Q3 
Merge Request Statusapproved
Review Assigned To
OBNetwork customerNo
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0052385: RM-6259: Pager on order level gives javascript error when moving to payment step
DescriptionWhen doing pager on order level and paying a js error is thrown.

https://openbravo.atlassian.net/browse/RM-6259 [^]
Steps To Reproduce1) Setup a pager delivery control method and enforce order consolidation.
2) Add a product to the ticket with pager control method
3) Click pay --> it should ask for pager information but instead gives this [1] js error.


[1]
caught (in promise) TypeError: Cannot read properties of undefined (reading 'some')
    at hasMenuItems (DCMConfigurationExtensions.js:37:1)
    at selector (DCMConfigurationExtensions.js:20:1)
    at getFinishStepUserAction (DeliveryControlMethodConfiguration.js:193:1)
    at buildDCMConfiguration (DeliveryControlMethodConfiguration.js:153:1)
    at buildConfiguration (DeliveryControlMethodConfigurationPanel.jsx:23:1)
    at DeliveryControlMethodConfigurationPanel.jsx:30:1
    at invokePassiveEffectCreate (react-dom.development.js:23487:1)
    at HTMLUnknownElement.callCallback (react-dom.development.js:3945:1)
    at Object.invokeGuardedCallbackDev (react-dom.development.js:3994:1)
    at invokeGuardedCallback (react-dom.development.js:4056:1)
    at flushPassiveEffectsImpl (react-dom.development.js:23574:1)
    at unstable_runWithPriority (scheduler.development.js:468:1)
    at runWithPriority$1 (react-dom.development.js:11276:1)
    at flushPassiveEffects (react-dom.development.js:23447:1)
    at performSyncWorkOnRoot (react-dom.development.js:22269:1)
    at react-dom.development.js:11327:1
    at unstable_runWithPriority (scheduler.development.js:468:1)
    at runWithPriority$1 (react-dom.development.js:11276:1)
    at flushSyncCallbackQueueImpl (react-dom.development.js:11322:1)
    at flushSyncCallbackQueue (react-dom.development.js:11309:1)
    at batchedUpdates$1 (react-dom.development.js:22387:1)
    at Object.notify (Subscription.js:19:1)
    at Subscription.notifyNestedSubs (Subscription.js:90:1)
    at Subscription.handleChangeWrapper (Subscription.js:95:1)
    at Object.dispatch (redux.js:222:1)
    at StatePersistence.dispatch (POS2.js:6062:1)
 
Proposed SolutionAsk for pager information when paying, without encurring an error
Additional Information
TagsNo tags attached.
Relationships
depends on backport 005238623Q2 closed mtaal Pager on order level gives javascript error when moving to payment step 
depends on backport 005238723Q1.3 closed mtaal Pager on order level gives javascript error when moving to payment step 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2023-05-08 17:20mtaalNew Issue
2023-05-08 17:20mtaalAssigned To => mtaal
2023-05-08 17:20mtaalOBNetwork customer => No
2023-05-08 17:20mtaalTriggers an Emergency Pack => No
2023-05-08 17:22mtaalSteps to Reproduce Updatedbug_revision_view_page.php?rev_id=26029#r26029
2023-05-08 17:26hgbotMerge Request Status => open
2023-05-08 17:26hgbotNote Added: 0149445
2023-05-08 17:29nicola_uvaStatusnew => scheduled
2023-05-08 17:43mtaalSummaryPager on order level gives javascript error when moving to payment step => RM-6259: Pager on order level gives javascript error when moving to payment step
2023-05-08 17:43mtaalDescription Updatedbug_revision_view_page.php?rev_id=26031#r26031
2023-05-08 18:26hgbotMerge Request Statusopen => approved
2023-05-08 23:57hgbotResolutionopen => fixed
2023-05-08 23:57hgbotStatusscheduled => closed
2023-05-08 23:57hgbotNote Added: 0149451
2023-05-08 23:57hgbotFixed in Version => 23Q3
2023-05-08 23:57hgbotNote Added: 0149452

Notes
(0149445)
hgbot   
2023-05-08 17:26   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/merge_requests/1768 [^]
(0149451)
hgbot   
2023-05-08 23:57   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/merge_requests/1768 [^]
(0149452)
hgbot   
2023-05-08 23:57   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2 [^]
Changeset: 1268360973a11961f1fe1cdce8c9e13f11605e3f
Author: Martin Taal <martin.taal@openbravo.com>
Date: 08-05-2023 21:57:03
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/commit/1268360973a11961f1fe1cdce8c9e13f11605e3f [^]

Fixes ISSUE-52385: pass ticket lines in payload to be used in pager configuration step

---
M web-jspack/org.openbravo.pos2/src/core/pickupPoint/deliveryControl/pager/PagerDeliveryControlMethod.js
---