Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue Details[ Jump to Notes ] [ Issue History ] [ Print ]
ID
0052142
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[Modules] Discounts Engine for Backendmajoralways2023-04-17 17:592023-05-22 13:22
ReportersofidossantView Statuspublic 
Assigned Toradhakrishnan 
PriorityhighResolutionfixedFixed in Version
StatusclosedFix in branchFixed in SCM revision
ProjectionnoneETAnoneTarget Version
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Merge Request Statusapproved
Regression date
Regression introduced by commit
Regression level
Review Assigned To
Support ticket61125
OBNetwork customerGold
Regression introduced in release
Summary

0052142: When a Combo discount is used, it is not filtered if the family is active.

DescriptionWhen a Combo type discount is used, it is not filtered if the family is active.
In other words, it always takes into account the families, even if the family is deactivated.

attached video with example
Steps To ReproduceExample:
{
  "ticket": {
    "id":"79797C77BD274CEBBC4BE58037AB147B",
    "organization": {
 "id": "D270A5AC50874F8BA67A88EE977F8E3B",
                      "_identifier": "Vall Blanca Store"
                          },
    "businessPartner": {
                      "id": "ABD91C9D3BC94175B876FBBE9CACA008",
                      "_identifier": "VBS Customer"
    },
    "orderDate": "2023-03-20T11:54:21",
    "priceIncludesTax": true,
    "discountsFromUser": {},
    "lines": [
      {
        "id": "1",
        "product": {
                      "id": "DEC20EABF33944BA967E24EFF8C244B3",
                      "_identifier": "Torch CB1"
                              },
        "qty": 2,
        "baseGrossUnitPrice": 100
      },
      {
        "id": "2",
        "product": {
                      "id": "D10E6131DA8144BE91CC0B4D8891A6D1",
                      "_identifier": "Backpack CB1 25l"
        },
        "qty": 1,
        "baseGrossUnitPrice": 50
      }
    ]
  }
}

https://livebuilds.openbravo.com/retail_modules_pgsql_pi/?tabId=800079&recordId=7C0E1EEE5EC24BD99890A2A26D0D9181 [^]
TagsNo tags attached.
Attached Files? file icon Videograbación 2023-04-17 13:01:59.mp4 [^] (2,583,217 bytes) 2023-04-17 18:02

- Relationships [ Relation Graph ] [ Dependency Graph ]
related to defect 0052296 closedradhakrishnan The api always returns the same result without checking if the filters are disabled. 

-  Notes
(0148876)
hgbot (developer)
2023-04-26 03:47

 Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.discounts.combo/-/merge_requests/28 [^]
(0149298)
sofidossant (viewer)
2023-05-04 13:22

 Any news?
(0149444)
hgbot (developer)
2023-05-08 17:00

 Merge request closed: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.discounts.combo/-/merge_requests/28 [^]
(0149493)
hgbot (developer)
2023-05-09 13:32

 Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.discounts.combo/-/merge_requests/31 [^]
(0149545)
hgbot (developer)
2023-05-10 09:58

 Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.discounts.combo [^]
Changeset: 100f7b8e5ff71de63cd422197ab55c83f9b3ef85
Author: Radhakrishnan Seeman <radhakrishnan@qualiantech.com>
Date: 10-05-2023 07:58:34
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.discounts.combo/-/commit/100f7b8e5ff71de63cd422197ab55c83f9b3ef85 [^]

Fixed ISSUE-52142: Combo family should not be added when it's in inactive

---
M src/org/openbravo/retail/discounts/combo/ComboDataHook.java
---
(0149546)
hgbot (developer)
2023-05-10 09:58

 Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.discounts.combo/-/merge_requests/31 [^]
(0149638)
hgbot (developer)
2023-05-12 04:32

 Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.discounts.combo [^]
Changeset: 6029d12ad8e86842f3739ce324448eb5efd9ab1a
Author: Ranjith S R <ranjith@qualiantech.com>
Date: 12-05-2023 08:00:57
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.discounts.combo/-/commit/6029d12ad8e86842f3739ce324448eb5efd9ab1a [^]

Revert "Fixed ISSUE-52142: Combo family should not be added when it's in inactive"

This reverts commit 100f7b8e5ff71de63cd422197ab55c83f9b3ef85.

---
M src/org/openbravo/retail/discounts/combo/ComboDataHook.java
---
(0149655)
ranjith_qualiantech_com (viewer)
2023-05-12 11:00

 Changes reverted due to junit test failed in CI
(0149702)
sofidossant (viewer)
2023-05-15 14:16

 Any comments?
(0149725)
hgbot (developer)
2023-05-16 08:09

 Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.discounts.combo/-/merge_requests/32 [^]
(0149754)
hgbot (developer)
2023-05-16 09:08

 Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.discounts.combo/-/merge_requests/32 [^]
(0149755)
hgbot (developer)
2023-05-16 09:08

 Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.discounts.combo [^]
Changeset: 98a0545aa80b0eba1d5041d51521251fa6221166
Author: Radhakrishnan Seeman <radhakrishnan@qualiantech.com>
Date: 15-05-2023 16:49:54
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.discounts.combo/-/commit/98a0545aa80b0eba1d5041d51521251fa6221166 [^]

Fixed ISSUE-52142: Combo family should not be added when it's in inactive

---
M src/org/openbravo/retail/discounts/combo/ComboDataHook.java
---
(0150060)
hgbot (developer)
2023-05-22 13:22

 Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.discounts.combo [^]
Changeset: c35e8532e63a223b69946f21576cf55be366b1e2
Author: Álvaro Ferraz <alvaro.ferraz@openbravo.com>
Date: 22-05-2023 13:22:17
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.discounts.combo/-/commit/c35e8532e63a223b69946f21576cf55be366b1e2 [^]

Related to ISSUE-52142: Make functions private instead of public

---
M src/org/openbravo/retail/discounts/combo/ComboDataHook.java
---

- Issue History
Date Modified Username Field Change
2023-04-17 17:59 sofidossant New Issue
2023-04-17 17:59 sofidossant Assigned To => Triage Omni OMS
2023-04-17 17:59 sofidossant Support ticket => 61125
2023-04-17 17:59 sofidossant OBNetwork customer => Gold
2023-04-17 18:02 sofidossant File Added: Videograbación 2023-04-17 13:01:59.mp4
2023-04-24 15:23 francisco_ofarril Assigned To Triage Omni OMS => francisco_ofarril
2023-04-24 15:23 francisco_ofarril Status new => scheduled
2023-04-26 03:47 hgbot Merge Request Status => open
2023-04-26 03:47 hgbot Note Added: 0148876
2023-05-04 13:22 sofidossant Note Added: 0149298
2023-05-08 17:00 hgbot Note Added: 0149444
2023-05-08 17:05 aferraz Assigned To francisco_ofarril => radhakrishnan
2023-05-09 13:32 hgbot Note Added: 0149493
2023-05-10 09:57 hgbot Merge Request Status open => approved
2023-05-10 09:58 hgbot Resolution open => fixed
2023-05-10 09:58 hgbot Status scheduled => closed
2023-05-10 09:58 hgbot Note Added: 0149545
2023-05-10 09:58 hgbot Note Added: 0149546
2023-05-12 04:32 hgbot Note Added: 0149638
2023-05-12 11:00 ranjith_qualiantech_com Note Added: 0149655
2023-05-12 11:00 ranjith_qualiantech_com Status closed => new
2023-05-12 11:00 ranjith_qualiantech_com Resolution fixed => open
2023-05-15 14:16 sofidossant Note Added: 0149702
2023-05-16 08:09 hgbot Note Added: 0149725
2023-05-16 09:08 hgbot Note Added: 0149754
2023-05-16 09:08 hgbot Resolution open => fixed
2023-05-16 09:08 hgbot Status new => closed
2023-05-16 09:08 hgbot Note Added: 0149755
2023-05-16 09:28 aferraz Relationship added related to 0052296
2023-05-22 13:22 hgbot Note Added: 0150060

Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker