Openbravo Issue Tracking System - Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0052142ModulesDiscounts Engine for Backendpublic2023-04-17 17:592023-05-22 13:22
Reportersofidossant 
Assigned Toradhakrishnan 
PriorityhighSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version 
Merge Request Statusapproved
Regression date
Regression introduced by commit
Regression level
Review Assigned To
Support ticket61125
OBNetwork customerGold
Regression introduced in release
Summary0052142: When a Combo discount is used, it is not filtered if the family is active.
DescriptionWhen a Combo type discount is used, it is not filtered if the family is active.
In other words, it always takes into account the families, even if the family is deactivated.

attached video with example
Steps To ReproduceExample:
{
  "ticket": {
    "id":"79797C77BD274CEBBC4BE58037AB147B",
    "organization": {
 "id": "D270A5AC50874F8BA67A88EE977F8E3B",
                      "_identifier": "Vall Blanca Store"
                          },
    "businessPartner": {
                      "id": "ABD91C9D3BC94175B876FBBE9CACA008",
                      "_identifier": "VBS Customer"
    },
    "orderDate": "2023-03-20T11:54:21",
    "priceIncludesTax": true,
    "discountsFromUser": {},
    "lines": [
      {
        "id": "1",
        "product": {
                      "id": "DEC20EABF33944BA967E24EFF8C244B3",
                      "_identifier": "Torch CB1"
                              },
        "qty": 2,
        "baseGrossUnitPrice": 100
      },
      {
        "id": "2",
        "product": {
                      "id": "D10E6131DA8144BE91CC0B4D8891A6D1",
                      "_identifier": "Backpack CB1 25l"
        },
        "qty": 1,
        "baseGrossUnitPrice": 50
      }
    ]
  }
}

https://livebuilds.openbravo.com/retail_modules_pgsql_pi/?tabId=800079&recordId=7C0E1EEE5EC24BD99890A2A26D0D9181 [^]
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
related to defect 0052296 closed radhakrishnan The api always returns the same result without checking if the filters are disabled. 
Attached Files? Videograbación 2023-04-17 13:01:59.mp4 (2,583,217) 2023-04-17 18:02
https://issues.openbravo.com/file_download.php?file_id=18387&type=bug
Issue History
Date ModifiedUsernameFieldChange
2023-04-17 17:59sofidossantNew Issue
2023-04-17 17:59sofidossantAssigned To => Triage Omni OMS
2023-04-17 17:59sofidossantSupport ticket => 61125
2023-04-17 17:59sofidossantOBNetwork customer => Gold
2023-04-17 18:02sofidossantFile Added: Videograbación 2023-04-17 13:01:59.mp4
2023-04-24 15:23francisco_ofarrilAssigned ToTriage Omni OMS => francisco_ofarril
2023-04-24 15:23francisco_ofarrilStatusnew => scheduled
2023-04-26 03:47hgbotMerge Request Status => open
2023-04-26 03:47hgbotNote Added: 0148876
2023-05-04 13:22sofidossantNote Added: 0149298
2023-05-08 17:00hgbotNote Added: 0149444
2023-05-08 17:05aferrazAssigned Tofrancisco_ofarril => radhakrishnan
2023-05-09 13:32hgbotNote Added: 0149493
2023-05-10 09:57hgbotMerge Request Statusopen => approved
2023-05-10 09:58hgbotResolutionopen => fixed
2023-05-10 09:58hgbotStatusscheduled => closed
2023-05-10 09:58hgbotNote Added: 0149545
2023-05-10 09:58hgbotNote Added: 0149546
2023-05-12 04:32hgbotNote Added: 0149638
2023-05-12 11:00ranjith_qualiantech_comNote Added: 0149655
2023-05-12 11:00ranjith_qualiantech_comStatusclosed => new
2023-05-12 11:00ranjith_qualiantech_comResolutionfixed => open
2023-05-15 14:16sofidossantNote Added: 0149702
2023-05-16 08:09hgbotNote Added: 0149725
2023-05-16 09:08hgbotNote Added: 0149754
2023-05-16 09:08hgbotResolutionopen => fixed
2023-05-16 09:08hgbotStatusnew => closed
2023-05-16 09:08hgbotNote Added: 0149755
2023-05-16 09:28aferrazRelationship addedrelated to 0052296
2023-05-22 13:22hgbotNote Added: 0150060

Notes
(0148876)
hgbot   
2023-04-26 03:47   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.discounts.combo/-/merge_requests/28 [^]
(0149298)
sofidossant   
2023-05-04 13:22   
Any news?
(0149444)
hgbot   
2023-05-08 17:00   
Merge request closed: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.discounts.combo/-/merge_requests/28 [^]
(0149493)
hgbot   
2023-05-09 13:32   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.discounts.combo/-/merge_requests/31 [^]
(0149545)
hgbot   
2023-05-10 09:58   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.discounts.combo [^]
Changeset: 100f7b8e5ff71de63cd422197ab55c83f9b3ef85
Author: Radhakrishnan Seeman <radhakrishnan@qualiantech.com>
Date: 10-05-2023 07:58:34
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.discounts.combo/-/commit/100f7b8e5ff71de63cd422197ab55c83f9b3ef85 [^]

Fixed ISSUE-52142: Combo family should not be added when it's in inactive

---
M src/org/openbravo/retail/discounts/combo/ComboDataHook.java
---
(0149546)
hgbot   
2023-05-10 09:58   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.discounts.combo/-/merge_requests/31 [^]
(0149638)
hgbot   
2023-05-12 04:32   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.discounts.combo [^]
Changeset: 6029d12ad8e86842f3739ce324448eb5efd9ab1a
Author: Ranjith S R <ranjith@qualiantech.com>
Date: 12-05-2023 08:00:57
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.discounts.combo/-/commit/6029d12ad8e86842f3739ce324448eb5efd9ab1a [^]

Revert "Fixed ISSUE-52142: Combo family should not be added when it's in inactive"

This reverts commit 100f7b8e5ff71de63cd422197ab55c83f9b3ef85.

---
M src/org/openbravo/retail/discounts/combo/ComboDataHook.java
---
(0149655)
ranjith_qualiantech_com   
2023-05-12 11:00   
Changes reverted due to junit test failed in CI
(0149702)
sofidossant   
2023-05-15 14:16   
Any comments?
(0149725)
hgbot   
2023-05-16 08:09   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.discounts.combo/-/merge_requests/32 [^]
(0149754)
hgbot   
2023-05-16 09:08   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.discounts.combo/-/merge_requests/32 [^]
(0149755)
hgbot   
2023-05-16 09:08   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.discounts.combo [^]
Changeset: 98a0545aa80b0eba1d5041d51521251fa6221166
Author: Radhakrishnan Seeman <radhakrishnan@qualiantech.com>
Date: 15-05-2023 16:49:54
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.discounts.combo/-/commit/98a0545aa80b0eba1d5041d51521251fa6221166 [^]

Fixed ISSUE-52142: Combo family should not be added when it's in inactive

---
M src/org/openbravo/retail/discounts/combo/ComboDataHook.java
---
(0150060)
hgbot   
2023-05-22 13:22   
Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.discounts.combo [^]
Changeset: c35e8532e63a223b69946f21576cf55be366b1e2
Author: Álvaro Ferraz <alvaro.ferraz@openbravo.com>
Date: 22-05-2023 13:22:17
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.discounts.combo/-/commit/c35e8532e63a223b69946f21576cf55be366b1e2 [^]

Related to ISSUE-52142: Make functions private instead of public

---
M src/org/openbravo/retail/discounts/combo/ComboDataHook.java
---