Project: 	
  | View Issue Details[ Jump to Notes ] | [ Issue History ] [ Print ] | |||||||
| ID | ||||||||
| 0050893 | ||||||||
| Type | Category | Severity | Reproducibility | Date Submitted | Last Update | |||
| defect | [POS2] POS | major | always | 2022-11-14 17:54 | 2022-12-02 11:06 | |||
| Reporter | Aaron_Alvarez | View Status | public | |||||
| Assigned To | Aaron_Alvarez | |||||||
| Priority | urgent | Resolution | fixed | Fixed in Version | 23Q1 | |||
| Status | closed | Fix in branch | Fixed in SCM revision | |||||
| Projection | none | ETA | none | Target Version | ||||
| OS | Any | Database | Any | Java version | ||||
| OS Version | Database version | Ant version | ||||||
| Product Version | SCM revision | |||||||
| Merge Request Status | approved | |||||||
| Review Assigned To | gorka_gil | |||||||
| OBNetwork customer | Gold | |||||||
| Support ticket | ||||||||
| Regression level | Code review | |||||||
| Regression date | ||||||||
| Regression introduced in release | ||||||||
| Regression introduced by commit | https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/commit/0725047418f157fd29ff16927243f25185c2a393 [^] | |||||||
| Triggers an Emergency Pack | No | |||||||
| Summary | 0050893: Optional discounts with giftNotification gives error when navigating to order discounts | |||||||
| Description | When having a discount with giftNotification and optional application method it gives an error when navigating to order discounts | |||||||
| Steps To Reproduce | - Go to Backend  - Create a new discount free gift per total amount (in old openbravo versions it is needed to have installed the bytotal module) - In the discount check giftNotification and apply method have to be optional * Amount for example can be 100 * Select a free product like for example body warmers - Go to POS2 - Create a ticket with total more than 100 - Go to order discounts ERROR: We get an error when navigating to order discounts  | |||||||
| Tags | No tags attached. | |||||||
| Attached Files | ||||||||
		  Relationships		[ Relation Graph ] 
		[ Dependency Graph ] 
			 | 
|||||||||||||||||||||||||||||||||
  | 
|||||||||||||||||||||||||||||||||
  		Notes	 | 
|
| 
				(0143621) hgbot (developer) 2022-11-15 15:56  | 
	
		Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/merge_requests/1368 [^] | 
| 
				(0143719) hgbot (developer) 2022-11-16 16:11  | 
	
		Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.discounts/-/merge_requests/74 [^] | 
| 
				(0144301) hgbot (developer) 2022-12-01 11:47  | 
	
		Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.discounts/-/merge_requests/74 [^] | 
| 
				(0144302) hgbot (developer) 2022-12-01 11:47  | 
	
		Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.discounts [^] Changeset: c1ccf9ffe72c88ad4919acf8c13b30d0475f43aa Author: Aaron Alvarez <aaron.alvarez@openbravo.com> Date: 01-12-2022 10:47:40 URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.discounts/-/commit/c1ccf9ffe72c88ad4919acf8c13b30d0475f43aa [^] ISSUE-50893: OptionalDiscNotification --- M web/org.openbravo.retail.discounts/app/model/business-logic/discounts-engine/engine/optional-discount-engine.js ---  | 
| 
				(0144303) hgbot (developer) 2022-12-01 11:49  | 
	
		Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2 [^] Changeset: 2661fb3fd192e70023b630de4ca9d3ef894e542c Author: Aaron Alvarez <aaron.alvarez@openbravo.com> Date: 01-12-2022 10:49:19 URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/commit/2661fb3fd192e70023b630de4ca9d3ef894e542c [^] ISSUE-50893: OptionalDiscNotification --- M web-jspack/org.openbravo.pos2/src/core/discount/GiftReminderNotification/__test__/getGiftReminderNotificationList.test.js M web-jspack/org.openbravo.pos2/src/core/discount/GiftReminderNotification/getGiftReminderNotificationList.js ---  | 
| 
				(0144304) hgbot (developer) 2022-12-01 11:49  | 
	
		Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/merge_requests/1368 [^] | 
  Issue History	 | 
|||
| Date Modified | Username | Field | Change | 
| 2022-11-14 17:54 | Aaron_Alvarez | New Issue | |
| 2022-11-14 17:54 | Aaron_Alvarez | Assigned To | => Aaron_Alvarez | 
| 2022-11-14 17:54 | Aaron_Alvarez | OBNetwork customer | => No | 
| 2022-11-14 17:54 | Aaron_Alvarez | Triggers an Emergency Pack | => No | 
| 2022-11-14 17:58 | Aaron_Alvarez | Relationship added | caused by 0050412 | 
| 2022-11-14 18:02 | Aaron_Alvarez | Regression level | => Code review | 
| 2022-11-14 18:02 | Aaron_Alvarez | Regression introduced by commit | => https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/commit/0725047418f157fd29ff16927243f25185c2a393 [^] | 
| 2022-11-15 15:56 | hgbot | Merge Request Status | => open | 
| 2022-11-15 15:56 | hgbot | Note Added: 0143621 | |
| 2022-11-16 16:11 | hgbot | Note Added: 0143719 | |
| 2022-11-23 11:01 | rafaroda | OBNetwork customer | No => Gold | 
| 2022-11-23 11:01 | rafaroda | Priority | normal => urgent | 
| 2022-11-30 21:59 | rafaroda | Relationship added | related to 0050974 | 
| 2022-12-01 11:47 | hgbot | Merge Request Status | open => approved | 
| 2022-12-01 11:47 | hgbot | Note Added: 0144301 | |
| 2022-12-01 11:47 | hgbot | Note Added: 0144302 | |
| 2022-12-01 11:49 | hgbot | Note Added: 0144303 | |
| 2022-12-01 11:49 | hgbot | Note Added: 0144304 | |
| 2022-12-02 11:06 | gorka_gil | Status | new => scheduled | 
| 2022-12-02 11:06 | gorka_gil | Status | scheduled => resolved | 
| 2022-12-02 11:06 | gorka_gil | Fixed in Version | => 23Q1 | 
| 2022-12-02 11:06 | gorka_gil | Resolution | open => fixed | 
| 2022-12-02 11:06 | gorka_gil | Review Assigned To | => gorka_gil | 
| 2022-12-02 11:06 | gorka_gil | Status | resolved => closed | 
| 2023-02-08 11:42 | rafaroda | Relationship added | related to 0051398 | 
| 2023-02-08 11:42 | rafaroda | Relationship added | related to 0051399 | 
| Copyright © 2000 - 2009 MantisBT Group |