Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue Details[ Jump to Notes ] [ Issue History ] [ Print ]
ID
0051398
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[POS2] POSmajoralways2023-01-18 10:362023-07-03 17:12
ReporternoemierousselView Statuspublic 
Assigned Toranjith_qualiantech_com 
PriorityhighResolutionfixedFixed in Version23Q3
StatusclosedFix in branchFixed in SCM revision
ProjectionnoneETAnoneTarget Version
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Merge Request Statusapproved
Review Assigned To
OBNetwork customerNo
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0051398: Optional free products discounts with the flag gift reminder notification, should also be shown in "Orders discounts"

DescriptionFor the promotion types :

-"Free product per total amount"
-"Buy X and get Y as gift"

Without adding manually the free product, the scenario Optional + Gift Reminder= Yes --> Discount screen is open is KO in the "Orders Discounts" option.

See video: https://drive.google.com/file/d/1TIcf7AJ7DoQZqA-MzWf9ebaIE9Yjl2sw/view?usp=sharing [^]
Steps To ReproduceCreate a new discount of free product:
- Free Products per Total Amount
- starting date: something before today
- total receipt: 100
- application method: optional
- gift reminder notification checked

Go to pos
- refresh masterdata
- add products > 100€ to the ticket
- Open the "Order Discounts" option -> KO the promotion do not appear

ERROR: the discount is not show as available
Proposed SolutionOptional + Gift Reminder= Yes --> "Orders Discounts" option display the promotion without adding free product manually
TagsFASH
Attached Files

- Relationships [ Relation Graph ] [ Dependency Graph ]
related to defect 0050893 closedAaron_Alvarez Optional discounts with giftNotification gives error when navigating to order discounts 
related to defect 0051399 closedranjith_qualiantech_com Regression:Optional free products discounts with the flag gift reminder notification, should also be shown in featured discounts 

-  Notes
(0146030)
avicente (viewer)
2023-01-30 13:26

 Expected behavior for all the user cases:
1 Product is NOT added to the ticket before clicking on the pay button:

   1.1 Automatic + Gift Reminder= No --> Discount screen is NOT open.

   1.2 Automatic + Gift Reminder= Yes --> Discount screen is open

   1.3 Optional + Gift Reminder= No --> Discount screen is NOT open.

   1.4 Optional + Gift Reminder= Yes --> Discount screen is open

2 Service/Product is added to the ticket before clicking on the pay button:

   2.1 Automatic + Gift Reminder= No --> Discount screen is NOT open.

   2.2 Automatic + Gift Reminder= Yes --> Discount screen is NOT open.

   2.3 Optional + Gift Reminder= No --> Discount screen is open.

   2.4 Optional + Gift Reminder= Yes --> Discount screen is open.
(0146241)
hgbot (developer)
2023-02-03 10:30

 Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/merge_requests/1507 [^]
(0146722)
hgbot (developer)
2023-02-19 08:48

 Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/merge_requests/1507 [^]
(0146723)
hgbot (developer)
2023-02-19 08:48

 Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2 [^]
Changeset: 3c825cc9ee68b2b3e6fbd440af183ca6719435f8
Author: Ranjith S R <ranjith@qualiantech.com>
Date: 19-02-2023 07:47:50
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/commit/3c825cc9ee68b2b3e6fbd440af183ca6719435f8 [^]

Fixed ISSUE-51398: OptionalDiscounts should be shown in Order discounts
* OptionalDiscounts without having gift products should be shown in Order discounts

---
A web-jspack/org.openbravo.pos2/src/model/ticket/actions/SetOptionalDiscountsIntoTicketActionPreparation.js
M web-jspack/org.openbravo.pos2/src/components/Discounts/shared/OptionalDiscountsUtils.js
M web-jspack/org.openbravo.pos2/src/model/ticket/actions/SetByTotalPromotionIntoLine.js
M web-jspack/org.openbravo.pos2/src/ob-init.js
---
(0152045)
hgbot (developer)
2023-07-03 13:20

 Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2 [^]
Changeset: 8aacb5a3c73f2e70d12dd4c36178bc22a576f27d
Author: Gorka Gil <gorka.gil@openbravo.com>
Date: 03-07-2023 13:19:45
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/commit/8aacb5a3c73f2e70d12dd4c36178bc22a576f27d [^]

Revert "Fixed ISSUE-51398: OptionalDiscounts should be shown in Order discounts"

This reverts commit 3c825cc9ee68b2b3e6fbd440af183ca6719435f8.

---
M web-jspack/org.openbravo.pos2/src/components/Discounts/shared/OptionalDiscountsUtils.js
M web-jspack/org.openbravo.pos2/src/model/ticket/actions/SetByTotalPromotionIntoLine.js
M web-jspack/org.openbravo.pos2/src/ob-init.js
R web-jspack/org.openbravo.pos2/src/model/ticket/actions/SetOptionalDiscountsIntoTicketActionPreparation.js
---
(0152046)
gorka_gil (administrator)
2023-07-03 13:22

 Reverted the fix and reject the issue, since in order discounts should not appear gift notifications.
(0152064)
hgbot (developer)
2023-07-03 17:11

 Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2 [^]
Changeset: e27f36e9e54dfbe6122f3b2655c29b467650b39e
Author: Gorka Gil <gorka.gil@openbravo.com>
Date: 03-07-2023 17:10:46
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/commit/e27f36e9e54dfbe6122f3b2655c29b467650b39e [^]

Revert "Fixed ISSUE-51398: OptionalDiscounts should be shown in Order discounts"

This reverts commit 3c825cc9ee68b2b3e6fbd440af183ca6719435f8.

---
M web-jspack/org.openbravo.pos2/src/components/Discounts/shared/OptionalDiscountsUtils.js
M web-jspack/org.openbravo.pos2/src/model/ticket/actions/SetByTotalPromotionIntoLine.js
M web-jspack/org.openbravo.pos2/src/ob-init.js
R web-jspack/org.openbravo.pos2/src/model/ticket/actions/SetOptionalDiscountsIntoTicketActionPreparation.js
---
(0152065)
gorka_gil (administrator)
2023-07-03 17:12

 Reverted also in release/23Q3 branch

- Issue History
Date Modified Username Field Change
2023-01-18 10:36 noemieroussel New Issue
2023-01-18 10:36 noemieroussel Assigned To => Retail
2023-01-18 10:36 noemieroussel OBNetwork customer => No
2023-01-18 10:36 noemieroussel Triggers an Emergency Pack => No
2023-01-18 10:37 noemieroussel Tag Attached: FASH
2023-01-18 11:09 rafaroda Relationship added related to 0051399
2023-01-30 13:26 avicente Note Added: 0146030
2023-01-31 10:18 ranjith_qualiantech_com Assigned To Retail => ranjith_qualiantech_com
2023-02-03 07:48 ranjith_qualiantech_com Status new => scheduled
2023-02-03 10:30 hgbot Merge Request Status => open
2023-02-03 10:30 hgbot Note Added: 0146241
2023-02-08 11:42 rafaroda Relationship added related to 0050893
2023-02-19 08:48 hgbot Merge Request Status open => approved
2023-02-19 08:48 hgbot Note Added: 0146722
2023-02-19 08:48 hgbot Resolution open => fixed
2023-02-19 08:48 hgbot Status scheduled => closed
2023-02-19 08:48 hgbot Fixed in Version => 23Q2
2023-02-19 08:48 hgbot Note Added: 0146723
2023-07-03 13:20 hgbot Fixed in Version 23Q2 => 23Q4
2023-07-03 13:20 hgbot Note Added: 0152045
2023-07-03 13:20 gorka_gil Resolution fixed => invalid
2023-07-03 13:22 gorka_gil Note Added: 0152046
2023-07-03 17:11 hgbot Resolution invalid => fixed
2023-07-03 17:11 hgbot Fixed in Version 23Q4 => 23Q3
2023-07-03 17:11 hgbot Note Added: 0152064
2023-07-03 17:12 gorka_gil Note Added: 0152065

Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker