Openbravo Issue Tracking System - POS2
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0050893POS2POSpublic2022-11-14 17:542022-12-02 11:06
ReporterAaron_Alvarez 
Assigned ToAaron_Alvarez 
PriorityurgentSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version23Q1 
Merge Request Status
Review Assigned Togorka_gil
OBNetwork customer
Support ticket
Regression levelCode review
Regression date
Regression introduced in release
Regression introduced by commithttps://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/commit/0725047418f157fd29ff16927243f25185c2a393 [^]
Triggers an Emergency PackNo
Summary0050893: Optional discounts with giftNotification gives error when navigating to order discounts
DescriptionWhen having a discount with giftNotification and optional application method it gives an error when navigating to order discounts
Steps To Reproduce- Go to Backend
- Create a new discount free gift per total amount (in old openbravo versions it is needed to have installed the bytotal module)
- In the discount check giftNotification and apply method have to be optional
  * Amount for example can be 100
  * Select a free product like for example body warmers
- Go to POS2
- Create a ticket with total more than 100
- Go to order discounts

ERROR: We get an error when navigating to order discounts
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
caused by feature request 0050412 closed Aaron_Alvarez POS2 Optional free products discounts with the flag gift reminder notification, should also be shown in featured discounts 
related to defect 0050974 closed ranjith_qualiantech_com Retail Modules [PROMO]- Buy X Get Y - Promotion is not triggered if the list of eligible products contains a product with other promotion 
related to defect 0051398 closed ranjith_qualiantech_com POS2 Optional free products discounts with the flag gift reminder notification, should also be shown in "Orders discounts" 
related to defect 0051399 closed ranjith_qualiantech_com POS2 Regression:Optional free products discounts with the flag gift reminder notification, should also be shown in featured discounts 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2022-11-14 17:54Aaron_AlvarezNew Issue
2022-11-14 17:54Aaron_AlvarezAssigned To => Aaron_Alvarez
2022-11-14 17:54Aaron_AlvarezTriggers an Emergency Pack => No
2022-11-14 17:58Aaron_AlvarezRelationship addedcaused by 0050412
2022-11-14 18:02Aaron_AlvarezRegression level => Code review
2022-11-14 18:02Aaron_AlvarezRegression introduced by commit => https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/commit/0725047418f157fd29ff16927243f25185c2a393 [^]
2022-11-15 15:56hgbotNote Added: 0143621
2022-11-16 16:11hgbotNote Added: 0143719
2022-11-23 11:01rafarodaPrioritynormal => urgent
2022-11-30 21:59rafarodaRelationship addedrelated to 0050974
2022-12-01 11:47hgbotNote Added: 0144301
2022-12-01 11:47hgbotNote Added: 0144302
2022-12-01 11:49hgbotNote Added: 0144303
2022-12-01 11:49hgbotNote Added: 0144304
2022-12-02 11:06gorka_gilStatusnew => scheduled
2022-12-02 11:06gorka_gilStatusscheduled => resolved
2022-12-02 11:06gorka_gilFixed in Version => 23Q1
2022-12-02 11:06gorka_gilResolutionopen => fixed
2022-12-02 11:06gorka_gilReview Assigned To => gorka_gil
2022-12-02 11:06gorka_gilStatusresolved => closed
2023-02-08 11:42rafarodaRelationship addedrelated to 0051398
2023-02-08 11:42rafarodaRelationship addedrelated to 0051399

Notes
(0143621)
hgbot   
2022-11-15 15:56   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/merge_requests/1368 [^]
(0143719)
hgbot   
2022-11-16 16:11   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.discounts/-/merge_requests/74 [^]
(0144301)
hgbot   
2022-12-01 11:47   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.discounts/-/merge_requests/74 [^]
(0144302)
hgbot   
2022-12-01 11:47   
Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.discounts [^]
Changeset: c1ccf9ffe72c88ad4919acf8c13b30d0475f43aa
Author: Aaron Alvarez <aaron.alvarez@openbravo.com>
Date: 01-12-2022 10:47:40
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.discounts/-/commit/c1ccf9ffe72c88ad4919acf8c13b30d0475f43aa [^]

ISSUE-50893: OptionalDiscNotification

---
M web/org.openbravo.retail.discounts/app/model/business-logic/discounts-engine/engine/optional-discount-engine.js
---
(0144303)
hgbot   
2022-12-01 11:49   
Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2 [^]
Changeset: 2661fb3fd192e70023b630de4ca9d3ef894e542c
Author: Aaron Alvarez <aaron.alvarez@openbravo.com>
Date: 01-12-2022 10:49:19
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/commit/2661fb3fd192e70023b630de4ca9d3ef894e542c [^]

ISSUE-50893: OptionalDiscNotification

---
M web-jspack/org.openbravo.pos2/src/core/discount/GiftReminderNotification/__test__/getGiftReminderNotificationList.test.js
M web-jspack/org.openbravo.pos2/src/core/discount/GiftReminderNotification/getGiftReminderNotificationList.js
---
(0144304)
hgbot   
2022-12-01 11:49   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/merge_requests/1368 [^]