0046270: Logic that controls the Lottery panel when user navigates to Payment tab is not fully correct

Description

Currently there are two problems with the logic that controls whether the Lottery panel should be shown when the user goes to Payment tab.

First one is that the RTServer specific logic is not needed anymore, and should be removed. So, in utils.js these lines should be removed:

  // Override function from lottery code
  OB.LOTCODE = OB.LOTCODE || {};
  OB.LOTCODE.Utils = OB.LOTCODE.Utils || {};
  OB.LOTCODE.Utils.showLotteryCodePopup = showLotteryCodePopup;

and isRTServerVerifiedReturn should be restored to its original behaviour:

  const isRTServerVerifiedReturn = receipt => {
    return (
            !hasBlindReferenceZNumber(receipt) &&
              !hasBlindReferenceDocumentNumber(receipt)

    );
  };

Apart from this, the logic in SCO that controls the panel is also not correct. In file obscolc-prepaymenthook.js we are doing this:

    if (
      OB.LOTCODE.Utils.showLotteryCodePopup(args.context.receipt) ||
      !OB.MobileApp.model.hasPermission(
        'OBLOTC_requestLotteryCodeInformation',
        true
      )
    ) {
      finalHookCallback();
    } else {
      OB.OBSCOLC.Utils.showGetLotteryCodePanel(args, finalHookCallback);
    }

and in fact it should be the opposite, if OB.LOTCODE.Utils.showLotteryCodePopup returns true, then the panel should be shown.

Steps To Reproduce

Enable lottery implementation.
Go to self checkout. Do a ticket. Check that the lottery panel is not shown.

Tags

No tags attached.

Attached Files

Relationships [ Relation Graph ] [ Dependency Graph ]

duplicate of

defect

0046226

closed

rqueralta

The Fiscal Reference Document popup info is not infomed in the printed ticket

Notes
There are no notes attached to this issue.

Issue History
Date Modified	Username	Field	Change
2021-04-15 09:38	marvintm	New Issue
2021-04-15 09:38	marvintm	Assigned To	=> Retail
2021-04-15 09:38	marvintm	OBNetwork customer	=> Gold
2021-04-15 09:38	marvintm	Resolution time	=> 1620165600
2021-04-15 09:38	marvintm	Triggers an Emergency Pack	=> No
2021-04-15 09:48	jorge-garcia	Issue Monitored: jorge-garcia
2021-04-15 18:31	marvintm	Review Assigned To	=> marvintm
2021-04-15 18:31	marvintm	Relationship added	duplicate of 0046226
2021-04-15 18:31	marvintm	Status	new => closed
2021-04-15 18:31	marvintm	Resolution	open => duplicate