0046270: Logic that controls the Lottery panel when user navigates to Payment tab is not fully correct

Openbravo Issue Tracking System - Retail Modules

View Issue Details

Project

Category

View Status

Date Submitted

Last Update

0046270

Retail Modules

Web POS

public

2021-04-15 09:38

2021-04-15 18:31

Reporter

marvintm

Assigned To

Retail

Priority

normal

Severity

major

Reproducibility

have not tried

Status

closed

Resolution

duplicate

Platform

OS Version

Product Version

Target Version

Fixed in Version

Merge Request Status

Review Assigned To

marvintm

OBNetwork customer

Gold

Support ticket

Regression level

Regression date

Regression introduced in release

Regression introduced by commit

Triggers an Emergency Pack

Summary

0046270: Logic that controls the Lottery panel when user navigates to Payment tab is not fully correct

Description

Currently there are two problems with the logic that controls whether the Lottery panel should be shown when the user goes to Payment tab.

First one is that the RTServer specific logic is not needed anymore, and should be removed. So, in utils.js these lines should be removed:

  // Override function from lottery code
  OB.LOTCODE = OB.LOTCODE || {};
  OB.LOTCODE.Utils = OB.LOTCODE.Utils || {};
  OB.LOTCODE.Utils.showLotteryCodePopup = showLotteryCodePopup;

and isRTServerVerifiedReturn should be restored to its original behaviour:

  const isRTServerVerifiedReturn = receipt => {
    return (
            !hasBlindReferenceZNumber(receipt) &&
              !hasBlindReferenceDocumentNumber(receipt)

    );
  };

Apart from this, the logic in SCO that controls the panel is also not correct. In file obscolc-prepaymenthook.js we are doing this:

    if (
      OB.LOTCODE.Utils.showLotteryCodePopup(args.context.receipt) ||
      !OB.MobileApp.model.hasPermission(
        'OBLOTC_requestLotteryCodeInformation',
        true
      )
    ) {
      finalHookCallback();
    } else {
      OB.OBSCOLC.Utils.showGetLotteryCodePanel(args, finalHookCallback);
    }

and in fact it should be the opposite, if OB.LOTCODE.Utils.showLotteryCodePopup returns true, then the panel should be shown.

Steps To Reproduce

Enable lottery implementation.
Go to self checkout. Do a ticket. Check that the lottery panel is not shown.

Proposed Solution

Additional Information