Anonymous | Login

Project:

News | My View | View Issues | Roadmap | Summary

View Issue Details[ Jump to Notes ]

[ Issue History ] [ Print ]

ID

0045919

Type

Category

Severity

Reproducibility

Date Submitted

Last Update

defect

[Retail Modules] Web POS

major

have not tried

2021-02-18 14:11

2021-03-04 12:55

Reporter

ALopetegui

View Status

public

Assigned To

rqueralta

Priority

normal

Resolution

fixed

Fixed in Version

RR21Q2

Status

closed

Fix in branch

Fixed in SCM revision

Projection

none

ETA

none

Target Version

OS

Any

Database

Any

Java version

OS Version

Database version

Ant version

Product Version

RR20Q3.1

SCM revision

Review Assigned To

Regression level

Regression date

Regression introduced in release

Regression introduced by commit

Triggers an Emergency Pack

No

Summary

0045919: Extra join of product table in master.product

Description

In posterminal master.Product.java class, the regular product hql makes and extra join with the table m_product.

There is a first condition to left join OBRETCO_Prol_Product with productImages through product table, and then there is again a join with product.

Steps To Reproduce

In any query of the product search or master data load.

Proposed Solution

Join OBRETCO_Prol_Product with m_product first, and then left join with images.

Patch attached.

Tags

NOR, Performance

masterProduct.patch [^] (892 bytes) 2021-02-18 14:11 [Show Content] [Hide Content]

diff --git a/src/org/openbravo/retail/posterminal/master/Product.java b/src/org/openbravo/retail/posterminal/master/Product.java
index 4a6f129a1..3a7c12b7d 100644
--- a/src/org/openbravo/retail/posterminal/master/Product.java
+++ b/src/org/openbravo/retail/posterminal/master/Product.java
@@ -268,10 +268,10 @@ public class Product extends MasterDataProcessHQLQuery {
       JSONObject jsonsent, boolean useGetForProductImages, boolean allowNoPriceInMainPriceList) {
 
     String hql = "FROM OBRETCO_Prol_Product as pli ";
+    hql += "inner join pli.product as product ";
     if (!useGetForProductImages) {
-      hql += "left outer join pli.product.image img ";
+      hql += "left outer join product.image img ";
     }
-    hql += "inner join pli.product as product ";
     hql += "left join product.attributeSet as attrset ";
 
     if (isMultipricelist && allowNoPriceInMainPriceList

Relationships [ Relation Graph ] [ Dependency Graph ]

related to	defect	0045055		closed	ranjith_qualiantech_com	Retail Modules	Incremental refresh of ProductCharacteristic cannot use index on updated
related to	defect	0045144		closed	prakashmurugesan88	Retail Modules	Fix incremental and full refresh with Multi Tax Category module
related to	defect	0045467		closed	prakashmurugesan88	Retail Modules	Performance issues on the model CharacteristicValue
related to	feature request	0045056		new	Retail	Retail Modules	Faster insertion of big amounts of data in full refresh in indexedDB
has duplicate	defect	0044911		closed	ranjith_qualiantech_com	Retail Modules	Incremental refresh of Product cannot use index on updated
related to	design defect	0045922		acknowledged	Triage Platform Base	Openbravo ERP	Extra self-join with main table when using computed columns

Notes
(0126384) hgbot (developer) 2021-02-28 03:34	Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/merge_requests/328 [^]

(0126397) hgbot (developer) 2021-03-01 07:40	Directly closing issue as related merge request is already approved. Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal [^] Changeset: 69e68f5fb10907e197e4d5145902f42cfa733e4a Author: Rafael Queralta <rafaelcuba81@gmail.com> Date: 2021-03-01T06:39:51+00:00 URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/commit/69e68f5fb10907e197e4d5145902f42cfa733e4a [^] Fixed BUG-45919: Removed extra join of product table in master.product --- M src/org/openbravo/retail/posterminal/master/Product.java ---

(0126398) hgbot (developer) 2021-03-01 07:40	Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/merge_requests/328 [^]

Issue History
Date Modified	Username	Field	Change
2021-02-18 14:11	ALopetegui	New Issue
2021-02-18 14:11	ALopetegui	Assigned To	=> Retail
2021-02-18 14:11	ALopetegui	File Added: masterProduct.patch
2021-02-18 14:11	ALopetegui	Resolution time	=> 1617400800
2021-02-18 14:11	ALopetegui	Triggers an Emergency Pack	=> No
2021-02-18 18:05	ALopetegui	Tag Attached: Performance
2021-02-22 00:20	rqueralta	Assigned To	Retail => rqueralta
2021-02-22 10:44	rafaroda	Tag Attached: NOR
2021-02-22 10:46	rafaroda	Relationship added	related to 0045922
2021-02-22 10:47	rafaroda	Relationship added	has duplicate 0044911
2021-02-22 10:47	rafaroda	Relationship added	related to 0045055
2021-02-22 10:47	rafaroda	Relationship added	related to 0045144
2021-02-22 10:48	rafaroda	Relationship added	related to 0045467
2021-02-24 09:53	rafaroda	Resolution time	1617400800 => 1614726000
2021-02-28 03:34	hgbot	Note Added: 0126384
2021-03-01 07:40	hgbot	Resolution	open => fixed
2021-03-01 07:40	hgbot	Status	new => closed
2021-03-01 07:40	hgbot	Fixed in Version	=> RR21Q2
2021-03-01 07:40	hgbot	Note Added: 0126397
2021-03-01 07:40	hgbot	Note Added: 0126398
2021-03-04 12:55	rafaroda	Relationship added	related to 0045056

Copyright © 2000 - 2009 MantisBT Group