Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue DetailsJump to Notes ] Issue History ] Print ]
ID
0044911
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[Retail Modules] Web POSmajorhave not tried2020-08-27 15:052020-09-11 08:01
ReporterAugustoMauchView Statuspublic 
Assigned Toranjith_qualiantech_com 
PrioritynormalResolutionfixedFixed in VersionRR20Q4
StatusclosedFix in branchFixed in SCM revision
ProjectionnoneETAnoneTarget Version
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Review Assigned To
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0044911: Incremental refresh of Product cannot use index on updated

DescriptionThis is part of the query done to do an incremental refresh of products:

hql += "AND ((product.$incrementalUpdateCriteria) OR (pli.$incrementalUpdateCriteria) OR (ppp.$incrementalUpdateCriteria) OR (product.uOM.$incrementalUpdateCriteria))";

This means that a product will be returned if any of these have been modified:
- the product itself
- its entry in the assortment
- its entry in the price list
- its unit of measure

This is very complete, but it does not have good performance with big volumes, because the OR clauses prevents the use of indexes.

An index should be added to m_product.updated
Steps To ReproduceTo reproduce this just do an incremental refresh, and check the explain plan that results when executing the product query. I attached one to this issue
Proposed SolutionCreate a new preference that allows to check only the "updated" column of m_product when doing an incremental refresh.

Then each integration module should be in charge of making sure that the m_product.updated column is updated when needed
TagsNOR
Attached Files? file icon productIncrementalRefresh.sql [^] (7,042 bytes) 2020-08-27 15:06
txt file icon productIncrementalRefreshExplainPlan.txt [^] (73,727 bytes) 2020-08-27 15:07 [Show Content]

- Relationships Relation Graph ] Dependency Graph ]
duplicate of defect 0045919 closedrqueralta Retail Modules Extra join of product table in master.product 
related to defect 0044590 closedranjith_qualiantech_com Retail Modules Product tax category changes are not updated in webpos 
related to defect 0045055 closedranjith_qualiantech_com Retail Modules Incremental refresh of ProductCharacteristic cannot use index on updated 
related to feature request 0045056 newRetail Retail Modules Faster insertion of big amounts of data in full refresh in indexedDB 
related to defect 0045144 closedprakashmurugesan88 Retail Modules Fix incremental and full refresh with Multi Tax Category module 
related to defect 0045187 closedranjith_qualiantech_com Retail Modules Full Refresh fail: continues the load when it should stop 
related to defect 0045467 closedprakashmurugesan88 Retail Modules Performance issues on the model CharacteristicValue 
related to design defect 0045922 acknowledgedTriage Platform Base Openbravo ERP Extra self-join with main table when using computed columns 
related to defect 0047423 closedranjith_qualiantech_com Retail Modules Slow incremental refresh of products 

-  Notes
(0122434)
rafaroda (developer)
2020-08-28 15:43

See comment on 0044590: triggers required in order to updated the M_PRODUCT.UPDATED column as it exists nowadays in Multi UPC table and Multiple Tax Category table
(0122939)
hgbot (developer)
2020-09-11 07:34

Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/merge_requests/94 [^]
(0122940)
hgbot (developer)
2020-09-11 08:01

Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/merge_requests/94 [^]
(0122941)
hgbot (developer)
2020-09-11 08:01

Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal [^]
Changeset: 0d22ec64d6071f68b79c8a25f4cf32314d6385b8
Author: Ranjith S R <ranjith@qualiantech.com>
Date: 2020-09-11T11:03:13+05:30
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/commit/0d22ec64d6071f68b79c8a25f4cf32314d6385b8 [^]

Fixed ISSUE-44911: Filter MasterData Product by Related Entities on doing refresh

---
M src-db/database/sourcedata/AD_PREFERENCE.xml
M src-db/database/sourcedata/AD_REF_LIST.xml
M src/org/openbravo/retail/posterminal/master/Product.java
---

- Issue History
Date Modified Username Field Change
2020-08-27 15:05 AugustoMauch New Issue
2020-08-27 15:05 AugustoMauch Assigned To => Retail
2020-08-27 15:05 AugustoMauch Triggers an Emergency Pack => No
2020-08-27 15:06 AugustoMauch Resolution time => 1599688800
2020-08-27 15:06 AugustoMauch File Added: productIncrementalRefresh.sql
2020-08-27 15:07 AugustoMauch File Added: productIncrementalRefreshExplainPlan.txt
2020-08-27 15:08 AugustoMauch Description Updated View Revisions
2020-08-28 09:50 rafaroda Tag Attached: NOR
2020-08-28 15:41 rafaroda Relationship added related to 0044590
2020-08-28 15:43 rafaroda Note Added: 0122434
2020-09-04 04:55 ranjith_qualiantech_com Assigned To Retail => ranjith_qualiantech_com
2020-09-10 10:43 ranjith_qualiantech_com Status new => scheduled
2020-09-11 07:34 hgbot Note Added: 0122939
2020-09-11 08:01 hgbot Resolution open => fixed
2020-09-11 08:01 hgbot Status scheduled => closed
2020-09-11 08:01 hgbot Note Added: 0122940
2020-09-11 08:01 hgbot Fixed in Version => RR20Q4
2020-09-11 08:01 hgbot Note Added: 0122941
2020-09-15 14:56 rafaroda Relationship added related to 0045055
2020-09-15 14:59 rafaroda Relationship added related to 0045056
2020-09-25 12:22 rafaroda Relationship added related to 0045144
2020-10-05 11:37 rafaroda Relationship added related to 0045187
2021-02-22 09:34 rafaroda Relationship added related to 0045467
2021-02-22 10:47 rafaroda Relationship added duplicate of 0045919
2021-02-22 10:47 rafaroda Relationship added related to 0045922
2021-07-21 22:31 rafaroda Relationship added related to 0047423


Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker