Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0045919Retail ModulesWeb POSpublic2021-02-18 14:112021-03-04 12:55
ReporterALopetegui 
Assigned Torqueralta 
PrioritynormalSeveritymajorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product VersionRR20Q3.1 
Target VersionFixed in VersionRR21Q2 
Merge Request Statusapproved
Review Assigned To
OBNetwork customerGold
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0045919: Extra join of product table in master.product
DescriptionIn posterminal master.Product.java class, the regular product hql makes and extra join with the table m_product.

There is a first condition to left join OBRETCO_Prol_Product with productImages through product table, and then there is again a join with product.
Steps To ReproduceIn any query of the product search or master data load.
Proposed SolutionJoin OBRETCO_Prol_Product with m_product first, and then left join with images.

Patch attached.
Additional Information
TagsNOR, Performance
Relationships
related to defect 0045055 closed ranjith_qualiantech_com Retail Modules Incremental refresh of ProductCharacteristic cannot use index on updated 
related to defect 0045144 closed prakashmurugesan88 Retail Modules Fix incremental and full refresh with Multi Tax Category module 
related to defect 0045467 closed prakashmurugesan88 Retail Modules Performance issues on the model CharacteristicValue 
related to feature request 0045056 new Retail Retail Modules Faster insertion of big amounts of data in full refresh in indexedDB 
has duplicate defect 0044911 closed ranjith_qualiantech_com Retail Modules Incremental refresh of Product cannot use index on updated 
related to design defect 0045922 acknowledged Triage Platform Base Openbravo ERP Extra self-join with main table when using computed columns 
Attached Filespatch masterProduct.patch (892) 2021-02-18 14:11
https://issues.openbravo.com/file_download.php?file_id=15333&type=bug
Issue History
Date ModifiedUsernameFieldChange
2021-02-18 14:11ALopeteguiNew Issue
2021-02-18 14:11ALopeteguiAssigned To => Retail
2021-02-18 14:11ALopeteguiFile Added: masterProduct.patch
2021-02-18 14:11ALopeteguiOBNetwork customer => OBPS
2021-02-18 14:11ALopeteguiResolution time => 1617400800
2021-02-18 14:11ALopeteguiTriggers an Emergency Pack => No
2021-02-18 18:05ALopeteguiTag Attached: Performance
2021-02-22 00:20rqueraltaAssigned ToRetail => rqueralta
2021-02-22 10:44rafarodaTag Attached: NOR
2021-02-22 10:46rafarodaRelationship addedrelated to 0045922
2021-02-22 10:47rafarodaRelationship addedhas duplicate 0044911
2021-02-22 10:47rafarodaRelationship addedrelated to 0045055
2021-02-22 10:47rafarodaRelationship addedrelated to 0045144
2021-02-22 10:48rafarodaRelationship addedrelated to 0045467
2021-02-24 09:53rafarodaResolution time1617400800 => 1614726000
2021-02-25 14:25rafarodaOBNetwork customerOBPS => Gold
2021-02-28 03:34hgbotMerge Request Status => open
2021-02-28 03:34hgbotNote Added: 0126384
2021-03-01 07:40hgbotMerge Request Statusopen => approved
2021-03-01 07:40hgbotResolutionopen => fixed
2021-03-01 07:40hgbotStatusnew => closed
2021-03-01 07:40hgbotFixed in Version => RR21Q2
2021-03-01 07:40hgbotNote Added: 0126397
2021-03-01 07:40hgbotNote Added: 0126398
2021-03-04 12:55rafarodaRelationship addedrelated to 0045056

Notes
(0126384)
hgbot   
2021-02-28 03:34   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/merge_requests/328 [^]
(0126397)
hgbot   
2021-03-01 07:40   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal [^]
Changeset: 69e68f5fb10907e197e4d5145902f42cfa733e4a
Author: Rafael Queralta <rafaelcuba81@gmail.com>
Date: 2021-03-01T06:39:51+00:00
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/commit/69e68f5fb10907e197e4d5145902f42cfa733e4a [^]

Fixed BUG-45919: Removed extra join of product table in master.product

---
M src/org/openbravo/retail/posterminal/master/Product.java
---
(0126398)
hgbot   
2021-03-01 07:40   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/merge_requests/328 [^]