Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue Details[ Jump to Notes ] [ Issue History ] [ Print ]
ID
0043317
TypeCategorySeverityReproducibilityDate SubmittedLast Update
backport[Openbravo ERP] A. Platformminorhave not tried2020-02-19 17:462020-04-06 16:54
ReportershuehnerView Statuspublic 
Assigned Tocberner 
PrioritynormalResolutionfixedFixed in Version3.0PR20Q1
StatusclosedFix in branchFixed in SCM revisionccdf63d408c9
ProjectionnoneETAnoneTarget Version3.0PR20Q1
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Review Assigned Toalostale
Web browser
ModulesCore
Regression levelPackaging and release
Regression date2019-11-28
Regression introduced in releasemain
Regression introduced by commithttp://code.openbravo.com/erp/devel/pi/rev/c47b63fff5775ab73ce8072af4fa6fd6c13d197e [^]
Triggers an Emergency PackNo
Summary

0043317: When importing translation for no longer existing elements -> INFO message is missing all necessary details

DescriptionWhen importing translation values from a translation pack it can happen that the original row to be translated does no longer exist.

In that case a message is shown like the following:
     [java] 36825 [main] INFO org.openbravo.erpCommon.ad_forms.TranslationHandler - Not Found - UPDATE AD_TEXTINTERFACES_Trl SET Text='Sous-total de la Grille',Updated=now(),IsTranslated='Y' WHERE AD_TEXTINTERFACES_ID='508174CC5C8C4E4B90AF19C2FE2A5B40' AND AD_Language='fr_FR' AND AD_Client_ID='0'

showing which translation is not finding its row to update.
Note that message is INFO level only as that is info useful to maintainer of the translation but not a problem for the user of the translation pack.

That message is now broken in pi as it looks like:
     [java] 35685 [main] INFO org.openbravo.erpCommon.ad_forms.TranslationHandler - Not Found - update AD_TEXTINTERFACES_Trl set Text=?,Updated=now() ,IsTranslated=? where AD_TEXTINTERFACES_ID=? and AD_Language=? and AD_Client_ID=?

That is side-effect of improving the code to use SQL bind-parameters.
The values interesting to print are now parameter-values but the code is only printing the sql-string
Steps To ReproduceInstall a translation having at least 1 trl value for which the original row does no longer exist.
Review the 'Not Found' to notice all reference to the element are missing
Proposed Solution-
TagsNo tags attached.
Attached Files

- Relationships [ Relation Graph ] [ Dependency Graph ]
blocks defect 0043272 closedcberner When importing translation for no longer existing elements -> INFO message is missing all necessary details 

-  Notes
(0118084)
hgbot (developer)
2020-02-25 09:57

 Repository: erp/backports/3.0PR20Q1
Changeset: 9fcaaa12799d1b7fc05f499fe5496992f646f1b9
Author: Cristian Berner <cristian.berner <at> openbravo.com>
Date: Mon Feb 24 17:13:12 2020 +0100
URL: http://code.openbravo.com/erp/backports/3.0PR20Q1/rev/9fcaaa12799d1b7fc05f499fe5496992f646f1b9 [^]

Fixes ISSUE-43317: Info message on importing missing translation shows params

---
M src/org/openbravo/erpCommon/ad_forms/TranslationHandler.java
---
(0118963)
hgbot (developer)
2020-04-06 11:53

 Repository: erp/devel/pi
Changeset: ccdf63d408c97e71e9b665d759e33c5400dd9f8a
Author: Cristian Berner <cristian.berner <at> openbravo.com>
Date: Mon Feb 24 17:13:12 2020 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/ccdf63d408c97e71e9b665d759e33c5400dd9f8a [^]

Fixes ISSUE-43317: Info message on importing missing translation shows params

---
M src/org/openbravo/erpCommon/ad_forms/TranslationHandler.java
---
(0119003)
cberner (developer)
2020-04-06 16:54

 closed: wrongly reopened

- Issue History
Date Modified Username Field Change
2020-02-25 09:56 cberner Type defect => backport
2020-02-25 09:56 cberner Target Version => 3.0PR20Q1
2020-02-25 09:57 hgbot Checkin
2020-02-25 09:57 hgbot Note Added: 0118084
2020-02-25 09:57 hgbot Status scheduled => resolved
2020-02-25 09:57 hgbot Resolution open => fixed
2020-02-25 09:57 hgbot Fixed in SCM revision http://code.openbravo.com/erp/devel/pi/rev/33db07200942157629e9ab28df79b49bfb675960 [^] => http://code.openbravo.com/erp/backports/3.0PR20Q1/rev/9fcaaa12799d1b7fc05f499fe5496992f646f1b9 [^]
2020-02-28 07:50 alostale Review Assigned To => alostale
2020-02-28 07:50 alostale Status resolved => closed
2020-02-28 07:50 alostale Fixed in Version => 3.0PR20Q1
2020-04-06 11:53 hgbot Checkin
2020-04-06 11:53 hgbot Note Added: 0118963
2020-04-06 11:53 hgbot Status closed => resolved
2020-04-06 11:53 hgbot Fixed in SCM revision http://code.openbravo.com/erp/backports/3.0PR20Q1/rev/9fcaaa12799d1b7fc05f499fe5496992f646f1b9 [^] => http://code.openbravo.com/erp/devel/pi/rev/ccdf63d408c97e71e9b665d759e33c5400dd9f8a [^]
2020-04-06 16:54 cberner Note Added: 0119003
2020-04-06 16:54 cberner Status resolved => closed

Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker