0043317: When importing translation for no longer existing elements -> INFO message is missing all necessary details

Openbravo Issue Tracking System - Openbravo ERP

View Issue Details

Project

Category

View Status

Date Submitted

Last Update

0043317

Openbravo ERP

A. Platform

public

2020-02-19 17:46

2020-04-06 16:54

Reporter

shuehner

Assigned To

cberner

Priority

normal

Severity

minor

Reproducibility

have not tried

Status

closed

Resolution

fixed

Platform

OS Version

Product Version

Target Version

3.0PR20Q1

Fixed in Version

3.0PR20Q1

Merge Request Status

Review Assigned To

alostale

OBNetwork customer

Web browser

Modules

Core

Support ticket

Regression level

Packaging and release

Regression date

2019-11-28

Regression introduced in release

main

Regression introduced by commit

http://code.openbravo.com/erp/devel/pi/rev/c47b63fff5775ab73ce8072af4fa6fd6c13d197e [^]

Triggers an Emergency Pack

Summary

0043317: When importing translation for no longer existing elements -> INFO message is missing all necessary details

Description

When importing translation values from a translation pack it can happen that the original row to be translated does no longer exist.

In that case a message is shown like the following:
[java] 36825 [main] INFO org.openbravo.erpCommon.ad_forms.TranslationHandler - Not Found - UPDATE AD_TEXTINTERFACES_Trl SET Text='Sous-total de la Grille',Updated=now(),IsTranslated='Y' WHERE AD_TEXTINTERFACES_ID='508174CC5C8C4E4B90AF19C2FE2A5B40' AND AD_Language='fr_FR' AND AD_Client_ID='0'

showing which translation is not finding its row to update.
Note that message is INFO level only as that is info useful to maintainer of the translation but not a problem for the user of the translation pack.

That message is now broken in pi as it looks like:
[java] 35685 [main] INFO org.openbravo.erpCommon.ad_forms.TranslationHandler - Not Found - update AD_TEXTINTERFACES_Trl set Text=?,Updated=now() ,IsTranslated=? where AD_TEXTINTERFACES_ID=? and AD_Language=? and AD_Client_ID=?

That is side-effect of improving the code to use SQL bind-parameters.
The values interesting to print are now parameter-values but the code is only printing the sql-string

Steps To Reproduce

Install a translation having at least 1 trl value for which the original row does no longer exist.
Review the 'Not Found' to notice all reference to the element are missing

Proposed Solution

Additional Information