0043282: Discounts with Characteristics. Having diferent characteristics work as "OR" instead of "AND"

Description

If you have two characterstics:
- Season
- Brand

And you use these two in the characteristic tab as:
- Season: 2019
- Brand: Gucci

Instead of applying the discount to the products that are in season 2019 and Gucci is applying to either products in season 2019 or with brand Gucci

Steps To Reproduce

1. Create two characteristics with values
2. In the discount and promotion window select price adjustment with 10%
3. Move to the Characteristics tab and add these two characteristics and with value in each.
4. Go to POS and see the result.

Expected result:
- Only for products that are season 2019 and Gucci

Current result:
- It is applying to either products that in season 2019 or Gucci

Proposed Solution

This is the expected behaviour with the current definition. We need to improve the configuration options so that we can support both ways of working.

The proposal is the following:
- First we need to change the configuration options of the "Included characteristics". We need to replace the "Only the values defined" by "Any of the ones defined" (change only the displayed value, we should not change the internal value of the reflist to preserve the compatibility with previous data), and we need to add a new one called "All of the values defined".
- After that we need to change the discount-rules.js file (specifically the isApplicableToLine function), to take into account this new value, so that if it is set, all characteristic values specified in the discount need to be present in the product for the discount to be applicable to the line.

Tags

No tags attached.

Attached Files

Relationships [ Relation Graph ] [ Dependency Graph ]

blocks

defect

0043203

closed

ranjith_qualiantech_com

Discounts with Characteristics. Having diferent characteristics work as "OR" instead of "AND"

Notes
(0117993) hgbot (developer) 2020-02-21 06:53	Repository: retail/backports/3.0RR20Q1/org.openbravo.retail.discounts Changeset: af544054acfefbe33c946e7a0b8c94daa558c3e7 Author: Ranjith S R <ranjith <at> qualiantech.com> Date: Fri Feb 21 11:23:16 2020 +0530 URL: http://code.openbravo.com/retail/backports/3.0RR20Q1/org.openbravo.retail.discounts/rev/af544054acfefbe33c946e7a0b8c94daa558c3e7 [^] Fixed issue 43282 : Updated Discount Calculation for Characteristics Definition * If discount is defined with "Only those defined", then discount should be applied if any one of the characteristics present --- M web/org.openbravo.retail.discounts/js/discountsengine/common/discount-rules.js ---

Issue History
Date Modified	Username	Field	Change
2020-02-20 15:31	ranjith_qualiantech_com	Type	defect => backport
2020-02-20 15:31	ranjith_qualiantech_com	Target Version	=> RR20Q1
2020-02-21 06:53	hgbot	Checkin
2020-02-21 06:53	hgbot	Note Added: 0117993
2020-02-21 06:53	hgbot	Status	scheduled => resolved
2020-02-21 06:53	hgbot	Resolution	open => fixed
2020-02-21 06:53	hgbot	Fixed in SCM revision	http://code.openbravo.com/erp/pmods/org.openbravo.retail.discounts/rev/38d39c4d560b2115a78f3dd41bd579e89c195124 [^] => http://code.openbravo.com/retail/backports/3.0RR20Q1/org.openbravo.retail.discounts/rev/af544054acfefbe33c946e7a0b8c94daa558c3e7 [^]
2020-02-21 12:42	guilleaer	Review Assigned To	=> guilleaer
2020-02-21 12:42	guilleaer	Status	resolved => closed
2020-02-21 12:42	guilleaer	Fixed in Version	=> RR20Q1