0043282: Discounts with Characteristics. Having diferent characteristics work as "OR" instead of "AND"

Openbravo Issue Tracking System - Retail Modules

View Issue Details

Project

Category

View Status

Date Submitted

Last Update

0043282

Retail Modules

Discounts and Promotions

public

2020-02-13 08:10

2020-02-21 12:42

Reporter

psarobe

Assigned To

ranjith_qualiantech_com

Priority

urgent

Severity

major

Reproducibility

always

Status

closed

Resolution

fixed

Platform

OS Version

Product Version

Target Version

RR20Q1

Fixed in Version

RR20Q1

Merge Request Status

Review Assigned To

guilleaer

OBNetwork customer

Support ticket

Regression level

Production - QA Approved

Regression date

2019-08-02

Regression introduced in release

RR19Q4

Regression introduced by commit

https://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/file/711d273a9a3a/web/org.openbravo.retail.posterminal/js/model/order.js [^]

Triggers an Emergency Pack

Summary

0043282: Discounts with Characteristics. Having diferent characteristics work as "OR" instead of "AND"

Description

If you have two characterstics:
- Season
- Brand

And you use these two in the characteristic tab as:
- Season: 2019
- Brand: Gucci

Instead of applying the discount to the products that are in season 2019 and Gucci is applying to either products in season 2019 or with brand Gucci

Steps To Reproduce

1. Create two characteristics with values
2. In the discount and promotion window select price adjustment with 10%
3. Move to the Characteristics tab and add these two characteristics and with value in each.
4. Go to POS and see the result.

Expected result:
- Only for products that are season 2019 and Gucci

Current result:
- It is applying to either products that in season 2019 or Gucci

Proposed Solution

This is the expected behaviour with the current definition. We need to improve the configuration options so that we can support both ways of working.

The proposal is the following:
- First we need to change the configuration options of the "Included characteristics". We need to replace the "Only the values defined" by "Any of the ones defined" (change only the displayed value, we should not change the internal value of the reflist to preserve the compatibility with previous data), and we need to add a new one called "All of the values defined".
- After that we need to change the discount-rules.js file (specifically the isApplicableToLine function), to take into account this new value, so that if it is set, all characteristic values specified in the discount need to be present in the product for the discount to be applicable to the line.

Additional Information