Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue Details[ Jump to Notes ] [ Issue History ] [ Print ]
ID
0039459
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[Openbravo ERP] A. Platformminoralways2018-10-16 14:062018-12-11 20:22
ReporterjarmendarizView Statuspublic 
Assigned Tocaristu 
PrioritynormalResolutionfixedFixed in Version3.0PR19Q1
StatusclosedFix in branchFixed in SCM revision6166413117d8
ProjectionnoneETAnoneTarget Version
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Review Assigned Tojarmendariz
Web browser
ModulesCore
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0039459: MessageBar is not showing properly in a Process Window using retryExecution message

DescriptionHaving a Process/Process definition window accesed from the menu, and the corresponding ActionHandler that generates the response using the ResponseActionsBuilder.retryExecution(Type, Message) method, this message is shown in the window with no messageBar background (see attached picture)
Steps To Reproduce- Install org.openbravo.client.application.example module.

- Apply the retryExecutionMsg.patch file over this module.

- Recompile using ant smartbuild -Dlocal=no to apply database changes.

- Start tomcat

- Go to Application|Application Examples|P&E Window Example

- Tap into Done button

- A "This is a sample message" message should appear at the top with no background as the screenshot provided.
Proposed SolutionTwo approaches can be taken:

- In ResponseActionBuilder.retryExecution(MessageType,String), "msgType" key in retryExecutionMsg can be replaced to "severity"

- Change the client-side code to expect the messageBar type value in "msgType" instead of "severity", just like as if using ResponseActionBuilder.showMsgInProcessView(MessageType, String, String)
TagsNo tags attached.
Attached Filespng file icon Screenshot from 2018-10-16 14-02-19.png [^] (37,342 bytes) 2018-10-16 14:06


patch file icon retryExecutionMsg.patch [^] (4,022 bytes) 2018-10-16 14:07 [Show Content]

- Relationships [ Relation Graph ] [ Dependency Graph ]
related to feature request 0035074 closedcaristu Create a builder for the BaseProcessActionHandler response actions 

-  Notes
(0107364)
hgbot (developer)
2018-10-17 13:03

 Repository: erp/devel/pi
Changeset: 6166413117d874a521637b20d8e10c8c6aa62c72
Author: Carlos Aristu <carlos.aristu <at> openbravo.com>
Date: Wed Oct 17 13:01:48 2018 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/6166413117d874a521637b20d8e10c8c6aa62c72 [^]

fixes issue 39459: retry execution additional message is not built properly

  The JSONObject built with the message contents for the retryExecution response action does not define the message type properly. The type of message must be specified with the "severity" property according to the retryExecution implementation[1].

  [1] https://code.openbravo.com/erp/devel/pi/file/tip/modules/org.openbravo.client.application/web/org.openbravo.client.application/js/process/ob-parameter-window-view.js#l254 [^]

---
M modules/org.openbravo.client.application/src/org/openbravo/client/application/process/ResponseActionsBuilder.java
---
(0107365)
hgbot (developer)
2018-10-17 13:14

 Repository: erp/devel/pi
Changeset: 9f9a22f6dd90d94fbdf8844da5fd2f74d37d264c
Author: Carlos Aristu <carlos.aristu <at> openbravo.com>
Date: Wed Oct 17 13:12:31 2018 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/9f9a22f6dd90d94fbdf8844da5fd2f74d37d264c [^]

related to issue 39459: allow to define a retry execution message with a title

---
M modules/org.openbravo.client.application/src/org/openbravo/client/application/process/ResponseActionsBuilder.java
---
(0107371)
hgbot (developer)
2018-10-17 16:16

 Repository: erp/mods/org.openbravo.client.application.examples
Changeset: 02c48f06b8759583c0f8e02e451c4632786a573e
Author: Javier Armendáriz <javier.armendariz <at> openbravo.com>
Date: Wed Oct 17 16:16:13 2018 +0200
URL: http://code.openbravo.com/erp/mods/org.openbravo.client.application.examples/rev/02c48f06b8759583c0f8e02e451c4632786a573e [^]

Related to issue 39459: MessageBar is not showing properly in a Process Window.

Added an example that reproduces the scenario described in the issue:
A process window accesed from the menu and the success message is generated
using the getResponseBuilder().retryExecution(MessageType, String) method.

---
M src-db/database/sourcedata/AD_MENU.xml
M src-db/database/sourcedata/AD_TREENODE.xml
M src/org/openbravo/client/application/examples/PickExampleActionHandler.java
---
(0107372)
jarmendariz (developer)
2018-10-17 16:17

 Reviewed
(0108432)
hudsonbot (developer)
2018-12-11 20:22

 A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/470e3cd384c5 [^]
Maturity status: Test
(0108433)
hudsonbot (developer)
2018-12-11 20:22

 A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/470e3cd384c5 [^]
Maturity status: Test

- Issue History
Date Modified Username Field Change
2018-10-16 14:06 jarmendariz New Issue
2018-10-16 14:06 jarmendariz Assigned To => platform
2018-10-16 14:06 jarmendariz File Added: Screenshot from 2018-10-16 14-02-19.png
2018-10-16 14:06 jarmendariz Modules => Core
2018-10-16 14:06 jarmendariz Triggers an Emergency Pack => No
2018-10-16 14:07 jarmendariz File Added: retryExecutionMsg.patch
2018-10-16 14:12 jarmendariz Steps to Reproduce Updated View Revisions
2018-10-16 14:16 jarmendariz Steps to Reproduce Updated View Revisions
2018-10-16 14:16 jarmendariz Proposed Solution updated
2018-10-17 09:15 jarmendariz Relationship added related to 0035074
2018-10-17 13:03 hgbot Checkin
2018-10-17 13:03 hgbot Note Added: 0107364
2018-10-17 13:03 hgbot Status new => resolved
2018-10-17 13:03 hgbot Resolution open => fixed
2018-10-17 13:03 hgbot Fixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/6166413117d874a521637b20d8e10c8c6aa62c72 [^]
2018-10-17 13:03 caristu Assigned To platform => caristu
2018-10-17 13:04 caristu Review Assigned To => jarmendariz
2018-10-17 13:14 hgbot Checkin
2018-10-17 13:14 hgbot Note Added: 0107365
2018-10-17 16:16 hgbot Checkin
2018-10-17 16:16 hgbot Note Added: 0107371
2018-10-17 16:17 jarmendariz Note Added: 0107372
2018-10-17 16:18 jarmendariz Status resolved => closed
2018-10-17 16:18 jarmendariz Fixed in Version => 3.0PR19Q1
2018-12-11 20:22 hudsonbot Checkin
2018-12-11 20:22 hudsonbot Note Added: 0108432
2018-12-11 20:22 hudsonbot Checkin
2018-12-11 20:22 hudsonbot Note Added: 0108433

Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker