Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue Details[ Jump to Notes ] [ Issue History ] [ Print ]
ID
0035074
TypeCategorySeverityReproducibilityDate SubmittedLast Update
feature request[Openbravo ERP] A. PlatformminorN/A2017-01-27 15:252017-03-15 20:18
ReportercaristuView Statuspublic 
Assigned Tocaristu 
PrioritynormalResolutionfixedFixed in Version3.0PR17Q2
StatusclosedFix in branchFixed in SCM revision4e550fa86b96
ProjectionnoneETAnoneTarget Version
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Review Assigned Toalostale
Web browser
ModulesCore
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0035074: Create a builder for the BaseProcessActionHandler response actions

DescriptionIt would be nice to have an utility class that would help to build the response actions to be returned by the classes extending BaseProcessActionHandler.

This will help to:
- Make easy the way of building the JSON response
- Have cleaner / less duplicated code
Steps To ReproduceIn description
TagsNo tags attached.
Attached Files

- Relationships [ Relation Graph ] [ Dependency Graph ]
related to defect 0039459 closedcaristu MessageBar is not showing properly in a Process Window using retryExecution message 
blocks feature request 0035091 newTriage Omni OMS Review classes extending BaseProcessActionHandler to use ResponseActionsBuilder to generate the response 
blocks feature request 0035149 closedcaristu Review classes extending BaseProcessActionHandler to use ResponseActionsBuilder to generate the response 

-  Notes
(0093940)
hgbot (developer)
2017-01-30 17:43

 Repository: erp/devel/pi
Changeset: 4e550fa86b96b2b5bedfc49db20647be8ea0576e
Author: Carlos Aristu <carlos.aristu <at> openbravo.com>
Date: Mon Jan 30 17:42:56 2017 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/4e550fa86b96b2b5bedfc49db20647be8ea0576e [^]

fixes bug 35074: Create a builder for BaseProcessActionHandler response actions

---
M modules/org.openbravo.client.application/src/org/openbravo/client/application/process/BaseProcessActionHandler.java
A modules/org.openbravo.client.application/src/org/openbravo/client/application/process/ResponseActionsBuilder.java
---
(0093941)
hgbot (developer)
2017-01-30 17:51

 Repository: erp/devel/pi
Changeset: dae49ca8d9a0436bf5bbea7d013c76e117e1c55e
Author: Carlos Aristu <carlos.aristu <at> openbravo.com>
Date: Mon Jan 30 17:50:53 2017 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/dae49ca8d9a0436bf5bbea7d013c76e117e1c55e [^]

related to bug 35074: Leave just useful information in javadoc

---
M modules/org.openbravo.client.application/src/org/openbravo/client/application/process/ResponseActionsBuilder.java
---
(0093944)
hgbot (developer)
2017-01-30 18:38

 Repository: erp/devel/pi
Changeset: 30aa6e6fdf64da83e8f9d57f06a635cfdb11923c
Author: Carlos Aristu <carlos.aristu <at> openbravo.com>
Date: Mon Jan 30 18:37:31 2017 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/30aa6e6fdf64da83e8f9d57f06a635cfdb11923c [^]

related to bug 35074: Added new method for the API
Overload openDirectTab method to use that action just by speficifying the tab ID and whether the action should wait.

---
M modules/org.openbravo.client.application/src/org/openbravo/client/application/process/ResponseActionsBuilder.java
---
(0093946)
hgbot (developer)
2017-01-30 19:00

 Repository: erp/devel/pi
Changeset: da2da786d436560ccbd1ab47371f3a8e621a9630
Author: Carlos Aristu <carlos.aristu <at> openbravo.com>
Date: Mon Jan 30 18:59:33 2017 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/da2da786d436560ccbd1ab47371f3a8e621a9630 [^]

related to bug 35074: Updated argument types in javadoc

---
M modules/org.openbravo.client.application/src/org/openbravo/client/application/process/ResponseActionsBuilder.java
---
(0093952)
caristu (developer)
2017-01-31 08:46

 Updated wiki page: http://wiki.openbravo.com/wiki/How_to_create_a_Standard_Process_Definition#Returning_Several_Actions [^]
(0093975)
caristu (developer)
2017-02-01 08:57

 Use examples:

https://code.openbravo.com/erp/mods/org.openbravo.client.application.examples/rev/b44787df5330 [^]

https://code.openbravo.com/erp/mods/org.openbravo.platform.features/rev/4efe5ab58029 [^]
(0094024)
alostale (manager)
2017-02-03 08:36

 reopening: see code review https://docs.google.com/spreadsheets/d/18l2biKWeG6iGDIPqO6VuYQ_TtP_6YxyQU4KSrPvQlJ8/edit#gid=0 [^]
(0094028)
hgbot (developer)
2017-02-03 09:15

 Repository: erp/devel/pi
Changeset: c344d1fd052db9a3c064de646a497a72dc16f85b
Author: Carlos Aristu <carlos.aristu <at> openbravo.com>
Date: Fri Feb 03 09:14:10 2017 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/c344d1fd052db9a3c064de646a497a72dc16f85b [^]

related to bug 35074: handle JSON exceptions inside ResponseActionsBuilder

ResponseActionsBuilder class itself should take care of handling the possible JSON exceptions, instead of exposing them by throwing the exceptions with its public methods. So, now we are handling the exceptions inside the class. Moreover, in practice this exceptions will never happen.

---
M modules/org.openbravo.client.application/src/org/openbravo/client/application/process/ResponseActionsBuilder.java
---
(0094030)
alostale (manager)
2017-02-03 09:38

 code reviewed
(0095140)
hudsonbot (developer)
2017-03-15 20:18

 A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/54e102bef53e [^]
Maturity status: Test
(0095141)
hudsonbot (developer)
2017-03-15 20:18

 A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/54e102bef53e [^]
Maturity status: Test
(0095143)
hudsonbot (developer)
2017-03-15 20:18

 A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/54e102bef53e [^]
Maturity status: Test
(0095144)
hudsonbot (developer)
2017-03-15 20:18

 A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/54e102bef53e [^]
Maturity status: Test
(0095153)
hudsonbot (developer)
2017-03-15 20:18

 A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/54e102bef53e [^]
Maturity status: Test

- Issue History
Date Modified Username Field Change
2017-01-27 15:25 caristu New Issue
2017-01-27 15:25 caristu Assigned To => platform
2017-01-27 15:25 caristu Modules => Core
2017-01-27 15:25 caristu Triggers an Emergency Pack => No
2017-01-27 15:27 caristu Assigned To platform => caristu
2017-01-27 15:27 caristu Description Updated View Revisions
2017-01-30 17:43 hgbot Checkin
2017-01-30 17:43 hgbot Note Added: 0093940
2017-01-30 17:43 hgbot Status new => resolved
2017-01-30 17:43 hgbot Resolution open => fixed
2017-01-30 17:43 hgbot Fixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/4e550fa86b96b2b5bedfc49db20647be8ea0576e [^]
2017-01-30 17:51 hgbot Checkin
2017-01-30 17:51 hgbot Note Added: 0093941
2017-01-30 18:08 caristu Note Added: 0093943
2017-01-30 18:20 caristu Relationship added related to 0035091
2017-01-30 18:38 hgbot Checkin
2017-01-30 18:38 hgbot Note Added: 0093944
2017-01-30 18:38 caristu Note Deleted: 0093943
2017-01-30 18:39 caristu Note Added: 0093945
2017-01-30 19:00 hgbot Checkin
2017-01-30 19:00 hgbot Note Added: 0093946
2017-01-31 08:46 caristu Note Deleted: 0093945
2017-01-31 08:46 caristu Note Added: 0093952
2017-02-01 08:57 caristu Note Added: 0093975
2017-02-01 08:57 caristu Review Assigned To => alostale
2017-02-03 08:16 alostale Status resolved => closed
2017-02-03 08:16 alostale Fixed in Version => 3.0PR17Q2
2017-02-03 08:16 alostale Relationship replaced blocks 0035091
2017-02-03 08:18 alostale Relationship added blocks 0035149
2017-02-03 08:36 alostale Note Added: 0094024
2017-02-03 08:36 alostale Status closed => new
2017-02-03 08:36 alostale Resolution fixed => open
2017-02-03 08:36 alostale Fixed in Version 3.0PR17Q2 =>
2017-02-03 09:15 hgbot Checkin
2017-02-03 09:15 hgbot Note Added: 0094028
2017-02-03 09:15 caristu Issue Monitored: alostale
2017-02-03 09:15 caristu Status new => scheduled
2017-02-03 09:16 caristu Status scheduled => resolved
2017-02-03 09:16 caristu Resolution open => fixed
2017-02-03 09:38 alostale Note Added: 0094030
2017-02-03 09:38 alostale Status resolved => closed
2017-02-03 09:38 alostale Fixed in Version => 3.0PR17Q2
2017-03-15 20:18 hudsonbot Checkin
2017-03-15 20:18 hudsonbot Note Added: 0095140
2017-03-15 20:18 hudsonbot Checkin
2017-03-15 20:18 hudsonbot Note Added: 0095141
2017-03-15 20:18 hudsonbot Checkin
2017-03-15 20:18 hudsonbot Note Added: 0095143
2017-03-15 20:18 hudsonbot Checkin
2017-03-15 20:18 hudsonbot Note Added: 0095144
2017-03-15 20:18 hudsonbot Checkin
2017-03-15 20:18 hudsonbot Note Added: 0095153
2018-10-17 09:15 jarmendariz Relationship added related to 0039459

Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker