Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0039459Openbravo ERPA. Platformpublic2018-10-16 14:062018-12-11 20:22
Reporterjarmendariz 
Assigned Tocaristu 
PrioritynormalSeverityminorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version3.0PR19Q1 
Merge Request Status
Review Assigned Tojarmendariz
OBNetwork customer
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0039459: MessageBar is not showing properly in a Process Window using retryExecution message
DescriptionHaving a Process/Process definition window accesed from the menu, and the corresponding ActionHandler that generates the response using the ResponseActionsBuilder.retryExecution(Type, Message) method, this message is shown in the window with no messageBar background (see attached picture)
Steps To Reproduce- Install org.openbravo.client.application.example module.

- Apply the retryExecutionMsg.patch file over this module.

- Recompile using ant smartbuild -Dlocal=no to apply database changes.

- Start tomcat

- Go to Application|Application Examples|P&E Window Example

- Tap into Done button

- A "This is a sample message" message should appear at the top with no background as the screenshot provided.
Proposed SolutionTwo approaches can be taken:

- In ResponseActionBuilder.retryExecution(MessageType,String), "msgType" key in retryExecutionMsg can be replaced to "severity"

- Change the client-side code to expect the messageBar type value in "msgType" instead of "severity", just like as if using ResponseActionBuilder.showMsgInProcessView(MessageType, String, String)
Additional Information
TagsNo tags attached.
Relationships
related to feature request 0035074 closed caristu Create a builder for the BaseProcessActionHandler response actions 
Attached Filespng Screenshot from 2018-10-16 14-02-19.png (37,342) 2018-10-16 14:06
https://issues.openbravo.com/file_download.php?file_id=12272&type=bug
png

patch retryExecutionMsg.patch (4,022) 2018-10-16 14:07
https://issues.openbravo.com/file_download.php?file_id=12273&type=bug
Issue History
Date ModifiedUsernameFieldChange
2018-10-16 14:06jarmendarizNew Issue
2018-10-16 14:06jarmendarizAssigned To => platform
2018-10-16 14:06jarmendarizFile Added: Screenshot from 2018-10-16 14-02-19.png
2018-10-16 14:06jarmendarizModules => Core
2018-10-16 14:06jarmendarizTriggers an Emergency Pack => No
2018-10-16 14:07jarmendarizFile Added: retryExecutionMsg.patch
2018-10-16 14:12jarmendarizSteps to Reproduce Updatedbug_revision_view_page.php?rev_id=17766#r17766
2018-10-16 14:16jarmendarizSteps to Reproduce Updatedbug_revision_view_page.php?rev_id=17767#r17767
2018-10-16 14:16jarmendarizProposed Solution updated
2018-10-17 09:15jarmendarizRelationship addedrelated to 0035074
2018-10-17 13:03hgbotCheckin
2018-10-17 13:03hgbotNote Added: 0107364
2018-10-17 13:03hgbotStatusnew => resolved
2018-10-17 13:03hgbotResolutionopen => fixed
2018-10-17 13:03hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/6166413117d874a521637b20d8e10c8c6aa62c72 [^]
2018-10-17 13:03caristuAssigned Toplatform => caristu
2018-10-17 13:04caristuReview Assigned To => jarmendariz
2018-10-17 13:14hgbotCheckin
2018-10-17 13:14hgbotNote Added: 0107365
2018-10-17 16:16hgbotCheckin
2018-10-17 16:16hgbotNote Added: 0107371
2018-10-17 16:17jarmendarizNote Added: 0107372
2018-10-17 16:18jarmendarizStatusresolved => closed
2018-10-17 16:18jarmendarizFixed in Version => 3.0PR19Q1
2018-12-11 20:22hudsonbotCheckin
2018-12-11 20:22hudsonbotNote Added: 0108432
2018-12-11 20:22hudsonbotCheckin
2018-12-11 20:22hudsonbotNote Added: 0108433

Notes
(0107364)
hgbot   
2018-10-17 13:03   
Repository: erp/devel/pi
Changeset: 6166413117d874a521637b20d8e10c8c6aa62c72
Author: Carlos Aristu <carlos.aristu <at> openbravo.com>
Date: Wed Oct 17 13:01:48 2018 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/6166413117d874a521637b20d8e10c8c6aa62c72 [^]

fixes issue 39459: retry execution additional message is not built properly

  The JSONObject built with the message contents for the retryExecution response action does not define the message type properly. The type of message must be specified with the "severity" property according to the retryExecution implementation[1].

  [1] https://code.openbravo.com/erp/devel/pi/file/tip/modules/org.openbravo.client.application/web/org.openbravo.client.application/js/process/ob-parameter-window-view.js#l254 [^]

---
M modules/org.openbravo.client.application/src/org/openbravo/client/application/process/ResponseActionsBuilder.java
---
(0107365)
hgbot   
2018-10-17 13:14   
Repository: erp/devel/pi
Changeset: 9f9a22f6dd90d94fbdf8844da5fd2f74d37d264c
Author: Carlos Aristu <carlos.aristu <at> openbravo.com>
Date: Wed Oct 17 13:12:31 2018 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/9f9a22f6dd90d94fbdf8844da5fd2f74d37d264c [^]

related to issue 39459: allow to define a retry execution message with a title

---
M modules/org.openbravo.client.application/src/org/openbravo/client/application/process/ResponseActionsBuilder.java
---
(0107371)
hgbot   
2018-10-17 16:16   
Repository: erp/mods/org.openbravo.client.application.examples
Changeset: 02c48f06b8759583c0f8e02e451c4632786a573e
Author: Javier Armendáriz <javier.armendariz <at> openbravo.com>
Date: Wed Oct 17 16:16:13 2018 +0200
URL: http://code.openbravo.com/erp/mods/org.openbravo.client.application.examples/rev/02c48f06b8759583c0f8e02e451c4632786a573e [^]

Related to issue 39459: MessageBar is not showing properly in a Process Window.

Added an example that reproduces the scenario described in the issue:
A process window accesed from the menu and the success message is generated
using the getResponseBuilder().retryExecution(MessageType, String) method.

---
M src-db/database/sourcedata/AD_MENU.xml
M src-db/database/sourcedata/AD_TREENODE.xml
M src/org/openbravo/client/application/examples/PickExampleActionHandler.java
---
(0107372)
jarmendariz   
2018-10-17 16:17   
Reviewed
(0108432)
hudsonbot   
2018-12-11 20:22   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/470e3cd384c5 [^]
Maturity status: Test
(0108433)
hudsonbot   
2018-12-11 20:22   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/470e3cd384c5 [^]
Maturity status: Test