Project:
View Issue Details[ Jump to Notes ] | [ Issue History ] [ Print ] | |||||||
ID | ||||||||
0036193 | ||||||||
Type | Category | Severity | Reproducibility | Date Submitted | Last Update | |||
defect | [Openbravo ERP] A. Platform | minor | have not tried | 2017-06-07 17:51 | 2017-06-09 15:32 | |||
Reporter | adrianromero | View Status | public | |||||
Assigned To | alostale | |||||||
Priority | low | Resolution | fixed | Fixed in Version | 3.0PR17Q3 | |||
Status | closed | Fix in branch | Fixed in SCM revision | 198240535488 | ||||
Projection | none | ETA | none | Target Version | ||||
OS | Any | Database | Any | Java version | ||||
OS Version | Database version | Ant version | ||||||
Product Version | SCM revision | |||||||
Review Assigned To | caristu | |||||||
Web browser | ||||||||
Modules | Core | |||||||
Regression level | ||||||||
Regression date | ||||||||
Regression introduced in release | ||||||||
Regression introduced by commit | ||||||||
Triggers an Emergency Pack | No | |||||||
Summary | 0036193: DefaultJsonDataService logs an exception if property *obSelected* is not found in the Entity when fetching data for PickAndEdit | |||||||
Description | DefaultJsonDataService checks for the value of obSelected when fetching data for PickAndEdit in order to adapt the page size to include all selected records into the response. The problem is that obSelected property does not exist in the entity an exception is registered in the Openbravo log but this case is silently ignored by DefautJsonDataService considering no action should be performed. This is the line where obSelected value is requested to the entity: https://code.openbravo.com/erp/devel/pi/annotate/70c67cc6cf8b/modules/org.openbravo.service.json/src/org/openbravo/service/json/DefaultJsonDataService.java#l350 [^] | |||||||
Steps To Reproduce | This has been detected due to the following log record: ERROR org.openbravo.base.util.CheckException - Property obSelected does not exist for entity FIN_Payment org.openbravo.base.util.CheckException: Property obSelected does not exist for entity FIN_Payment at org.openbravo.base.util.Check.isNotNull(Check.java:72) at org.openbravo.base.model.Entity.getProperty(Entity.java:568) at org.openbravo.base.model.Entity.getProperty(Entity.java:550) at org.openbravo.base.structure.BaseOBObject.get(BaseOBObject.java:254) at org.openbravo.base.structure.BaseOBObject.get(BaseOBObject.java:232) at org.openbravo.base.structure.BaseOBObject.get(BaseOBObject.java:213) at org.openbravo.service.json.DefaultJsonDataService.isLastRecordSelected(DefaultJsonDataService.java:380) at org.openbravo.service.json.DefaultJsonDataService.shouldIncreasePageSize(DefaultJsonDataService.java:368) at org.openbravo.service.json.DefaultJsonDataService.fetch(DefaultJsonDataService.java:252) at org.openbravo.service.datasource.DefaultDataSourceService.fetch(DefaultDataSourceService.java:85) at org.openbravo.service.datasource.DefaultDataSourceService.fetch(DefaultDataSourceService.java:78) at org.openbravo.service.datasource.DataSourceServlet.doFetch(DataSourceServlet.java:285) at org.openbravo.service.datasource.DataSourceServlet.doPost(DataSourceServlet.java:843) at javax.servlet.http.HttpServlet.service(HttpServlet.java:648) at org.openbravo.base.HttpBaseServlet.serviceInitialized(HttpBaseServlet.java:228) at org.openbravo.base.secureApp.HttpSecureAppServlet.service(HttpSecureAppServlet.java:452) at org.openbravo.client.kernel.BaseKernelServlet.callServiceInSuper(BaseKernelServlet.java:87) at org.openbravo.client.kernel.BaseKernelServlet.service(BaseKernelServlet.java:58) at org.openbravo.service.datasource.DataSourceServlet.service(DataSourceServlet.java:153) at javax.servlet.http.HttpServlet.service(HttpServlet.java:729) at org.ap | |||||||
Proposed Solution | Avoid asking directly the value of obSelected. Check first whether obSelected exists or not in the entity fetched. See attached patch. | |||||||
Tags | SER-QA | |||||||
Attached Files | issue0036193.patch [^] (1,157 bytes) 2017-06-07 17:54 [Show Content] | |||||||
Relationships [ Relation Graph ] [ Dependency Graph ] | ||||||||||||||||||||||
|
Notes | |
(0097203) alostale (manager) 2017-06-08 11:02 |
Downgraded severity according to reporting guidelines [1]. [1] http://wiki.openbravo.com/wiki/Bug_Reporting_Guidelines#How_to_Choose_the_Right_Severity [^] |
(0097221) hgbot (developer) 2017-06-08 15:05 |
Repository: erp/devel/pi Changeset: 1982405354887d1be6897cbf4eb7d8668cd925a7 Author: Asier Lostalé <asier.lostale <at> openbravo.com> Date: Thu Jun 08 15:03:10 2017 +0200 URL: http://code.openbravo.com/erp/devel/pi/rev/1982405354887d1be6897cbf4eb7d8668cd925a7 [^] fixed bug 36193: fetch for P&E logs error if obSelected property does not exist Even exception was logged it was not thrown up, correctly returning false. This event shouldn't be logged at all. --- M modules/org.openbravo.service.json/src/org/openbravo/service/json/DefaultJsonDataService.java --- |
(0097263) hudsonbot (developer) 2017-06-09 02:49 |
A changeset related to this issue has been promoted main and to the Central Repository, after passing a series of tests. Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/682983c2eead [^] Maturity status: Test |
(0097292) caristu (developer) 2017-06-09 15:32 |
Code reviewed |
Issue History | |||
Date Modified | Username | Field | Change |
2017-06-07 17:51 | adrianromero | New Issue | |
2017-06-07 17:51 | adrianromero | Assigned To | => platform |
2017-06-07 17:51 | adrianromero | Modules | => Core |
2017-06-07 17:51 | adrianromero | Resolution time | => 1497996000 |
2017-06-07 17:51 | adrianromero | Triggers an Emergency Pack | => No |
2017-06-07 17:51 | adrianromero | Tag Attached: SER-QA | |
2017-06-07 17:53 | adrianromero | Relationship added | related to 0033622 |
2017-06-07 17:54 | adrianromero | File Added: issue0036193.patch | |
2017-06-08 10:58 | alostale | Relationship added | blocks 0036162 |
2017-06-08 11:02 | alostale | Resolution time | 1497996000 => |
2017-06-08 11:02 | alostale | Note Added: 0097203 | |
2017-06-08 11:02 | alostale | Priority | high => low |
2017-06-08 11:02 | alostale | Severity | major => minor |
2017-06-08 11:02 | alostale | Status | new => acknowledged |
2017-06-08 15:05 | hgbot | Checkin | |
2017-06-08 15:05 | hgbot | Note Added: 0097221 | |
2017-06-08 15:05 | hgbot | Status | acknowledged => resolved |
2017-06-08 15:05 | hgbot | Resolution | open => fixed |
2017-06-08 15:05 | hgbot | Fixed in SCM revision | => http://code.openbravo.com/erp/devel/pi/rev/1982405354887d1be6897cbf4eb7d8668cd925a7 [^] |
2017-06-08 15:07 | alostale | Review Assigned To | => caristu |
2017-06-08 15:07 | alostale | Assigned To | platform => alostale |
2017-06-09 02:49 | hudsonbot | Checkin | |
2017-06-09 02:49 | hudsonbot | Note Added: 0097263 | |
2017-06-09 15:32 | caristu | Note Added: 0097292 | |
2017-06-09 15:32 | caristu | Status | resolved => closed |
2017-06-09 15:32 | caristu | Fixed in Version | => 3.0PR17Q3 |
2019-03-22 09:57 | alostale | Relationship added | related to 0040381 |
Copyright © 2000 - 2009 MantisBT Group |